fix: Task - Pointer shows up for an archived task when hovering over the edge of the checkbox. by Krishna2323 · Pull Request #37260 · Expensify/App

Krishna2323 · 2024-02-27T04:22:00Z

Details

Fixed Issues

$ #37236
PROPOSAL: #37236 (comment)

Tests

Open ND and log in with any account
Go to announce room
Create a task
Delete the workspace in whose announce room the task is just created
Note that the task report was archived in LHN
Tap task in the archived announce room
Hover over the edge of the checkbox and verify disabled cursor is shown.

Verify that no errors appear in the JS console

Offline tests

Open ND and log in with any account
Go to announce room
Create a task
Delete the workspace in whose announce room the task is just created
Note that the task report was archived in LHN
Tap task in the archived announce room
Hover over the edge of the checkbox and verify disabled cursor is shown.

QA Steps

Open ND and log in with any account
Go to announce room
Create a task
Delete the workspace in whose announce room the task is just created
Note that the task report was archived in LHN
Tap task in the archived announce room
Hover over the edge of the checkbox and verify disabled cursor is shown.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…the edge of the checkbox. Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

melvin-bot · 2024-02-27T04:22:04Z

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ntdiary · 2024-02-28T16:17:44Z

Out sick today 🤒, will review this PR in 12 hours.

Krishna2323 · 2024-02-28T23:39:20Z

@ntdiary, hope you feel better soon!

ntdiary · 2024-02-29T03:31:36Z

App/src/styles/utils/index.ts

Line 932 in 3e74ddf

...cursor.cursorPointer,

@Krishna2323, we added the above line of code to solve the cursor style of BaseListItem, but based on my test, the list item will also has the similar problem:

test.mp4

We can fix them in this way:

diff --git a/src/components/SelectionList/BaseListItem.tsx b/src/components/SelectionList/BaseListItem.tsx
index 2f853dc558..96c493be9d 100644
--- a/src/components/SelectionList/BaseListItem.tsx
+++ b/src/components/SelectionList/BaseListItem.tsx
@@ -68,7 +68,7 @@ function BaseListItem<TItem extends ListItem>({
                             {canSelectMultiple && (
                                 <View
                                     role={CONST.ROLE.BUTTON}
-                                    style={StyleUtils.getCheckboxPressableStyle()}
+                                    style={[styles.cursorUnset, StyleUtils.getCheckboxPressableStyle()]}
                                 >
                                     <View style={selectMultipleStyle}>
                                         {item.isSelected && (
diff --git a/src/styles/utils/index.ts b/src/styles/utils/index.ts
index 72719e4795..a2949d8b4d 100644
--- a/src/styles/utils/index.ts
+++ b/src/styles/utils/index.ts
@@ -929,7 +929,6 @@ function getCheckboxPressableStyle(borderRadius = 6): ViewStyle {
         alignItems: 'center',
         // eslint-disable-next-line object-shorthand
         borderRadius: borderRadius,
-        ...cursor.cursorPointer,
     };
 }

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 · 2024-02-29T06:42:42Z

@ntdiary, can you pls check the changes once again? Thanks

ntdiary · 2024-02-29T09:24:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

37260-android-native.mp4

Android: mWeb Chrome

37260-android-chrome.mp4

iOS: Native

37260-ios-native.mp4

iOS: mWeb Safari

37260-ios-safari.mp4

MacOS: Chrome / Safari

37260-web.mp4

MacOS: Desktop

37260-desktop.mp4

ntdiary

LGTM. :)

jasperhuangg · 2024-03-01T18:55:02Z

conflicts!

Krishna2323 · 2024-03-02T10:02:02Z

Conflict resolved.

OSBotify · 2024-03-06T22:05:24Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.4.48-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-07T23:51:24Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.48-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: Task - Pointer shows up for an archived task when hovering over …

d8dc6e2

…the edge of the checkbox. Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 requested a review from a team as a code owner February 27, 2024 04:22

melvin-bot bot removed the request for review from a team February 27, 2024 04:22

melvin-bot bot requested a review from ntdiary February 27, 2024 04:22

Merge branch 'Expensify:main' into krishna2323/issue/37236

0373f6b

Update as suggested.

580a53e

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

ntdiary approved these changes Feb 29, 2024

View reviewed changes

melvin-bot bot requested a review from jasperhuangg February 29, 2024 11:17

jasperhuangg previously approved these changes Mar 1, 2024

View reviewed changes

Merge branch 'main' into krishna2323/issue/37236

d8cd368

Krishna2323 dismissed jasperhuangg’s stale review via d8cd368 March 2, 2024 10:00

jasperhuangg approved these changes Mar 5, 2024

View reviewed changes

jasperhuangg merged commit 9e41103 into Expensify:main Mar 5, 2024

github-actions bot mentioned this pull request Mar 6, 2024

Deploy Checklist: New Expensify 2024-03-06 #37845

Closed

63 tasks

melvin-bot bot mentioned this pull request Mar 7, 2024

[HOLD for payment 2024-03-14] [$500] Task - Pointer shows up for an archived task when hovering over the edge of the checkbox #37236

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Task - Pointer shows up for an archived task when hovering over the edge of the checkbox.#37260

fix: Task - Pointer shows up for an archived task when hovering over the edge of the checkbox.#37260
jasperhuangg merged 4 commits intoExpensify:mainfrom
Krishna2323:krishna2323/issue/37236

Krishna2323 commented Feb 27, 2024 •

edited

Loading

Uh oh!

melvin-bot bot commented Feb 27, 2024

Uh oh!

ntdiary commented Feb 28, 2024

Uh oh!

Krishna2323 commented Feb 28, 2024

Uh oh!

ntdiary commented Feb 29, 2024

Uh oh!

Krishna2323 commented Feb 29, 2024

Uh oh!

ntdiary commented Feb 29, 2024 •

edited

Loading

Uh oh!

ntdiary left a comment

Uh oh!

jasperhuangg commented Mar 1, 2024

Uh oh!

Krishna2323 commented Mar 2, 2024

Uh oh!

OSBotify commented Mar 6, 2024

Uh oh!

OSBotify commented Mar 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Krishna2323 commented Feb 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 27, 2024

Uh oh!

ntdiary commented Feb 28, 2024

Uh oh!

Krishna2323 commented Feb 28, 2024

Uh oh!

ntdiary commented Feb 29, 2024

Uh oh!

Krishna2323 commented Feb 29, 2024

Uh oh!

ntdiary commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ntdiary left a comment

Choose a reason for hiding this comment

Uh oh!

jasperhuangg commented Mar 1, 2024

Uh oh!

Krishna2323 commented Mar 2, 2024

Uh oh!

OSBotify commented Mar 6, 2024

Uh oh!

OSBotify commented Mar 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Krishna2323 commented Feb 27, 2024 •

edited

Loading

ntdiary commented Feb 29, 2024 •

edited

Loading