fix: The selection is smaller than member name row when navigating by dukenv0307 · Pull Request #37319 · Expensify/App

dukenv0307 · 2024-02-27T16:33:52Z

Details

Fixed Issues

$ #37293
PROPOSAL: #37293 (comment)

Tests

Go to Workspace settings
Select a workspace
Go to Members
Navigate through Members list with up and down key
Verify that: The selection that appears on the member is of the same size as the member name row

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to Workspace settings
Select a workspace
Go to Members
Navigate through Members list with up and down key
Verify that: The selection that appears on the member is of the same size as the member name row

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-mweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…a keyboard

melvin-bot · 2024-02-27T16:39:53Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2024-02-27T16:44:45Z

src/components/SelectionList/TableListItem.tsx

@@ -30,7 +30,7 @@ function TableListItem({
        <BaseListItem
            item={item}
            pressableStyle={[[styles.selectionListPressableItemWrapper, isFocused && styles.activeComponentBG]]}


can we update the old style here to sidebarLinkActive. To align with other list styles when it's focused

cc @dukenv0307 ^

@hoangzinh can you confirm with internal first before I change it?

@pecanoro what do you think about this one? I found that we're using sidebarLinkActive in the invite member or search page as a background color when an item is focused as well.

Hmm, I am not sure if that is what we want, tagging @shawnborton to confirm this is fine.

If I understood correctly, it seems we are using activeComponentBG to focus elements in some pages but then sidebarLinkActive for others. @hoangzinh is that what you meant?

Ah yes, we want a background color when a row is :focus by keyboard navigation here (using up/down keyboard). I found that we're using sidebarLinkActive which is theme.buttonHoveredBG in other pages like Search/Invite member/even the previous workspace member page.

I agree with aligning this with how we handle it on other pages, so +1 for consistency there.

Nice! @dukenv0307 Let's change it to sidebarLinkActive then?

@hoangzinh i just updated code, please check again.

hoangzinh · 2024-02-27T17:22:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-28.at.00.04.06.android.mov

Android: mWeb Chrome

Screen.Recording.2024-02-28.at.00.05.51.android.chrome.mov

iOS: Native

Screen.Recording.2024-02-28.at.00.10.58.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-02-28.at.00.13.22.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-27.at.23.49.50.web.mov

MacOS: Desktop

Screen.Recording.2024-02-28.at.00.01.09.desktop.mov

hoangzinh

It looks like @dukenv0307 is not available atm. Given this is a DB blocker, It's fine to me with current background color when a member is focused. We can have a follow-up PR if needed.

pecanoro · 2024-02-27T18:10:47Z

@hoangzinh The bug was minor so I removed the deploy blocker label so we don't have to rush it

hoangzinh

LGTM. Tested again.

OSBotify · 2024-02-29T16:12:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-29T20:46:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-29T23:43:37Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.4.46-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-04T20:25:51Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.46-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: The selection is smaller than member name row when navigating vi…

3bfd653

…a keyboard

dukenv0307 changed the title ~~fix: The selection is smaller than member name row when navigating vi…~~ fix: The selection is smaller than member name row when navigating Feb 27, 2024

dukenv0307 marked this pull request as ready for review February 27, 2024 16:39

dukenv0307 requested a review from a team as a code owner February 27, 2024 16:39

melvin-bot bot requested review from hoangzinh and removed request for a team February 27, 2024 16:39

dukenv0307 mentioned this pull request Feb 27, 2024

[HOLD for payment 2024-03-11] [$500] Workspace - The selection is smaller than member name row when navigating via keyboard #37293

Closed

6 tasks

hoangzinh reviewed Feb 27, 2024

View reviewed changes

hoangzinh approved these changes Feb 27, 2024

View reviewed changes

melvin-bot bot requested a review from pecanoro February 27, 2024 17:25

fix bg focus item in table list

04952c7

hoangzinh approved these changes Feb 29, 2024

View reviewed changes

pecanoro approved these changes Feb 29, 2024

View reviewed changes

pecanoro merged commit 0cc5817 into Expensify:main Feb 29, 2024

github-actions bot mentioned this pull request Feb 29, 2024

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #37527

Closed

github-actions bot mentioned this pull request Feb 29, 2024

Deploy Checklist: New Expensify 2024-02-29 #37578

Closed

36 tasks

Conversation

dukenv0307 commented Feb 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 27, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Feb 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

pecanoro commented Feb 27, 2024

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Feb 29, 2024

Uh oh!

OSBotify commented Feb 29, 2024

Uh oh!

OSBotify commented Feb 29, 2024

Uh oh!

OSBotify commented Mar 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dukenv0307 commented Feb 27, 2024 •

edited

Loading

hoangzinh commented Feb 27, 2024 •

edited

Loading