Add delete btn to workspace profile page · Pull Request #37528 · Expensify/App

ghost · 2024-02-29T16:37:11Z

Details

Fixed Issues

$ #35855
PROPOSAL: #35855 (comment)

Tests

Admin

Navigate to workspace profile page and create workspace.
Open workspace and click on Profile and then click on delete button.
Verify the workspace is deleted.

Non-Admin

Open workspace created by another user. The invited user is non-admin.
Verify no delete button is visible.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.webm

Android: mWeb Chrome

android.web.webm

iOS: Native

ios.native.webm

iOS: mWeb Safari

ios.web.webm

MacOS: Chrome / Safari

web.webm

MacOS: Desktop

desktop.webm

melvin-bot · 2024-02-29T16:37:16Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2024-02-29T16:37:26Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

ghost · 2024-02-29T17:03:22Z

I have read the CLA Document and I hereby sign the CLA

src/pages/workspace/WorkspaceProfilePage.tsx

ghost · 2024-03-01T13:37:17Z

@aimane-chnaif I have added screenshots, PR ready for review.

src/pages/workspace/WorkspaceProfilePage.tsx

aimane-chnaif · 2024-03-03T15:04:47Z

BUG: wrong status bar background after deleting workspace on mobile safari
(Not sure if this can be out of scope)

msafari.mov

ghost · 2024-03-05T07:42:49Z

@aimane-chnaif The status bar issue occurs in the Modal component. I have added checked for isSmallScreenWidth to correct the background on mobile safari.

aimane-chnaif · 2024-03-06T22:27:01Z

src/components/Modal/index.tsx

            setPreviousStatusBarColor(statusBarColor);
            // If it is a full screen modal then match it with appBG, otherwise we use the backdrop color
-            setStatusBarColor(isFullScreenModal ? theme.appBG : StyleUtils.getThemeBackgroundColor(statusBarColor));
+            setStatusBarColor(isFullScreenModal || isSmallScreenWidth ? theme.appBG : StyleUtils.getThemeBackgroundColor(statusBarColor));


This is not safe fix. Please revert it. I suggest this out of scope as happening in other places on production. But let's create separate GH for tracking and fix.
Bug to report is here: #37528 (comment)
cc: @mountiny

Screen.Recording.2024-03-06.at.11.24.12.PM.mov

revert all changes in this component

@aimane-chnaif I have reverted the Modal component.

aimane-chnaif · 2024-03-07T09:37:37Z

src/components/Modal/index.tsx

    const theme = useTheme();
    const StyleUtils = useStyleUtils();
    const [previousStatusBarColor, setPreviousStatusBarColor] = useState<string>();
-


aimane-chnaif · 2024-03-07T09:47:53Z

After changes, make sure to check diff in https://github.com/Expensify/App/pull/37528/files.
I will review after all fixed

mountiny · 2024-03-07T14:02:04Z

@dannymcclain you got assigned to the linked issue, could you please check this implementation is fine? I can see that the buttons do not have icons as in the screens in the linked issue. @aimane-chnaif @jsdev2547 could you add the share buttons and bin icons to the Share and Delete buttons in this PR please?

aimane-chnaif · 2024-03-07T14:04:28Z

could you add the share buttons and bin icons to the Share and Delete buttons in this PR please?

It's already separate issue - #37089 and not priority

mountiny · 2024-03-07T14:07:27Z

thanks, noted there

dannymcclain · 2024-03-07T14:13:26Z

Thanks for tagging me @mountiny! It looks great and is working exactly how I would expect it to. 👍

github-actions · 2024-03-07T14:23:40Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/37528/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/37528/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/37528/NewExpensify.dmg	https://37528.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mountiny

seems good, waiting for the reviewer checklist

aimane-chnaif · 2024-03-07T14:44:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

mountiny · 2024-03-07T14:49:04Z

Thanks!

mountiny · 2024-03-07T14:49:54Z

@jsdev2547 the testing/ QA steps are missing in the PR body, that needs to be included in each PR unless there is nothing to test

OSBotify · 2024-03-07T14:54:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

ghost · 2024-03-07T14:58:55Z

@mountiny I have added the testing steps.

mountiny · 2024-03-07T15:05:03Z

@jsdev2547 not sure if I understand the steps, how can you invite user to a workpace that was deleted?

ghost · 2024-03-07T15:09:10Z

@mountiny I meant the delete button should not display to the user who is invited to the workspace.

mountiny · 2024-03-07T15:12:45Z

@jsdev2547 can you swap the steps then? and highlight the invited user is non-admin

ghost · 2024-03-07T15:20:14Z

@mountiny I have highlighted the invited user is non-admin.

OSBotify · 2024-03-08T00:03:44Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.49-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-12T18:38:18Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.50-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

add delete btn

4c70451

melvin-bot bot requested review from aimane-chnaif and removed request for a team February 29, 2024 16:37

aimane-chnaif reviewed Feb 29, 2024

View reviewed changes

src/pages/workspace/WorkspaceProfilePage.tsx Show resolved Hide resolved

src/pages/workspace/WorkspaceProfilePage.tsx Show resolved Hide resolved

aimane-chnaif reviewed Feb 29, 2024

View reviewed changes

src/pages/workspace/WorkspaceProfilePage.tsx Show resolved Hide resolved

src/pages/workspace/WorkspaceProfilePage.tsx Show resolved Hide resolved

resolve margin

39b4911

aimane-chnaif suggested changes Mar 3, 2024

View reviewed changes

src/pages/workspace/WorkspaceProfilePage.tsx Show resolved Hide resolved

src/pages/workspace/WorkspaceProfilePage.tsx Outdated Show resolved Hide resolved

handle statusbar background

0f2c005

aimane-chnaif reviewed Mar 6, 2024

View reviewed changes

buffercheck00@protonmail.com added 2 commits March 7, 2024 09:51

revert isSmallScreenWidth

bc86bd4

revert

bb6e3a6

aimane-chnaif reviewed Mar 7, 2024

View reviewed changes

revert

96ab665

revert

cbc9224

aimane-chnaif approved these changes Mar 7, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny March 7, 2024 12:10

mountiny added the Ready To Build label Mar 7, 2024

mountiny mentioned this pull request Mar 7, 2024

[HOLD for payment 2024-03-22] [$250] [Simplified Collect] [Profile] Add QRCode icon to share button in Workspace profile page and Trash can icon to workspace delete button #37089

Closed

Expensify deleted a comment from github-actions bot Mar 7, 2024

mountiny approved these changes Mar 7, 2024

View reviewed changes

mountiny merged commit 634b543 into Expensify:main Mar 7, 2024

github-actions bot mentioned this pull request Mar 7, 2024

Deploy Checklist: New Expensify 2024-03-07 #37938

Closed

43 tasks

Conversation

ghost commented Feb 29, 2024 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 29, 2024

Uh oh!

github-actions bot commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Feb 29, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Mar 1, 2024

Uh oh!

Uh oh!

Uh oh!

aimane-chnaif commented Mar 3, 2024

Uh oh!

ghost commented Mar 5, 2024

Uh oh!

aimane-chnaif Mar 6, 2024

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Mar 7, 2024

Choose a reason for hiding this comment

Uh oh!

ghost Mar 7, 2024

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Mar 7, 2024

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Mar 7, 2024

Uh oh!

mountiny commented Mar 7, 2024

Uh oh!

aimane-chnaif commented Mar 7, 2024

Uh oh!

mountiny commented Mar 7, 2024

Uh oh!

dannymcclain commented Mar 7, 2024

Uh oh!

github-actions bot commented Mar 7, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Mar 7, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny commented Mar 7, 2024

Uh oh!

mountiny commented Mar 7, 2024

Uh oh!

OSBotify commented Mar 7, 2024

Uh oh!

ghost commented Mar 7, 2024

Uh oh!

mountiny commented Mar 7, 2024

Uh oh!

ghost commented Mar 7, 2024

Uh oh!

mountiny commented Mar 7, 2024

Uh oh!

ghost commented Mar 7, 2024

Uh oh!

OSBotify commented Mar 8, 2024

Uh oh!

OSBotify commented Mar 12, 2024

ghost commented Feb 29, 2024 •

edited by ghost

Loading

github-actions bot commented Feb 29, 2024 •

edited

Loading