fix: gesture direction for left modal stack by kirillzyusko · Pull Request #37601 · Expensify/App

kirillzyusko · 2024-03-01T13:25:09Z

Details

Added right-to-left gesture for Search/Workspace screens.

Fixed Issues

$ #37354
PROPOSAL: N/A

Tests

Open app
Open search page
Verify that animation for this screen is left to right
Try to close it via gesture (on iOS) - the gesture to dismiss should be right to left
Open workspace page and check steps 3-4
Open app on Android
Open search page
Verify that animation for this screen is left to right
Try to close screen via gesture (it shouldn't be possible)
Open workspace page and check steps 8-9

Verify that no errors appear in the JS console

Offline tests

Not needed

QA Steps

Open app
Open search page
Verify that animation for this screen is left to right
Try to close it via gesture (on iOS) - the gesture to dismiss should be right to left
Open workspace page and check steps 3-4
Open app on Android
Open search page
Verify that animation for this screen is left to right
Try to close screen via gesture (it shouldn't be possible)
Open workspace page and check steps 8-9

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

telegram-cloud-document-2-5406699501597507749.mp4

Android: mWeb Chrome

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-01.at.13.43.19.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-03-01T13:25:14Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

kirillzyusko · 2024-03-05T11:57:54Z

@youssef-lr may I kindly ask you to review this PR? 👀

youssef-lr · 2024-03-05T12:03:07Z

On it.

youssef-lr · 2024-03-05T12:08:24Z

@kirillzyusko in Android emulator, how do I simulate a swipe? clicking and holding doesn't seem to work for me

kirillzyusko · 2024-03-05T12:14:02Z

in Android emulator, how do I simulate a swipe? clicking and holding doesn't seem to work for me

@youssef-lr By default gesture-based navigation is iOS specific feature. If we want to support it in Android then we need to open a new discussion (because from one side - it gives a cool feature, but from the other side - it will not be supported if we migrate to native stack navigators) 👀

youssef-lr · 2024-03-05T12:15:15Z

Oh, so in the android native recording you're just pressing back and not actually swiping?

youssef-lr · 2024-03-05T12:22:32Z

src/libs/Navigation/AppNavigator/getRootNavigatorScreenOptions.ts

        },
        leftModalNavigator: {
            ...commonScreenOptions,
-            cardStyleInterpolator: (props) => modalCardStyleInterpolator(isSmallScreenWidth, false, props, SLIDE_LEFT_OUTPUT_RANGE_MULTIPLIER),


I'm curious what this does SLIDE_LEFT_OUTPUT_RANGE_MULTIPLIER, @kirillzyusko? And why did we remove it after changing the direction?

@youssef-lr basically it was reverting the animation. And when we multiply extrapolated values (let's say we move screen from 0 to 336) by -1 - we change a direction of animation.

But in react-navigation this -1 multiplier is already handled if you specify gestureDirection.

So if I specify gestureDirection as horizontal-inverted - it'll automatically drive the animation from left to right, but since we multiplied it before by -1 we kind of getting double inversion which results in right-to-left (default) animation.

That's why I removed this - I delegated a control fully to react-navigation.

Ahh makes sense, thanks for clarifying!

youssef-lr · 2024-03-05T13:02:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

ios.native.1.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

kirillzyusko · 2024-03-05T13:04:36Z

Oh, so in the android native recording you're just pressing back and not actually swiping?

@youssef-lr Ah, you about my recording? Yes, I kind of dismiss it with swipe gesture, but it's a newly introduced feature (available in Android 13 and Android 14 by default) and backward compatible with previous "hardware back button" functionality.

So this swipe is handled by OS (not by app) and when such swipe occurs it's simply simulate a press on hardware/emulated software back button (typically was prior to Android 10 in the bottom of the screen).

youssef-lr

LGTM, thanks for working on this! Left one comment mainly because I'm curious :D

youssef-lr · 2024-03-05T13:05:59Z

@kirillzyusko probably out of scope, any reason you can think of why the animation of the search page and workspace switched are not 60fps compared to the profile page? See my recording in the checklist

kirillzyusko · 2024-03-05T13:13:29Z

probably out of scope, any reason you can think of why the animation of the search page and workspace switched are not 60fps compared to the profile page? See my recording in the checklist

This is a very good question 😅 I don't have the answer at the moment (need to perform a profiling to understand it better), but I'm currently working on replacing stack navigator by native-stack and I think it'll make transitions performant everywhere 💪

youssef-lr · 2024-03-05T13:14:19Z

and I think it'll make transitions performant everywhere 💪

Awesome, can't wait!

OSBotify · 2024-03-05T13:19:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-06T22:05:48Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.48-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-07T23:51:48Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.48-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: gesture direction for left modal stack

10ed674

kirillzyusko requested a review from a team as a code owner March 1, 2024 13:25

melvin-bot bot requested review from sobitneupane and removed request for a team March 1, 2024 13:25

kirillzyusko mentioned this pull request Mar 1, 2024

[HOLD for payment 2024-03-14] Gesture to hide the search page should be right to left #37354

Closed

6 tasks

youssef-lr reviewed Mar 5, 2024

View reviewed changes

youssef-lr removed the request for review from sobitneupane March 5, 2024 13:02

youssef-lr approved these changes Mar 5, 2024

View reviewed changes

youssef-lr merged commit 5787691 into Expensify:main Mar 5, 2024

github-actions bot mentioned this pull request Mar 6, 2024

Deploy Checklist: New Expensify 2024-03-06 #37845

Closed

63 tasks

Conversation

kirillzyusko commented Mar 1, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 1, 2024

Uh oh!

kirillzyusko commented Mar 5, 2024

Uh oh!

youssef-lr commented Mar 5, 2024

Uh oh!

youssef-lr commented Mar 5, 2024

Uh oh!

kirillzyusko commented Mar 5, 2024

Uh oh!

youssef-lr commented Mar 5, 2024

Uh oh!

youssef-lr Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kirillzyusko Mar 5, 2024

Choose a reason for hiding this comment

Uh oh!

youssef-lr Mar 5, 2024

Choose a reason for hiding this comment

Uh oh!

youssef-lr commented Mar 5, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

kirillzyusko commented Mar 5, 2024

Uh oh!

youssef-lr left a comment

Choose a reason for hiding this comment

Uh oh!

youssef-lr commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kirillzyusko commented Mar 5, 2024

Uh oh!

youssef-lr commented Mar 5, 2024

Uh oh!

OSBotify commented Mar 5, 2024

Uh oh!

OSBotify commented Mar 6, 2024

Uh oh!

OSBotify commented Mar 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

youssef-lr Mar 5, 2024 •

edited

Loading

youssef-lr commented Mar 5, 2024 •

edited

Loading