Create WorkspaceTagsPage by waterim · Pull Request #37621 · Expensify/App

waterim · 2024-03-01T17:54:15Z

Details

Create WorkspaceTagsPage

Fixed Issues

$ #37309

Tests

Go to Workspace settings
Go to "Tags"
Look that tags are there and everything works fine

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

None

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

luacmartins

Nice start!

src/languages/es.ts

src/pages/workspace/tags/WorkspaceTagsPage.tsx

melvin-bot · 2024-03-04T12:53:46Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins

LGTM. One issue that I found is that the tags icon has the selected green color, even when it's not hovered/selected

waterim · 2024-03-04T15:57:38Z

@luacmartins thank you! Will fix in 1 hour

abdulrahuman5196 · 2024-03-04T16:09:14Z

@waterim Just to confirm. Is it to only show the page with tags and select tags? But can't enable or disable on this PR ?

abdulrahuman5196 · 2024-03-04T16:12:08Z

LGTM. One issue that I found is that the tags icon has the selected green color, even when it's not hovered/selected

Do let me know once this is fixed. I can check on platforms.

abdulrahuman5196 · 2024-03-04T16:12:34Z

And why are we only having web only screenshots? Can we add platform specific screenshots?

luacmartins · 2024-03-04T16:32:34Z

@waterim Just to confirm. Is it to only show the page with tags and select tags? But can't enable or disable on this PR ?

yes, this PR only adds the main list view page. There's no Settings available yet

abdulrahuman5196 · 2024-03-04T17:30:50Z

luacmartins thank you! Will fix in 1 hour

@waterim Any update on this?

waterim · 2024-03-04T17:37:40Z

@abdulrahuman5196 yes, pushed new fixed Icon

luacmartins · 2024-03-04T17:40:06Z

@abdulrahuman5196 are you still available to continue your review?

abdulrahuman5196 · 2024-03-04T18:10:44Z

yes

abdulrahuman5196 · 2024-03-04T18:11:16Z

Starting in couple of minutes. Closing out another PR.

luacmartins

LGTM!

luacmartins · 2024-03-04T18:39:10Z

@Expensify/design

shawnborton · 2024-03-04T18:45:46Z

assets/images/tag.svg

Where did we get the asset for this? I think all of our icons we put into the system are 20x20 in pure black (#000000).

Updated version for ya! tag.svg.zip

Downloaded from figma😅

shawnborton · 2024-03-04T18:46:16Z

assets/images/simple-illustrations/simple-illustration__tag.svg

Just confirming that the size of this is 68x68? Where did this asset come from? Try this one maybe:

simple-illustration__tag.svg.zip

Downloaded from the figma and adjusted as all illustrations without any additional sizing

Got it, in the future you can just get the assets from the Design team so we can make sure you're pulling the right stuff.

@shawnborton okay, thank you!

abdulrahuman5196 · 2024-03-04T19:08:16Z

Given that we will have a different PR for functionality, kindly watch out for the below bug on refresh as well.

Screen.Recording.2024-03-05.at.12.15.41.AM.mov

abdulrahuman5196 · 2024-03-04T19:08:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

N/A

Android: mWeb Chrome

N/A

iOS: Native

N/A

iOS: mWeb Safari

N/A

MacOS: Chrome / Safari

MacOS: Desktop

N/A

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @luacmartins

🎀 👀 🎀
C+ Reviewed

luacmartins · 2024-03-04T19:38:26Z

@waterim can you update the assets with the new ones provided by @shawnborton? I think we should be good to merge after that.

waterim · 2024-03-04T20:40:19Z

@luacmartins Just came back home, updated images :)

melvin-bot · 2024-03-04T20:55:46Z

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2024-03-04T21:01:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

luacmartins · 2024-03-04T21:21:26Z

Tests were passing

OSBotify · 2024-03-06T22:05:57Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.48-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kosmydel · 2024-03-07T08:56:32Z

src/pages/workspace/tags/WorkspaceTagsPage.tsx

+                <ScreenWrapper
+                    includeSafeAreaPaddingBottom={false}
+                    style={[styles.defaultModalContainer]}
+                    testID={WorkspaceTagsPage.displayName}
+                    shouldShowOfflineIndicatorInWideScreen
+                >
+                    <HeaderWithBackButton
+                        icon={Illustrations.Tag}
+                        title={translate('workspace.common.tags')}
+                        shouldShowBackButton={isSmallScreenWidth}
+                    />


Hey, I have a question related to this change. Every workspace page uses the WorkspacePageWithSections wrapper except for this one. Is this intentional?

I don't think the new pages do, e.g. WorkspaceMembersPage, WorkspaceCategoriesPage

The WorkspaceMembersPage copies the logic from the WorkspacePageWithSections.

I'm using this wrapper to fix multiple not found views, and part of the PR is making the above page use the wrapper.

So what is the aim of the WorkspacePageWithSections wrapper? When should it be used?

Hmm interesting case, maybe we should be using WorkspacePageWithSections here too and on all other pages. I think we can update these, but maybe in a separate PR.

We probably have to think it over as currently, we have three different wrappers for workspaces, and we don't have clear guidelines on when to use which one.

Yea, that makes sense. I'll create an issue for it.

Created issue - #37898

Those wrappers also break the not-found views.

Going to e.g. https://staging.new.expensify.com/workspace/dssaddssdaads/categories` we see duplicated not found (that's what is the scope of the other issue) and after pressing the back button we see another ones...

kosmydel · 2024-03-07T09:01:15Z

The Tags screen should be added to the TAB_TO_CENTRAL_PANE_MAPPING:

const TAB_TO_CENTRAL_PANE_MAPPING: Record<BottomTabName, CentralPaneName[]> = {
    [SCREENS.WORKSPACE.INITIAL]: [
       // ...
        SCREENS.WORKSPACE.TAGS,
    ],
};

Otherwise, the deep linking doesn't work correctly.

OSBotify · 2024-03-07T23:51:57Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.48-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ntdiary · 2024-04-08T09:04:15Z

src/pages/workspace/tags/WorkspaceTagsPage.tsx

+    const {translate} = useLocalize();
+    const [selectedTags, setSelectedTags] = useState<Record<string, boolean>>({});
+    const policyTagLists = useMemo(() => PolicyUtils.getTagLists(policyTags), [policyTags]);
+    const tagList = useMemo<PolicyForList[]>(


Coming from #38663.
We add a isDisabled flag to take care of the behavior when deleting a tag offline. :)

waterim added 2 commits March 1, 2024 18:51

initial workspace tags page

c63961d

Merge remote-tracking branch 'upstream/main' into feat-37309

b7d2ae8

luacmartins self-requested a review March 1, 2024 18:14

luacmartins reviewed Mar 1, 2024

View reviewed changes

luacmartins requested changes Mar 1, 2024

View reviewed changes

src/languages/es.ts Outdated Show resolved Hide resolved

src/languages/es.ts Outdated Show resolved Hide resolved

rezkiy37 reviewed Mar 4, 2024

View reviewed changes

src/pages/workspace/tags/WorkspaceTagsPage.tsx Show resolved Hide resolved

rezkiy37 reviewed Mar 4, 2024

View reviewed changes

src/pages/workspace/tags/WorkspaceTagsPage.tsx Show resolved Hide resolved

waterim added 2 commits March 4, 2024 13:52

updated translations

8b52882

fix lint

8454e0f

waterim marked this pull request as ready for review March 4, 2024 12:53

waterim requested a review from a team as a code owner March 4, 2024 12:53

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team March 4, 2024 12:53

fix lint

c91e707

luacmartins requested changes Mar 4, 2024

View reviewed changes

fixed icon

7350a2d

luacmartins previously approved these changes Mar 4, 2024

View reviewed changes

luacmartins added the Design label Mar 4, 2024

shawnborton reviewed Mar 4, 2024

View reviewed changes

abdulrahuman5196 approved these changes Mar 4, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins March 4, 2024 19:10

images update

40ab003

waterim dismissed luacmartins’s stale review via 40ab003 March 4, 2024 20:39

luacmartins approved these changes Mar 4, 2024

View reviewed changes

luacmartins merged commit 4f21d80 into Expensify:main Mar 4, 2024

melvin-bot bot added the Emergency label Mar 4, 2024

luacmartins removed the Emergency label Mar 4, 2024

github-actions bot mentioned this pull request Mar 6, 2024

Deploy Checklist: New Expensify 2024-03-06 #37845

Closed

63 tasks

Tony-MK mentioned this pull request Mar 6, 2024

[HOLD for payment 2024-04-30][$500] Tag - Tag in Parent: Child format is displayed as Parent/: Child in Tag list #37847

Closed

6 tasks

kosmydel reviewed Mar 7, 2024

View reviewed changes

MonilBhavsar mentioned this pull request Mar 7, 2024

[HOLD for payment 2024-03-20] Tag - Newly added tags aren't displayed under the "Tags" section in workspace settings #37873

Closed

6 tasks

luacmartins mentioned this pull request Mar 7, 2024

[HOLD for payment 2024-05-08] [Simplified Collect][CLEAN UP][LOW] Standardize on Workspace wrapper #37898

Closed

melvin-bot bot mentioned this pull request Mar 7, 2024

[HOLD for payment 2024-03-14] [$500] [Simplified Collect][Tags] Create WorkspaceTagsPage #37309

Closed

ntdiary reviewed Apr 8, 2024

View reviewed changes

ntdiary mentioned this pull request Apr 8, 2024

[HOLD for payment 2024-04-05] [$250] [Simplified Collect][Tags] - Deleted tag can be clicked on when deleted offline #38663

Closed

6 tasks

narefyev91 mentioned this pull request May 1, 2024

Add missing multi tag view #41351

Merged

50 tasks

thesahindia mentioned this pull request Jun 4, 2024

[HOLD for payment 2024-06-06] [$250] Tags - After deleting a Tag, the select button is not showing the correct amount #42271

Closed

6 tasks

Conversation

waterim commented Mar 1, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

melvin-bot bot commented Mar 4, 2024

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

waterim commented Mar 4, 2024

Uh oh!

abdulrahuman5196 commented Mar 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abdulrahuman5196 commented Mar 4, 2024

Uh oh!

abdulrahuman5196 commented Mar 4, 2024

Uh oh!

luacmartins commented Mar 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abdulrahuman5196 commented Mar 4, 2024

Uh oh!

waterim commented Mar 4, 2024

Uh oh!

luacmartins commented Mar 4, 2024

Uh oh!

abdulrahuman5196 commented Mar 4, 2024

Uh oh!

abdulrahuman5196 commented Mar 4, 2024

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Mar 4, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 commented Mar 4, 2024

Uh oh!

abdulrahuman5196 commented Mar 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Mar 4, 2024

Uh oh!

waterim commented Mar 4, 2024

Uh oh!

melvin-bot bot commented Mar 4, 2024

abdulrahuman5196 commented Mar 4, 2024 •

edited

Loading

luacmartins commented Mar 4, 2024 •

edited

Loading

abdulrahuman5196 commented Mar 4, 2024 •

edited

Loading

ntdiary Apr 8, 2024 •

edited

Loading