Update PurposeForUsingExpensifyPage.tsx#37652
Conversation
minor copy changes
|
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
NikkiWines
left a comment
There was a problem hiding this comment.
tested and works well!
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
NikkiWines
left a comment
There was a problem hiding this comment.
Sorry @jamesdeanexpensify 🙈 I led you astray by telling you to escape ' by using \'. It looks like stylistically we prefer using " in cases where the copy has apostrophes.
Co-authored-by: Nikki Wines <nikkiwines@expensify.com>
Co-authored-by: Nikki Wines <nikkiwines@expensify.com>
Co-authored-by: Nikki Wines <nikkiwines@expensify.com>
Co-authored-by: Nikki Wines <nikkiwines@expensify.com>
Co-authored-by: Nikki Wines <nikkiwines@expensify.com>
Co-authored-by: Nikki Wines <nikkiwines@expensify.com>
NikkiWines
left a comment
There was a problem hiding this comment.
Nice, thanks for merging main @francoisl!
Tests are passing now and everything here looks good:
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.4.48-0 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.48-0 🚀
|




minor copy changes
Details
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
Sign up for a new account at new.expensify.com
Once you get into your account, the first thing you should see is a right-hand modal
Click "Track business spend for taxes"
You should get a message from Concierge, make sure it's not indented and falls in line with the first message from Concierge
Confirm the copy matches the following:

Sign up for a new account at new.expensify.com
Once you get into your account, the first thing you should see is a right-hand modal
Click "Get paid back by my employer"
You should get a message from Concierge, make sure it's not indented and falls in line with the first message from Concierge
Confirm the copy matches the following:

Sign up for a new account at new.expensify.com
Once you get into your account, the first thing you should see is a right-hand modal
Click "Manage my team's expenses"
Selectr
Noon the follow up right-hand modalYou should get a message from Concierge, make sure it's not indented and falls in line with the first message from Concierge
Confirm the copy matches the following:

Sign up for a new account at new.expensify.com
Once you get into your account, the first thing you should see is a right-hand modal
Click "Chat and split bills with friends"
You should get a message from Concierge, make sure it's not indented and falls in line with the first message from Concierge
Confirm the copy matches the following:

PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop