Make members page read only by luacmartins · Pull Request #37700 · Expensify/App

luacmartins · 2024-03-04T20:45:43Z

Details

Makes the members page available as read-only for workspace members

cc @burczu

Fixed Issues

$ #35714

Tests

Pre-requisite: a member account belonging to a Collect workspace with Workspace chats enabled

Login as a Collect workspace member
Navigate to Settings > Workspace
Verify that you can see the Members page
Verify that tapping on any user opens the RHP with the user's profile

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

luacmartins · 2024-03-04T23:26:09Z

Ok, I have the videos for each platform but the plane wifi is not cooperating so I'll update them later. Other than that I think this PR is good to go.

luacmartins · 2024-03-04T23:26:20Z

@Expensify/design

melvin-bot · 2024-03-04T23:26:34Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2024-03-05T02:26:11Z

Ok, uploaded all videos

shawnborton · 2024-03-05T02:54:26Z

Looks solid!

Only minor comment is that I would move the "Members" label to be left-aligned with the left edge of the avatars. I could have sworn we already made that change somewhere, so just calling it out again to be sure.

luacmartins · 2024-03-05T03:05:59Z

Ah cool, the design doc still had it aligned with the display name, but I can change that no problem!

shawnborton · 2024-03-05T03:11:52Z

Awesome, thanks!

Yeah, I think we had a change of heart in a thread regarding the alignment - here it is for more context.

burczu

One comment added

src/components/SelectionList/BaseSelectionList.tsx

luacmartins · 2024-03-05T15:43:32Z

Cool, updated the PR aligning the Members header with the left of edge of the avatars. Also updated all screenshots. Ready for review!

allroundexperts · 2024-03-05T16:34:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-05.at.9.58.57.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-03-05.at.9.57.55.PM.mov

iOS: Native

Screen.Recording.2024-03-05.at.9.56.24.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-03-05.at.9.55.01.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-05.at.9.46.35.PM.mov

Screen.Recording.2024-03-05.at.9.48.15.PM.mov

MacOS: Desktop

Screen.Recording.2024-03-05.at.9.51.03.PM.mov

allroundexperts · 2024-03-05T16:42:20Z

@luacmartins I'm seeing Members menu option twice.

allroundexperts · 2024-03-05T17:27:21Z

@luacmartins Not sure if its reported before, but we're showing even the workspace member as an admin if we're logged in as that member.

As workspace owner:

As workspace member:

allroundexperts · 2024-03-05T17:31:03Z

src/pages/workspace/WorkspaceInitialPage.tsx

+        {
+            translationKey: 'workspace.common.members',
+            icon: Expensicons.Users,
+            action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.WORKSPACE_MEMBERS.getRoute(policyID)))),
+            brickRoadIndicator: hasMembersError ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined,
+            routeName: SCREENS.WORKSPACE.MEMBERS,
+        },


Do we want to show this to the members of free workspaces as well?

Yes, AFAIK we'll have a single members page for both free/paid workspaces.

luacmartins · 2024-03-05T17:33:51Z

@allroundexperts pushed a fix for both issues

allroundexperts

Looks good!

melvin-bot · 2024-03-05T17:42:32Z

@chiragsalian Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chiragsalian

LGTM

OSBotify · 2024-03-06T01:42:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-06T22:06:21Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.4.48-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-07T23:52:21Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.48-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

luacmartins added 4 commits March 4, 2024 13:30

make members page visible to users

71e7650

disable invite button

b5e7e9c

navigate to profile page

7a7f523

dont disable profile selection for members

beaf686

luacmartins self-assigned this Mar 4, 2024

luacmartins changed the title ~~Cmartins make members page read only~~ Make members page read only Mar 4, 2024

luacmartins added 7 commits March 4, 2024 15:16

add styles

799a4c4

fix style

fa6540a

fix lint

61db571

only render if cant select all

0d340d8

fix conditionals

d121896

fix view on ios

95b8b3a

revert podfile changes

fbbc00c

luacmartins added the Design label Mar 4, 2024

luacmartins marked this pull request as ready for review March 4, 2024 23:26

luacmartins requested a review from a team as a code owner March 4, 2024 23:26

melvin-bot bot requested review from Ollyws and removed request for a team March 4, 2024 23:26

burczu reviewed Mar 5, 2024

View reviewed changes

src/components/SelectionList/BaseSelectionList.tsx Outdated Show resolved Hide resolved

luacmartins added 3 commits March 5, 2024 10:23

fix left margin

6fc1e0e

move styling to members page

f367670

fix lint

3793df3

luacmartins requested a review from burczu March 5, 2024 15:41

luacmartins requested review from allroundexperts and burczu and removed request for Ollyws and burczu March 5, 2024 16:33

rm duplicate list

21f1180

allroundexperts reviewed Mar 5, 2024

View reviewed changes

fix admin badge

bf9cc2f

allroundexperts approved these changes Mar 5, 2024

View reviewed changes

melvin-bot bot removed the request for review from burczu March 5, 2024 17:42

melvin-bot bot requested a review from chiragsalian March 5, 2024 17:42

chiragsalian approved these changes Mar 6, 2024

View reviewed changes

chiragsalian merged commit 042bdcc into main Mar 6, 2024

chiragsalian deleted the cmartins-makeMembersPageReadOnly branch March 6, 2024 01:36

github-actions bot mentioned this pull request Mar 6, 2024

Deploy Checklist: New Expensify 2024-03-06 #37845

Closed

63 tasks

melvin-bot bot mentioned this pull request Mar 7, 2024

[HOLD for payment 2024-03-14] [$500] [Simplified Collect][Members] WorkspaceMembersPage: Making the page read-only for non-admin users #35714

Closed

Conversation

luacmartins commented Mar 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

luacmartins commented Mar 4, 2024

Uh oh!

luacmartins commented Mar 4, 2024

Uh oh!

melvin-bot bot commented Mar 4, 2024

Uh oh!

luacmartins commented Mar 5, 2024

Uh oh!

shawnborton commented Mar 5, 2024

Uh oh!

luacmartins commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Mar 5, 2024

Uh oh!

burczu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

luacmartins commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allroundexperts commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts commented Mar 5, 2024

Uh oh!

allroundexperts commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allroundexperts Mar 5, 2024

Choose a reason for hiding this comment

Uh oh!

luacmartins Mar 5, 2024

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Mar 5, 2024

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 5, 2024

Uh oh!

chiragsalian left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Mar 6, 2024

Uh oh!

OSBotify commented Mar 6, 2024

Uh oh!

OSBotify commented Mar 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

luacmartins commented Mar 4, 2024 •

edited

Loading

luacmartins commented Mar 5, 2024 •

edited

Loading

luacmartins commented Mar 5, 2024 •

edited

Loading

allroundexperts commented Mar 5, 2024 •

edited

Loading

allroundexperts commented Mar 5, 2024 •

edited

Loading