Handle emoji tooltip and fix regression by dukenv0307 · Pull Request #37814 · Expensify/App

dukenv0307 · 2024-03-06T08:42:50Z

Details

Display a tooltip when hovering over emoji in report action

Fixed Issues

$ #34307
PROPOSAL: #34307 (comment)

Tests

Send a message containing only emoji
Verify that the font size of emoji is big
Send a message containing only emoji and text, not contain any markdown
Verify that the font size of emoji is smaller
Send a message with emoji and any markdown
For the three cases above, hover over the emoji and verify that the emoji tooltip appears with the correct emoji and emoji name
Change the language to Spanish and hover over the emoji again
Verify that the emoji name is updated correctly with Spanish language

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Send a message containing only emoji
Verify that the font size of emoji is big
Send a message containing only emoji and text, not contain any markdown
Verify that the font size of emoji is smaller
Send a message with emoji and any markdown
For the three cases above, hover over the emoji and verify that the emoji tooltip appears with the correct emoji and emoji name
Change the language to Spanish and hover over the emoji again
Verify that the emoji name is updated correctly with Spanish language

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-02-05.at.23.41.52.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-02-05.at.23.40.44.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-05.at.23.38.47.mov

MacOS: Desktop

Screen.Recording.2024-02-05.at.23.46.52.mov

fedirjh · 2024-03-06T12:10:04Z

src/pages/home/report/comment/TextCommentFragment.tsx

-        if (styleAsMuted) {
-            htmlWithTag = `<muted-text>${htmlWithTag}<muted-text>`;
-        }


Let's keep this block.

Updated this. I'm updating to fix the case emoji inside codeblock, will open the PR after I fix this case.

melvin-bot · 2024-03-13T09:28:16Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

BartoszGrajdek · 2024-03-15T13:20:50Z

@fedirjh kind bump 😄 - until this is merged we are blocked on one of our PRs in live-markdown

fedirjh · 2024-03-15T14:21:13Z

package-lock.json

Why this change is needed?

This is my mistake. Reverted this.

fedirjh · 2024-03-15T14:22:51Z

src/components/InlineCodeBlock/removeEmojiTag.ts

+
+// Create a temporary solution to display when there are emojis in the inline code block
+// We can remove this after https://github.com/Expensify/App/issues/14676 is fixed
+export default function removeEmojiTag(defaultRendererProps: TDefaultRendererProps<TTextOrTPhrasing>): string {


How does this remove the emoji tag?

@fedirjh If data field of tnode is undefined, it means we have emoji tag inside inline codeblock and the text is divided into children data. So we can get the current text by merging the children data, this is correct because other tags will not appear inside inline codeblock except emoji tag.

I think we can rename this function to getCurrentData or getCurrentText

Yes, it makes sense to rename it.

I updated the name of function.

fedirjh · 2024-03-15T15:18:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

CleanShot.2024-03-15.at.17.36.28.mp4

Android: mWeb Chrome

iOS: Native

Simulator.Screen.Recording.-.iPhone.Xs.-.2024-03-15.at.17.18.23.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.Xs.-.2024-03-15.at.16.41.09.mp4

MacOS: Chrome / Safari

CleanShot.2024-03-15.at.16.24.10.mp4

MacOS: Desktop

CleanShot.2024-03-15.at.17.41.32.mp4

fedirjh

@dukenv0307 let's bump the expensify-common as well in this PR.

fedirjh · 2024-03-18T15:19:10Z

src/components/InlineCodeBlock/removeEmojiTag.ts

+
+// Create a temporary solution to display when there are emojis in the inline code block
+// We can remove this after https://github.com/Expensify/App/issues/14676 is fixed
+export default function removeEmojiTag(defaultRendererProps: TDefaultRendererProps<TTextOrTPhrasing>): string {


Yes, it makes sense to rename it.

dukenv0307 · 2024-03-18T15:25:37Z

@dukenv0307 let's bump the expensify-common as well in this PR.

@fedirjh Expensify/expensify-common#664, The previous PR is reverted so I created another one here.

dukenv0307 · 2024-03-18T15:32:54Z

@fedirjh As suggestion here Expensify/expensify-common#664 (comment), I update the version of expensify-common to the commit hash of the PR above for testing.

fedirjh

Looks good and tests well.

stitesExpensify · 2024-03-20T18:30:55Z

Are there negative consequences of merging the expensify-common lib and not merging this? Just wondering how close our timing needs to be

stitesExpensify · 2024-03-20T18:33:32Z

@dukenv0307 If you are around now I can merge the common PR and then you can update and I will merge immediately. Ping me on slack if you have time.

fedirjh · 2024-03-20T20:34:15Z

Are there negative consequences of merging the expensify-common lib and not merging this?

If the expensify-common lib PR gets merged and bumped in the App without this PR, then it will cause some regressions until this PR is merged.

OSBotify · 2024-03-21T17:07:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

situchan · 2024-03-21T18:03:49Z

Just to note that this PR skipped testing other changes that the version bump of expensify-common involves.
But never mind. We safely tested in other PR - #37566 (comment).
In the future, please make sure to test all changes. (you can always ask help from PR authors if they are unrelated to your change)

OSBotify · 2024-03-22T16:20:03Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.4.56-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-27T04:49:12Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.56-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

sobitneupane · 2024-10-21T08:06:18Z

It seems that the issue #49053 may have been overlooked in this PR.

Handle emoji tooltip and fix regression

d0b8b86

dukenv0307 mentioned this pull request Mar 6, 2024

[$500] MEDIUM: Mouse over emoji to get name #34307

Closed

fedirjh reviewed Mar 6, 2024

View reviewed changes

dukenv0307 added 4 commits March 8, 2024 14:29

Merge branch 'main' into fix/34307

e1d3a12

Merge branch 'main' into fix/34307

1e83a69

Merge branch 'main' into fix/34307

8b7bb83

keep the old logic

8ae4e2f

situchan mentioned this pull request Mar 12, 2024

[Situ is out until May] [HOLD for payment 2024-03-22] [HOLD for payment 2024-03-20] Chat - Emoji is not showing in chat #38169

Closed

6 tasks

yuwenmemon mentioned this pull request Mar 12, 2024

Add emoji rule Expensify/expensify-common#649

Merged

dukenv0307 added 2 commits March 13, 2024 15:55

merge main

f927dc3

fix the case emoji inside codeblock

05b73c6

dukenv0307 marked this pull request as ready for review March 13, 2024 09:28

dukenv0307 requested a review from a team as a code owner March 13, 2024 09:28

melvin-bot bot requested review from fedirjh and removed request for a team March 13, 2024 09:28

fix lint

38f03c9

fedirjh reviewed Mar 15, 2024

View reviewed changes

dukenv0307 added 3 commits March 18, 2024 10:26

Merge branch 'main' into fix/34307

5ae1ce0

merge main

877594c

fix new line

ce74d6d

fedirjh reviewed Mar 18, 2024

View reviewed changes

dukenv0307 added 3 commits March 18, 2024 22:25

Merge branch 'main' into fix/34307

b5498c6

rename function

ac27db5

hash commit expensify-common

01b4764

fedirjh approved these changes Mar 19, 2024

View reviewed changes

stitesExpensify previously approved these changes Mar 20, 2024

View reviewed changes

stitesExpensify changed the title ~~Handle emoji tooltip and fix regression~~ [HOLD https://github.com/Expensify/expensify-common/pull/664Handle emoji tooltip and fix regression Mar 21, 2024

stitesExpensify changed the title ~~[HOLD https://github.com/Expensify/expensify-common/pull/664Handle emoji tooltip and fix regression~~ [HOLD https://github.com/Expensify/expensify-common/pull/664] Handle emoji tooltip and fix regression Mar 21, 2024

stitesExpensify changed the title ~~[HOLD https://github.com/Expensify/expensify-common/pull/664] Handle emoji tooltip and fix regression~~ Handle emoji tooltip and fix regression Mar 21, 2024

dukenv0307 dismissed stitesExpensify’s stale review via 9598472 March 21, 2024 15:13

stitesExpensify previously approved these changes Mar 21, 2024

View reviewed changes

dukenv0307 dismissed stitesExpensify’s stale review via 23ec0f0 March 21, 2024 15:15

dukenv0307 force-pushed the fix/34307 branch from 9598472 to 23ec0f0 Compare March 21, 2024 15:15

Merge branch 'main' into fix/34307

95e6de7

dukenv0307 force-pushed the fix/34307 branch from 688a718 to 95e6de7 Compare March 21, 2024 15:50

stitesExpensify previously approved these changes Mar 21, 2024

View reviewed changes

bump new version

c147061

dukenv0307 dismissed stitesExpensify’s stale review via c147061 March 21, 2024 16:10

stitesExpensify previously approved these changes Mar 21, 2024

View reviewed changes

edit the version

ba37e26

dukenv0307 dismissed stitesExpensify’s stale review via ba37e26 March 21, 2024 16:18

stitesExpensify approved these changes Mar 21, 2024

View reviewed changes

stitesExpensify merged commit 106c367 into Expensify:main Mar 21, 2024

dukenv0307 deleted the fix/34307 branch March 22, 2024 03:10

ntdiary mentioned this pull request Mar 22, 2024

[HOLD for payment 2024-04-01] [$250] Android - App lags after adding code block in task description #34324

Closed

6 tasks

github-actions bot mentioned this pull request Mar 22, 2024

Deploy Checklist: New Expensify 2024-03-22 #38811

Closed

sobitneupane mentioned this pull request Oct 21, 2024

[Payment 2024-10-10] [$250] Chat - In mweb, deleting emoji+text in offline, emoji not striked but striked in Android #49053

Closed

6 tasks

Conversation

dukenv0307 commented Mar 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 13, 2024

Uh oh!

BartoszGrajdek commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fedirjh commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

fedirjh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fedirjh left a comment

Choose a reason for hiding this comment

Uh oh!

stitesExpensify commented Mar 20, 2024

Uh oh!

stitesExpensify commented Mar 20, 2024

Uh oh!

fedirjh commented Mar 20, 2024

Uh oh!

OSBotify commented Mar 21, 2024

Uh oh!

situchan commented Mar 21, 2024

Uh oh!

OSBotify commented Mar 22, 2024

Uh oh!

OSBotify commented Mar 27, 2024

Uh oh!

sobitneupane commented Oct 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dukenv0307 commented Mar 6, 2024 •

edited

Loading

BartoszGrajdek commented Mar 15, 2024 •

edited

Loading

fedirjh commented Mar 15, 2024 •

edited

Loading

dukenv0307 commented Mar 18, 2024 •

edited

Loading

dukenv0307 commented Mar 18, 2024 •

edited

Loading