[Simplified Collect][Taxes] Create WorkspaceTaxesPage by filip-solecki · Pull Request #37870 · Expensify/App

filip-solecki · 2024-03-07T08:28:35Z

Details

Fixed Issues

$ #37787
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

androd.mov

Android: mWeb Chrome

android_chrome.mov

iOS: Native

UPDATE: Added header buttons

ios.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

UPDATE: Added header buttons

Nagranie.z.ekranu.2024-03-7.o.14.00.40.mov

MacOS: Desktop

desktop.mov

assets/images/tax.svg

src/languages/es.ts

src/pages/workspace/WorkspaceInitialPage.tsx

src/pages/workspace/taxes/WorkspaceTaxesPage.tsx

melvin-bot · 2024-03-08T09:59:14Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

filip-solecki · 2024-03-11T08:09:10Z

@DylanDylann kind bump

DylanDylann · 2024-03-11T08:29:35Z

Reviewing today. I am reading the document about this feature

filip-solecki · 2024-03-11T08:32:57Z

Awesome, thanks!

filip-solecki · 2024-03-11T14:06:17Z

@DylanDylann just FYI I think you have to wait until tomorrow. I need to work on enabling Taxes feature (while enabling for the first time default taxes are not creating)

luacmartins

Looking good, just a comment about reusing isDisabled and a few NAB

src/components/SelectionList/BaseListItem.tsx

src/pages/workspace/taxes/WorkspaceTaxesPage.tsx

src/languages/es.ts

src/pages/workspace/taxes/WorkspaceTaxesPage.tsx

filip-solecki · 2024-03-13T09:23:20Z

@DylanDylann it this the first time of enabling Taxes? Because there is an issue for BE to create two default tax rates (previously it was done by FE but it is against 1:1:1 rule)

DylanDylann · 2024-03-13T09:46:00Z

it this the first time of enabling Taxes?

@filip-solecki Yes, it only happens in the first time

DylanDylann · 2024-03-13T09:58:17Z

@filip-solecki You mean that this bug is from BE side, right?

filip-solecki · 2024-03-13T10:46:26Z

I think so - previously while enabling Taxes (in the Old Dot) we called two api (1 for enabling taxes and second one for creating default tax rates) currently we call only the first one as we follow 1:1:1 rule so there is no other way to create default tax rates than enabling Taxes feature on the Old Dot.

DylanDylann · 2024-03-13T10:55:20Z

@luacmartins Everything looks good to me. There is a problem on the native App but @filip-solecki's explanation make sense. Then we can move forward this PR and create another issue to fix it

luacmartins · 2024-03-13T14:08:03Z

@filip-solecki looks like we have conflicts now

kosmydel · 2024-03-13T14:10:15Z

I've resolved conflicts as Filip is AFK.

melvin-bot · 2024-03-13T14:40:20Z

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

luacmartins · 2024-03-13T14:40:46Z

All tests were passing when I merged this PR.

OSBotify · 2024-03-13T14:45:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-13T19:59:39Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-15T10:16:00Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.52-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

suneox · 2024-10-27T16:47:10Z

src/pages/workspace/taxes/WorkspaceTaxesPage.tsx

+                onPress={() => {}}
+                icon={Expensicons.Plus}
+                text={translate('workspace.taxes.addRate')}
+                style={[styles.mr3, isSmallScreenWidth && styles.w50]}


In other places, we’re using mr2 or gap2 between buttons on headers, which is causing this issue.

filip-solecki added 4 commits March 7, 2024 09:27

Create WorkspaceTaxesPage

049c487

Remove unnecessary check

a491463

Remove unnecessary import

bc18001

Fix icon fill color

0ff7067

kosmydel reviewed Mar 7, 2024

View reviewed changes

filip-solecki added 5 commits March 7, 2024 10:07

CR fixes

2d43808

use ListItem type

b63bcbb

Fix tax icon

a97c874

Fix icon tax fill

60aa7d3

Header buttons

e933a60

kosmydel reviewed Mar 7, 2024

View reviewed changes

src/pages/workspace/taxes/WorkspaceTaxesPage.tsx Outdated Show resolved Hide resolved

kosmydel approved these changes Mar 8, 2024

View reviewed changes

Merge branch 'main' into wave8/WorkspaceTaxesPage

be9c328

filip-solecki marked this pull request as ready for review March 8, 2024 09:59

filip-solecki requested a review from a team as a code owner March 8, 2024 09:59

melvin-bot bot requested review from DylanDylann and removed request for a team March 8, 2024 09:59

Merge branch 'main' into wave8/WorkspaceTaxesPage

f06d07b

filip-solecki added 2 commits March 11, 2024 10:48

Add translations and adjust SelectionList

c160d40

Merge branch 'main' into wave8/WorkspaceTaxesPage

6838836

luacmartins self-requested a review March 12, 2024 00:54

luacmartins reviewed Mar 12, 2024

View reviewed changes

src/components/SelectionList/BaseListItem.tsx Outdated Show resolved Hide resolved

src/pages/workspace/taxes/WorkspaceTaxesPage.tsx Outdated Show resolved Hide resolved

src/pages/workspace/taxes/WorkspaceTaxesPage.tsx Show resolved Hide resolved

DylanDylann reviewed Mar 12, 2024

View reviewed changes

src/pages/workspace/taxes/WorkspaceTaxesPage.tsx Outdated Show resolved Hide resolved

src/pages/workspace/taxes/WorkspaceTaxesPage.tsx Outdated Show resolved Hide resolved

src/languages/es.ts Outdated Show resolved Hide resolved

DylanDylann reviewed Mar 12, 2024

View reviewed changes

src/pages/workspace/taxes/WorkspaceTaxesPage.tsx Outdated Show resolved Hide resolved

DylanDylann reviewed Mar 12, 2024

View reviewed changes

src/pages/workspace/taxes/WorkspaceTaxesPage.tsx Outdated Show resolved Hide resolved

DylanDylann approved these changes Mar 13, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins March 13, 2024 10:53

DylanDylann mentioned this pull request Mar 13, 2024

[HOLD for payment 2024-03-26] [Simplified Collect][Taxes] Create WorkspaceNewTaxPage #37793

Closed

luacmartins previously approved these changes Mar 13, 2024

View reviewed changes

Merge branch 'main' into wave8/WorkspaceTaxesPage

14072ae

kosmydel dismissed luacmartins’s stale review via 14072ae March 13, 2024 14:07

luacmartins approved these changes Mar 13, 2024

View reviewed changes

luacmartins merged commit bd02f3e into Expensify:main Mar 13, 2024

melvin-bot bot added the Emergency label Mar 13, 2024

luacmartins removed the Emergency label Mar 13, 2024

luacmartins mentioned this pull request Mar 13, 2024

[HOLD for payment 2024-04-05] [Simplified Collect][Taxes] Optimistically create default tax rates #38234

Closed

github-actions bot mentioned this pull request Mar 13, 2024

Deploy Checklist: New Expensify 2024-03-13 #38257

Closed

74 tasks

This was referenced Mar 13, 2024

Split scan - Empty tax row in split confirmation page which leads to crash #38260

Closed

[$250] [HOLD for payment 2024-03-29] Newly added tag is not arranged in alphabetical order #38261

Closed

melvin-bot bot mentioned this pull request Mar 15, 2024

[HOLD for payment 2024-03-22] [$500] [Simplified Collect][Taxes] Create WorkspaceTaxesPage #37787

Closed

getusha mentioned this pull request Mar 20, 2024

Ensure that disabled feature page cannot be accessed using deep-link #37902

Merged

50 tasks

suneox reviewed Oct 27, 2024

View reviewed changes

suneox mentioned this pull request Oct 27, 2024

[HOLD for payment 2024-11-01] [$250] Inconsistent spacing between Add rate and Settings buttons in Distance rates and Taxes page #50569

Closed

6 tasks

Conversation

filip-solecki commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

melvin-bot bot commented Mar 8, 2024

Uh oh!

filip-solecki commented Mar 11, 2024

Uh oh!

DylanDylann commented Mar 11, 2024

Uh oh!

filip-solecki commented Mar 11, 2024

Uh oh!

filip-solecki commented Mar 11, 2024

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

filip-solecki commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DylanDylann commented Mar 13, 2024

Uh oh!

DylanDylann commented Mar 13, 2024

Uh oh!

filip-solecki commented Mar 13, 2024

Uh oh!

DylanDylann commented Mar 13, 2024

Uh oh!

luacmartins commented Mar 13, 2024

Uh oh!

kosmydel commented Mar 13, 2024

Uh oh!

melvin-bot bot commented Mar 13, 2024

Uh oh!

luacmartins commented Mar 13, 2024

Uh oh!

OSBotify commented Mar 13, 2024

Uh oh!

OSBotify commented Mar 13, 2024

Uh oh!

OSBotify commented Mar 15, 2024

Uh oh!

suneox Oct 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

filip-solecki commented Mar 7, 2024 •

edited

Loading

filip-solecki commented Mar 13, 2024 •

edited

Loading

suneox Oct 27, 2024 •

edited

Loading