[New architecture] Replace `@oguzhnatly/react-native-image-manipulator` with `expo-image-manipulator` [v2] by kosmydel · Pull Request #38145 · Expensify/App

kosmydel · 2024-03-12T15:48:31Z

Details

It replaces the libraries. The first PR #36019 got reverted #38024 because of crash #37963.

Fixed Issues

$ #35984
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Log in to the Expensify account
Go to Account Settings
Press avatar to edit the profile image
Select Upload photo
Pick any photo
Adjust the size and location of the picked image
Press save
Profile Image should be updated
Test it on the release build (more info: iOS - Profile - The App crashes when saving the user's avatar #37963)

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console
Do the tests from above

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mweb-android.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-12.at.19.45.01.mp4

iOS: mWeb Safari

mweb-ios.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…image-manipulator` with `expo-image-manipulator`"" This reverts commit 52491bd.

melvin-bot · 2024-03-12T19:35:23Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2024-03-12T19:39:17Z

src/libs/actions/PersonalDetails.ts

+
+    // We need to remove the base64 value from the file object, as it is causing crashes on Release builds.
+    // More info: https://github.com/Expensify/App/issues/37963#issuecomment-1989260033
+    if ('base64' in file) {


Is this the only place we need to fix this? Should we be putting this somewhere in the cropOrRotateImage or a util?

Right, putting it in the cropOrRotateImage will prevent similar issues in the future. I've moved it.

mananjadhav · 2024-03-12T19:39:58Z

Thanks for raising the PR. @roryabraham Can you please create adhoc builds for this one? So that we can test it on a physical device?

mananjadhav · 2024-03-13T13:27:08Z

The code changes are fine. @roryabraham The latest change commit involves updating the cropOrRotateImage. Can you please retrigger the build so that I can test against the latest changes.

Meanwhile I'll test on the simulators for sure.

mananjadhav · 2024-03-13T13:31:15Z

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web-expo-image.mov

MacOS: Desktop

desktop-expo-image.mov

github-actions · 2024-03-13T22:18:55Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/38145/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/38145/index.html

Desktop 💻	Web 🕸️
❌ FAILED ❌	https://38145.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

👀 View the workflow run that generated this build 👀

blazejkustra

One minor comment, good work overall!

src/libs/cropOrRotateImage/getSaveFormat.ts

github-actions · 2024-03-15T11:18:02Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/38145/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/38145/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/38145/NewExpensify.dmg	https://38145.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

hungvu193

Test well!

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mWebAndroid.mov

iOS: Native

ios.mov

iOS: mWeb Safari

Screen.Recording.2024-03-15.at.19.22.06.mov

MacOS: Chrome / Safari

chrome.mov

MacOS: Desktop

desktop.mov

mananjadhav · 2024-03-15T13:31:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

5294020035429620242android-expo-image.mp4

Android: mWeb Chrome

mweb-chrome-expo-image.mp4

iOS: Native

ios-expo-image.MP4

iOS: mWeb Safari

mweb-safari-expo-image.MP4

MacOS: Chrome / Safari

web-expo-image.mov

MacOS: Desktop

desktop-expo-image.mov

mountiny

Thanks for testing again, lets hope we will be successful this time 🙏

OSBotify · 2024-03-18T16:30:34Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.54-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-19T23:11:38Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.54-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kosmydel added 3 commits March 11, 2024 12:38

Revert "Revert "[New architecture] Replace `@oguzhnatly/react-native-…

e4d85a6

…image-manipulator` with `expo-image-manipulator`"" This reverts commit 52491bd.

fix crash on the release build

ce2d2ea

Merge branch 'main' into @kosmydel/expo-image-manipulator

5204aa9

kosmydel marked this pull request as ready for review March 12, 2024 19:35

kosmydel requested a review from a team as a code owner March 12, 2024 19:35

melvin-bot bot requested review from mananjadhav and removed request for a team March 12, 2024 19:35

mananjadhav reviewed Mar 12, 2024

View reviewed changes

roryabraham added the Ready To Build label Mar 12, 2024

This comment has been minimized.

Sign in to view

kosmydel added 2 commits March 13, 2024 08:32

Merge branch 'main' into @kosmydel/expo-image-manipulator

df67dae

refactor: remove base64 in cropOrRotateImage

eb61a54

blazejkustra approved these changes Mar 14, 2024

View reviewed changes

src/libs/cropOrRotateImage/getSaveFormat.ts Outdated Show resolved Hide resolved

add type

9e7f666

mountiny requested a review from hungvu193 March 15, 2024 10:54

mountiny assigned kosmydel Mar 15, 2024

hungvu193 approved these changes Mar 15, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny March 15, 2024 12:19

mountiny approved these changes Mar 15, 2024

View reviewed changes

mountiny merged commit 7f56bfd into Expensify:main Mar 15, 2024

github-actions bot mentioned this pull request Mar 18, 2024

Deploy Checklist: New Expensify 2024-03-18 #38489

Closed

65 tasks

melvin-bot bot mentioned this pull request Mar 19, 2024

[HOLD for payment 2024-03-26] [$500] [New architecture] Replace @oguzhnatly/react-native-image-manipulator with expo-image-manipulator #35984

Closed

Conversation

kosmydel commented Mar 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 12, 2024

Uh oh!

mananjadhav Mar 12, 2024

Choose a reason for hiding this comment

Uh oh!

kosmydel Mar 13, 2024

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented Mar 12, 2024

Uh oh!

This comment has been minimized.

mananjadhav commented Mar 13, 2024

Uh oh!

mananjadhav commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots/Videos

Uh oh!

github-actions bot commented Mar 13, 2024

Uh oh!

blazejkustra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 15, 2024

Uh oh!

hungvu193 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Screenshots/Videos

Uh oh!

mananjadhav commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Mar 18, 2024

Uh oh!

OSBotify commented Mar 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

kosmydel commented Mar 12, 2024 •

edited

Loading

mananjadhav commented Mar 13, 2024 •

edited

Loading

hungvu193 left a comment •

edited

Loading

mananjadhav commented Mar 15, 2024 •

edited

Loading