QBO import main page by narefyev91 · Pull Request #38400 · Expensify/App

narefyev91 · 2024-03-15T14:40:33Z

Details

Initial implementation for QBO Import main page. Current PR for now blocked by this one PR. But for now code can be started to be reviews from C+ cc @hayata-suenaga. Also will be nice to simulate somehow syncClasses, syncCustomers, syncLocations, syncAccounts, syncTaxes - from API side - to get test data

Fixed Issues

$ #37777
PROPOSAL:

Tests

Navigate to /settings/workspaces/:workspaceID/accounting/quickbooks-online/import
Verify that menu items for Import are shown
Click on each menu item - verify that each of them has toggle to disable/enable feature - verify that click interaction is working
Go back to all menu items - verify that disabling/enabling toggle - changed text from "Not Imported" - to "Imported"/"Imported as a tag"

Verify that no errors appear in the JS console

Offline tests

Navigate to /settings/workspaces/:workspaceID/accounting/quickbooks-online/import
Verify that menu items for Import are shown
Click on each menu item - verify that each of them has toggle to disable/enable feature - verify that click interaction is working
Go back to all menu items - verify that disabling/enabling toggle - changed text from "Not Imported" - to "Imported"/"Imported as a tag"

QA Steps

Navigate to /settings/workspaces/:workspaceID/accounting/quickbooks-online/import
Verify that menu items for Import are shown
Click on each menu item - verify that each of them has toggle to disable/enable feature - verify that click interaction is working
Go back to all menu items - verify that disabling/enabling toggle - changed text from "Not Imported" - to "Imported"/"Imported as a tag"

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

andorid.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-03-15T14:40:38Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/ROUTES.ts

hayata-suenaga · 2024-03-16T18:52:02Z

Also will be nice to simulate somehow syncClasses, syncCustomers, syncLocations, syncAccounts, syncTaxes - from API side - to get test data

Here is the copy from a real data for config property (there is also credentials field in the config object, but I removed it) 😄

Let me know if you have any other questions 👍

{"realmId":"1423559500","companyName":"Expensify","autoSync":{"jobID":"153232671","enabled":true},"syncPeople":false,"syncItems":false,"markChecksToBePrinted":false,"reimbursableExpensesExportDestination":"check","nonReimbursableExpensesExportDestination":"credit_card","reimbursableExpensesAccount":null,"nonReimbursableExpensesAccount":null,"autoCreateVendor":true,"hasChosenAutoSyncOption":true,"syncClasses":"TAG","syncCustomers":"TAG","syncLocations":"NONE","exportDate":"LAST_EXPENSE","lastConfigurationTime":0,"syncTax":false,"enableNewCategories":true,"export":{"exporter":"morobi8226@dovesilo.com"}}

hayata-suenaga · 2024-03-18T16:18:53Z

@narefyev91 could you solve the merge conflict when you have time? 😄
I also have one more question. If the user manually enters the URL for the import page, can they see the new page?

@eVoloshchak could you start reviewing the PR when you have time? 😄
Please note, the code in this pull request (PR) will not be used once it's merged. The feature implemented on this page will be concealed behind a dark launch.

narefyev91 · 2024-03-18T16:21:53Z

@narefyev91 could you solve the merge conflict when you have time? 😄 I also have one more question. If the user manually enters the URL for the import page, can they see the new page?

@eVoloshchak could you start reviewing the PR when you have time? 😄 Please note, the code in this pull request (PR) will not be used once it's merged. The feature implemented on this page will be concealed behind a dark launch.

Sure - will resolve conflicts soon!
Yup we need to initial get merged PR - and after that we will add correct navigation like we have for Workspace profile and right panel screens

hayata-suenaga · 2024-03-18T16:40:47Z

Great! We need to ensure that the new screens are not accessible to users until the entire feature set is complete. Should we use a feature flag to prevent users from accessing these screens?

I assume that if we aim to prevent users from accessing new pages, we would need a code similar to the one below?

{featureFlags.isNewPageEnabled && <Stack.Screen name="NewPage" component={NewPage} />}

# Conflicts: # src/SCREENS.ts # src/libs/Navigation/types.ts

# Conflicts: # src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx

src/pages/workspace/qbo/PolicyQuickbooksImportPage.tsx

# Conflicts: # src/SCREENS.ts # src/libs/Navigation/types.ts

narefyev91 · 2024-03-20T12:55:49Z

@hayata-suenaga also added a new sub-page for Chart of Accounts
will start working on Classes page

hayata-suenaga · 2024-03-21T04:12:12Z

I'll re-review and re-test this tomorrow again 👍

…code

# Conflicts: # src/libs/API/parameters/index.ts # src/libs/API/types.ts # src/types/onyx/Policy.ts

narefyev91 · 2024-03-21T14:46:02Z

@hayata-suenaga @eVoloshchak pushed 2 more pages for Classes and Customers. Will be nice to get one more code review if possible. I think tomorrow i will finish last 2 pages - and we can check all of them together

src/libs/actions/Policy.ts

src/pages/workspace/accounting/qbo/QuickbooksChartOfAccountsPage.tsx

src/CONST.ts

src/libs/API/parameters/UpdatePolicyConnectionConfigParams.ts

src/libs/actions/Policy.ts

src/pages/workspace/accounting/qbo/QuickbooksClassesPage.tsx

eVoloshchak · 2024-04-09T14:35:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

24-04-09-18-27-03.mp4

Android: mWeb Chrome

Screen.Recording.2024-04-09.at.18.18.54.mov

iOS: Native

Screen.Recording.2024-04-09.at.18.20.49.mov

iOS: mWeb Safari

Screen.Recording.2024-04-09.at.18.11.53.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-09.at.17.51.08.mov

MacOS: Desktop

Screen.Recording.2024-04-09.at.18.02.53.mov

src/pages/workspace/accounting/qbo/QuickbooksChartOfAccountsPage.tsx

src/pages/workspace/accounting/WorkspaceAccountingPage.tsx

…ge.tsx Co-authored-by: Eugene Voloshchak <copyreading@gmail.com>

Co-authored-by: Eugene Voloshchak <copyreading@gmail.com>

eVoloshchak

LGTM!

# Conflicts: # src/pages/workspace/accounting/WorkspaceAccountingPage.tsx # src/types/onyx/Policy.ts

hayata-suenaga

looks 🟢 to me 😄

hayata-suenaga · 2024-04-09T20:36:27Z

src/pages/workspace/accounting/qbo/QuickbooksChartOfAccountsPage.tsx

+                                        accessibilityLabel={translate('workspace.qbo.accounts')}
+                                        isOn={isSwitchOn}
+                                        onToggle={() =>
+                                            Policy.updatePolicyConnectionConfig(


ah I didn't know you actually wrote the code to call the API

anyway, these screens are behind the beta, so I think we're okay doing so

hayata-suenaga · 2024-04-09T20:37:15Z

src/pages/workspace/accounting/qbo/QuickbooksChartOfAccountsPage.tsx

+    const isSwitchOn = Boolean(enableNewCategories && enableNewCategories !== CONST.INTEGRATION_ENTITY_MAP_TYPES.NONE);
+
+    return (
+        <AdminPolicyAccessOrNotFoundWrapper policyID={policyID}>


OSBotify · 2024-04-09T20:44:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-10T17:45:30Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-04-10T17:54:23Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-04-10T19:33:36Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-18T04:31:21Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.62-17 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

narefyev91 added 2 commits March 15, 2024 16:37

QBO import main page

96635ab

lock

b9670c9

narefyev91 requested a review from a team as a code owner March 15, 2024 14:40

melvin-bot bot requested review from eVoloshchak and removed request for a team March 15, 2024 14:40

hayata-suenaga self-requested a review March 16, 2024 14:51

hayata-suenaga reviewed Mar 16, 2024

View reviewed changes

src/ROUTES.ts Outdated Show resolved Hide resolved

narefyev91 added 4 commits March 18, 2024 19:16

Merge branch 'main' into qbo-import-main-page

ef23460

# Conflicts: # src/SCREENS.ts # src/libs/Navigation/types.ts

Merge branch 'main' into qbo-import-main-page

c863078

# Conflicts: # src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx

Add Chart of account sub page + new routes and Policy api

8e78317

prettier

c0fe32b

eVoloshchak suggested changes Mar 19, 2024

View reviewed changes

narefyev91 added 2 commits March 20, 2024 11:29

resolve suggested comments

f85ce0d

Merge branch 'main' into qbo-import-main-page

1b8bfb9

# Conflicts: # src/SCREENS.ts # src/libs/Navigation/types.ts

narefyev91 added 2 commits March 20, 2024 15:39

update naming, add mock pages, and correct routing

7b90e68

fix ts

758a77b

narefyev91 added 3 commits March 21, 2024 16:37

add 2 more screen - classes and customer + pending actions, clean up …

441bbf0

…code

Merge branch 'main' into qbo-import-main-page

56c728f

# Conflicts: # src/libs/API/parameters/index.ts # src/libs/API/types.ts # src/types/onyx/Policy.ts

update after merge conflicts

6bc7a25

narefyev91 added 3 commits March 21, 2024 16:50

remove line

3a6113b

lint

bcfa12a

Taxes and Locations pages

3477c63

resolve comments

3ca396f

narefyev91 requested a review from eVoloshchak April 8, 2024 11:12

hayata-suenaga mentioned this pull request Apr 8, 2024

Add new HOC to get policy.connections data #39132

Merged

58 tasks

remove true false from types

b4d73c1

eVoloshchak suggested changes Apr 9, 2024

View reviewed changes

src/libs/actions/Policy.ts Outdated Show resolved Hide resolved

src/pages/workspace/accounting/qbo/QuickbooksChartOfAccountsPage.tsx Outdated Show resolved Hide resolved

src/CONST.ts Outdated Show resolved Hide resolved

eVoloshchak suggested changes Apr 9, 2024

View reviewed changes

resolve c+ comments

fb31fb1

narefyev91 requested a review from eVoloshchak April 9, 2024 11:45

eVoloshchak suggested changes Apr 9, 2024

View reviewed changes

src/pages/workspace/accounting/qbo/QuickbooksChartOfAccountsPage.tsx Outdated Show resolved Hide resolved

src/pages/workspace/accounting/WorkspaceAccountingPage.tsx Outdated Show resolved Hide resolved

narefyev91 and others added 2 commits April 9, 2024 18:05

Update src/pages/workspace/accounting/qbo/QuickbooksChartOfAccountsPa…

6355d8c

…ge.tsx Co-authored-by: Eugene Voloshchak <copyreading@gmail.com>

Update src/pages/workspace/accounting/WorkspaceAccountingPage.tsx

08bbde1

Co-authored-by: Eugene Voloshchak <copyreading@gmail.com>

narefyev91 requested a review from eVoloshchak April 9, 2024 15:12

eVoloshchak approved these changes Apr 9, 2024

View reviewed changes

narefyev91 added 3 commits April 9, 2024 19:44

Merge branch 'main' into qbo-import-main-page

1a94706

# Conflicts: # src/pages/workspace/accounting/WorkspaceAccountingPage.tsx # src/types/onyx/Policy.ts

merge updates

79b9198

prettier

03c7452

hayata-suenaga approved these changes Apr 9, 2024

View reviewed changes

hayata-suenaga merged commit 1b83aa5 into Expensify:main Apr 9, 2024

alexpensify mentioned this pull request Apr 9, 2024

[$250] [HOLD for payment 2024-04-25] [Wave Collect][QBO] Implement Import-related screens #37777

Closed

github-actions bot mentioned this pull request Apr 10, 2024

Deploy Checklist: New Expensify 2024-04-10 #40026

Closed

deetergp mentioned this pull request Apr 11, 2024

Web - Accounting - Multiple functions in the Accounting page are non responsive #40035

Closed

6 tasks

This was referenced Apr 12, 2024

Implement a new action to update the configuration for connection with accounting software #38006

Closed

[Wave Collect][QBO] Fix the type mistakes made in the Import main page PR #40195

Closed

Fix param type #40196

Merged

Conversation

narefyev91 commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 15, 2024

Uh oh!

Uh oh!

hayata-suenaga commented Mar 16, 2024

Uh oh!

hayata-suenaga commented Mar 18, 2024

Uh oh!

narefyev91 commented Mar 18, 2024

Uh oh!

hayata-suenaga commented Mar 18, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

narefyev91 commented Mar 20, 2024

Uh oh!

hayata-suenaga commented Mar 21, 2024

Uh oh!

narefyev91 commented Mar 21, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eVoloshchak commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

hayata-suenaga left a comment

Choose a reason for hiding this comment

Uh oh!

hayata-suenaga Apr 9, 2024

Choose a reason for hiding this comment

Uh oh!

hayata-suenaga Apr 9, 2024

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 9, 2024

Uh oh!

OSBotify commented Apr 10, 2024

Uh oh!

OSBotify commented Apr 10, 2024

Uh oh!

OSBotify commented Apr 10, 2024

Uh oh!

OSBotify commented Apr 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

narefyev91 commented Mar 15, 2024 •

edited

Loading

eVoloshchak commented Apr 9, 2024 •

edited

Loading