Fix video replay issue in iOS by ShridharGoel · Pull Request #38419 · Expensify/App

ShridharGoel · 2024-03-15T19:33:11Z

Details

Fix video replay issue in iOS.

Fixed Issues

$ #37249
PROPOSAL: #37249 (comment)

Tests

Open a video attachment.
Let the video play in normal mode.
Try to play/pause a few times.
Once the video completes, try to replay it.
Do the same (steps 2-4) for fullscreen mode.

Verify that no errors appear in the JS console

QA Steps

Open a video attachment.
Let the video play in normal mode.
Try to play/pause a few times.
Once the video completes, try to replay it.
Do the same (steps 2-4) for fullscreen mode.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-03.at.12.47.23.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-04-03.at.1.35.46.AM.mov

iOS: Native

Screen.Recording.2024-04-03.at.12.56.59.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-04-03.at.1.31.00.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-02.at.9.56.40.PM.mov

MacOS: Desktop

Screen.Recording.2024-04-02.at.9.59.45.PM.mov

melvin-bot · 2024-03-15T19:33:16Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2024-03-17T15:11:32Z

@ShridharGoel I understand the impacted platform is just iOS. But considering the change is in BaseVideoPlayer, can we please add test videos for all the platforms? We don't want any regressions because of this change.

ShridharGoel · 2024-03-17T19:16:36Z

@mananjadhav Added for other platforms as well, apart from Android native. Will add that also soon.

ShridharGoel · 2024-03-18T09:23:01Z

@mananjadhav All videos have been added.

mananjadhav · 2024-03-19T15:06:42Z

Thanks for the update @ShridharGoel. While the code changes look good, I need to check if adding isPlaying dependency causes any further issues. Please allow a day for me to test these scenrios.

ShridharGoel · 2024-03-21T19:48:07Z

@mananjadhav Gentle bump on this.

mananjadhav · 2024-03-22T16:02:01Z

@ShridharGoel Can we elaborate the test steps to also add the full-screen mode?

mananjadhav · 2024-03-22T16:16:50Z

@ShridharGoel I am still seeing some issues when I click on the Play button.

Screen.Recording.2024-03-23.at.1.14.32.AM.mov

ShridharGoel · 2024-03-22T16:21:23Z

@mananjadhav I didn't get the issue from the video that you've attached. Shouldn't the play button be clicked after video is complete to check this?

mananjadhav · 2024-03-22T22:40:08Z

Yes the center play button to be clicked in the full screen mode after the video is complete.

mananjadhav · 2024-03-23T03:53:53Z

fyi I just followed the steps mentioned in the issue reproduction steps.

ShridharGoel · 2024-03-24T15:48:22Z

@mananjadhav Can you check once again if your build was having the changes from my branch? It was working correctly for me.

mananjadhav · 2024-03-26T08:51:40Z

@ShridharGoel I had tried in your branch only with the latest main at that point of time. I'll take a look at my end again, but can we merge the latest main and try once again?

Can you upload the screencast of the iOS along with the steps you performed?

ShridharGoel · 2024-03-29T07:17:00Z

@mananjadhav Video with updated main

Screen.Recording.2024-03-29.at.12.45.29.PM.mov

mananjadhav · 2024-03-29T09:35:32Z

Hmm. Thanks for the video, I'll take a look.

mananjadhav · 2024-03-31T17:57:27Z

@ShridharGoel It worked this time on iOS but not on the web. Clicking on the center of the video doesn't play/pause the video. It glitches and then continues to play.

web-playback-error_oa2p66ub.mp4

I think for all the platforms, we should be doing a thorough testing for all play-pause controls, the buttons, the screen, full screen mode, and play-pause end of the video, middle of the video.

Also, can we improve the content of the Test steps? Let's include, the part for fullscreen and also mention that we should hit Play-Pause a few times when the video is played.

ShridharGoel · 2024-03-31T18:14:31Z

@mananjadhav shouldReplayVideo always returns false for web. This change shouldn't affect that.

mananjadhav · 2024-03-31T18:16:08Z

@mananjadhav shouldReplayVideo always returns false for web. This change shouldn't affect that.

I tested this against the staging env and latest main. Can you confirm at your end?

ShridharGoel · 2024-04-02T11:10:02Z

@mananjadhav Should we remove isPlaying from the dependencies of useCallback? It doesn't seem needed.

ShridharGoel · 2024-04-02T11:17:06Z

@mananjadhav I've removed the isPlaying dependency, can you check again?

mananjadhav · 2024-04-02T11:45:53Z

I checked on Web it worked fine, but I'll need time to test all platforms.

I think for all the platforms, we should be doing a thorough testing for all play-pause controls, the buttons, the screen, full screen mode, and play-pause end of the video, middle of the video.

Can you please update your screencasts to cover. This is to ensure we don't add any regression.

Also, can we improve the content of the Test steps? Let's include, the part for fullscreen and also mention that we should hit Play-Pause a few times when the video is played.

And can you also update the Test steps as requested earlier?

ShridharGoel · 2024-04-02T11:52:38Z

Updated description. Will add the videos in few hours.

mananjadhav · 2024-04-02T11:56:28Z

Thanks, just post a comment once the videos are uploaded. I think I'll also be able to test by that time. Thank you for your patience.

mananjadhav · 2024-04-02T17:48:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-video-replay.mov

Android: mWeb Chrome

mweb-chrome-video-replay.mov

iOS: Native

ios-video-replay.mov

iOS: mWeb Safari

mweb-safari-video-replay.mov

MacOS: Chrome / Safari

web-video-replay_2ddspBnh.mp4

MacOS: Desktop

desktop-video-replay_0ksQDmtJ.mp4

cead22 · 2024-04-02T19:10:21Z

src/components/VideoPlayer/BaseVideoPlayer.js

            videoStateRef.current = e;
            onPlaybackStatusUpdate(e);
        },
+        // eslint-disable-next-line react-hooks/exhaustive-deps


Can you add a comment explaining why we're not adding all the deps?

ShridharGoel · 2024-04-02T20:11:07Z

@mananjadhav New videos have been added.

cead22 · 2024-04-02T21:33:41Z

src/components/VideoPlayer/BaseVideoPlayer.js

            videoStateRef.current = e;
            onPlaybackStatusUpdate(e);
        },
+        // eslint-disable-next-line react-hooks/exhaustive-deps -- we don't want to trigger this when isPlaying changes because isPlaying is only used inside shouldReplayVideo


OSBotify · 2024-04-02T21:45:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-08T10:54:26Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix video replay issue in iOS

d494a03

ShridharGoel requested a review from a team as a code owner March 15, 2024 19:33

melvin-bot bot removed the request for review from a team March 15, 2024 19:33

melvin-bot bot requested a review from mananjadhav March 15, 2024 19:33

ShridharGoel force-pushed the patch-2 branch from ac31e8c to d494a03 Compare April 2, 2024 11:16

ShridharGoel added 2 commits April 2, 2024 17:13

Disable ESlint exhaustive deps since isPlaying shouldn't be a dependency

338d3bf

Merge branch 'main' of https://github.com/Expensify/App into patch-2

6d5cf81

Merge branch 'main' of https://github.com/Expensify/App into patch-2

76719bb

mananjadhav approved these changes Apr 2, 2024

View reviewed changes

melvin-bot bot requested a review from cead22 April 2, 2024 18:37

mananjadhav approved these changes Apr 2, 2024

View reviewed changes

cead22 requested changes Apr 2, 2024

View reviewed changes

Add comment for exhaustive dependencies ESlint skipping

aa15e02

cead22 approved these changes Apr 2, 2024

View reviewed changes

cead22 merged commit 0ca78c3 into Expensify:main Apr 2, 2024

github-actions bot mentioned this pull request Apr 4, 2024

[INCORRECT] (used to be a checklist but was incorrectly triggered) #39573

Closed

44 tasks

mountiny mentioned this pull request Apr 4, 2024

Deploy Checklist: New Expensify 2024-04-04 #39588

Closed

48 tasks

melvin-bot bot mentioned this pull request Apr 8, 2024

[HOLD for payment 2024-04-15] [$500] iOS - Video - User needs to tap on play button twice for the video to restart #37249

Closed

6 tasks

Conversation

ShridharGoel commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 15, 2024

Uh oh!

mananjadhav commented Mar 17, 2024

Uh oh!

ShridharGoel commented Mar 17, 2024

Uh oh!

ShridharGoel commented Mar 18, 2024

Uh oh!

mananjadhav commented Mar 19, 2024

Uh oh!

ShridharGoel commented Mar 21, 2024

Uh oh!

mananjadhav commented Mar 22, 2024

Uh oh!

mananjadhav commented Mar 22, 2024

Uh oh!

ShridharGoel commented Mar 22, 2024

Uh oh!

mananjadhav commented Mar 22, 2024

Uh oh!

mananjadhav commented Mar 23, 2024

Uh oh!

ShridharGoel commented Mar 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mananjadhav commented Mar 26, 2024

Uh oh!

ShridharGoel commented Mar 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mananjadhav commented Mar 29, 2024

Uh oh!

mananjadhav commented Mar 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShridharGoel commented Mar 31, 2024

Uh oh!

mananjadhav commented Mar 31, 2024

Uh oh!

ShridharGoel commented Apr 2, 2024

Uh oh!

ShridharGoel commented Apr 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mananjadhav commented Apr 2, 2024

Uh oh!

ShridharGoel commented Apr 2, 2024

Uh oh!

mananjadhav commented Apr 2, 2024

Uh oh!

mananjadhav commented Apr 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

cead22 Apr 2, 2024

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Apr 2, 2024

Choose a reason for hiding this comment

Uh oh!

ShridharGoel commented Apr 2, 2024

Uh oh!

cead22 Apr 2, 2024

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 2, 2024

Uh oh!

OSBotify commented Apr 8, 2024

Uh oh!

ShridharGoel commented Mar 15, 2024 •

edited

Loading

ShridharGoel commented Mar 24, 2024 •

edited

Loading

ShridharGoel commented Mar 29, 2024 •

edited

Loading

mananjadhav commented Mar 31, 2024 •

edited

Loading

ShridharGoel commented Apr 2, 2024 •

edited

Loading

mananjadhav commented Apr 2, 2024 •

edited

Loading