fix: Room - Selection list RHP does not show sliding animation while being dismissed.

[Krishna2323]

Details

Fixed Issues

$ #38665
PROPOSAL:

Tests

1. Go to staging.new.expensify.com.
2. Go to FAB > Start room.
3. Go to Room.
4. Click Workspace (or Who can post or Visibility).
5. Click outside the RHP
6. Verify there is an animation

• Verify that no errors appear in the JS console

Offline tests

1. Go to staging.new.expensify.com.
2. Go to FAB > Start room.
3. Go to Room.
4. Click Workspace (or Who can post or Visibility).
5. Click outside the RHP
6. Verify there is an animation

QA Steps

1. Go to staging.new.expensify.com.
2. Go to FAB > Start room.
3. Go to Room.
4. Click Workspace (or Who can post or Visibility).
5. Click outside the RHP
6. Verify there is an animation

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

[melvin-bot]

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[Krishna2323]

Discussing with @hoangzinh on Slack, probably this PR will get approved by C+ tomorrow.

[Krishna2323]

@hoangzinh, changes added.

[hoangzinh]

@danieldoglas @Krishna2323 I'm considering whether we should fix this animation issue or not.

• Current:

Screen.Recording.2024-03-27.at.07.29.46.mov

• After Fix:

Screen.Recording.2024-03-27.at.07.27.37.mov

After fix, the 2 modals are sliding differentially, causing another UI issue. I think new UI issue is worse than current behavior

[danieldoglas]

Did we find out why that's happening? Can't we fix it?

[hoangzinh]

Originally I thought the 2 modals were sliding differentially. But let's wait for @Krishna2323 to investigate this issue.

[Krishna2323]

Sorry for delay, I will investigate today and update.

[rlinoz]

@Krishna2323 did you have the time to investigate this?

[Krishna2323]

Hi everyone, I've tried various ways to fix the new UI issue mentioned here, but I couldn't find a solution. I feel the new issue isn't that bad since we barely see two modals because the animation happens fast. I would like to hear all of your thoughts too.

2_modal.mp4

[Krishna2323]

@hoangzinh @danieldoglas, bump incase you missed my comment above ^

[rlinoz]

Why the issue doesn't happen when changing the merchant in the create money request flow?

[rlinoz]

thoughts on the comment above? @hoangzinh @Krishna2323

[Krishna2323]

@rlinoz, I suppose that's because the ValuePicker is a modal, while the selector for changing the merchant in the create money request flow is a screen. Therefore, Navigation.dismissModal handles the animation, but for a modal, that's not the case.

@hoangzinh, could you please help clarify this if you have any ideas? I know very little about navigation in React Native.

[hoangzinh]

I guess because there are 2 modals, and it closes dependently then it causes this issue #38711 (comment). @Krishna2323 is it possible if we close RHN first, then close Value modal later?

[Krishna2323]

@hoangzinh, I tried but that didn't worked.

[hoangzinh]

@Krishna2323 I saw that we have onModalDidClose callback, could you check if we can leverage it?

[rlinoz]

@Krishna2323 bump on hoangzinh comment above

[Krishna2323]

@hoangzinh, I tried your suggestion, but unfortunately, it didn't work. I also attempted to set the opacity of the modal behind to 0, but we still see an empty modal with a green background, which seems a bit hackish. IDK what should we do here, I already spent too much time on this PR and the original PR :(

[hoangzinh]

^ I appreciate your effort here @Krishna2323 . To be honest, I don't have any other ideas to fix this sliding issue as well.

@rlinoz @danieldoglas what do you think about my comment here again #38711 (comment)? Thanks

[CortneyOfstad]

@rlinoz @danieldoglas what do you think about my comment here again #38711 (comment)? Thanks

@rlinoz @danieldoglas — any update? Thanks!

[rlinoz]

I don't know what else we can do here, did we ask on the expensify-open-source channel?

I got this hacky solution working, which mostly works, but I don't really wanna go with it.

onBackdropPress={() => {
    Navigation.dismissModal();
    setTimeout(() => hidePickerModal(), 100);
}}

[hoangzinh]

Should we re-open this issue for other external contributors?

[rlinoz]

Yeah, I think we should, so we can try to get to a proper solution for this

[hoangzinh]

@Krishna2323 do you agree with that #38711 (comment)?

[Krishna2323]

@hoangzinh @rlinoz, yes, we can try, but I think there will only be workarounds for this. The only straightforward solution, in my opinion, is to create separate pages for these modals, which I initially did here. However, it was closed because we believed it was a poor investment in terms of ROI, given the high effort involved. IDK whats best here :(

[hoangzinh]

As we all don't know what is the best solution to fix this issue. To speed up progress here, I think we can either:

• Try to re-open it for other contributors
• Close this issue and focus on other issues because it's a "small" UX issue.

[rlinoz]

Ok, let's go with that, we reopen the issue for proposals and if no good one comes up we close since we don't want to create this screens as separate pages.

[Krishna2323]

The issue has been closed. #38665 (comment)