Deselect attendees when splitting bill

[rushatgabhane]

Progress so far.

• Toggle between selected and unselected participants.
• The amount is split between selected participants only.
• Disable button when no participants is selected.
• New group shouldn't be created for selected participants.
• (This will be handled by API layer. See Reference) Add the split comment to the group DM with selected participants only.

Details

Comment
To check if a split happening from a group DM, props.route.params.reportID is checked.

Fixed Issues

$ #3841

Tests / QA

1. Login to E.cash
2. Go to a group DM
3. Click on +, then split bill.
4. Enter amount and go next.
5. Verify that you can unselect 'who was there'.
6. Verify that the amount is split correctly.
7. After splitting bill. Verify that bill is split only among the selected participants.
8. Verify that no new group is created.
9. Verify that split comment in group DM only lists the selected participants.

Tested On

Don't have a Mac to test iOS, Desktop.

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

newWebVideo.mp4

Mobile Web

Desktop

iOS

Android

newAndroid.mp4

[Luke9389]

This looks really good 👍

Great work so far, and I'm eager to discuss this solution with you further in the comments.

[Luke9389]

This is looking great! I know we've done several rounds of reviews, but I think it's really gonna show in the end. Thanks for hanging in there!

[rushatgabhane]

This is looking great! I know we've done several rounds of reviews, but I think it's really gonna show in the end. Thanks for hanging in there!

Actually, thanks for your time!
Yes.

[Luke9389]

OK @rushatgabhane, go ahead and test this branch on Android, Web, and Mobile Web. I'll test Desktop and iOS on your behalf. Though, I do highly recommend you set up a mac vm to test iOS changes in the future. The chance of us hiring contributors who do not have an iOS testing environment in the future will continue to decrease.

[marcaaron]

Just passing through to leave some quick style notes.

[rushatgabhane]

OK @rushatgabhane, go ahead and test this branch on Android, Web, and Mobile Web. I'll test Desktop and iOS on your behalf. Though, I do highly recommend you set up a mac vm to test iOS changes in the future. The chance of us hiring contributors who do not have an iOS testing environment in the future will continue to decrease.

Yes, thank you!
Will setup a Mac VM for my next PRs for testing.

[rushatgabhane]

I've tested this branch. And updated the screenshots for web, android, and mWeb.

[Luke9389]

OK! Just tested on iOS and desktop. Lookin' good. 👍

[Luke9389]

It looks like there are now merge conflicts here. I've approved the code here, and I'll be out of office next week, so perhaps @marcaaron can give the final approve and merge once the conflicts are addressed.

[rushatgabhane]

Apologies for the forced-push! I had messed up the commit history.

Merge conflicts are fixed and tested ✔

verified 1:1

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging in version: 1.0.82-8🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅