Skip to content

Fix for "No results found" text is not aligned to left edge#38852

Merged
grgia merged 6 commits intoExpensify:mainfrom
brandonhenry:37984-no-results-found-text-updates
Apr 2, 2024
Merged

Fix for "No results found" text is not aligned to left edge#38852
grgia merged 6 commits intoExpensify:mainfrom
brandonhenry:37984-no-results-found-text-updates

Conversation

@brandonhenry
Copy link
Contributor

@brandonhenry brandonhenry commented Mar 23, 2024 •
edited
Loading

Details

Fixed Issues

$ #37984
PROPOSAL: #37984 (comment)

Tests

  1. Open the Expensify app.
  2. Click on the search functionality.
  3. Type some random text that will result in a "No results found" message.
  • Verify that the "No results found" message is aligned with the left edge of the search input.
  • Verify that the app behaves as expected and no errors appear in the JS console.

Repeat steps 1-3 for all supported platforms:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop

Offline tests

  1. Open the Expensify app.
  2. Click on the search functionality.
  3. Type some random text that will result in a "No results found" message.
  4. Verify that the "No results found" message is aligned with the left edge of the search input.
  5. Verify that the app behaves as expected and no errors appear in the JS console.
  6. Disable the internet connection on the device.
  • Verify that the search functionality displays the appropriate offline message or placeholder UI.
  • Verify that the app does not crash or display any error messages related to the search functionality while offline.
  1. Re-enable the internet connection and verify that the search functionality returns to normal operation and the alignment fix remains intact.

Repeat steps 1-9 with a spotty or slow internet connection to ensure the search functionality handles these scenarios gracefully.

Repeat steps 1-10 for all supported platforms:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop

QA Steps

  1. Open the Expensify app.
  2. Click on the search functionality.
  3. Type some random text that will result in a "No results found" message.
  4. Verify that the "No results found" message is aligned with the left edge of the search input.
  5. Verify that no errors appear in the JS console.
  6. Repeat steps 1-5 for all supported platforms:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • Verify that the alignment fix does not break the styling or alignment of headerMessage in other places where BaseSelectionList is used.
  • Test the search functionality thoroughly to ensure there are no regressions or unintended side effects caused by the alignment fix.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native image
Android: mWeb Chrome image
iOS: Native image
iOS: mWeb Safari image
MacOS: Chrome / Safari image
MacOS: Desktop image

@brandonhenry
init
2fde4ce
@brandonhenry
Added custom styling
3a63b46
@brandonhenry
Update index.ts
e7ebebb
@brandonhenry
Merge remote-tracking branch 'upstream/main' into 37984-no-results-fo…
520b140 
…und-text-updates
@brandonhenry
Squashed commit of the following:
65e2cae 
commit 34d1497
Merge: cdb8f23 4822c1b
Author: Brandon Henry <itsbhenry@gmail.com>
Date:   Thu Mar 28 19:08:40 2024 -0500

    Merge remote-tracking branch 'upstream/main' into 37984-fix-search-lhn-no-results-found-padding

commit cdb8f23
Merge: cfd7a8b 6c95dfb
Author: Brandon Henry <itsbhenry@gmail.com>
Date:   Thu Mar 28 00:00:30 2024 -0500

    Merge remote-tracking branch 'upstream/main' into 37984-fix-search-lhn-no-results-found-padding

commit cfd7a8b
Author: Brandon Henry <itsbhenry@gmail.com>
Date:   Tue Mar 26 21:10:53 2024 -0500

    added new styling for headermessage
@brandonhenry
updated conditional
9585a87
@brandonhenry brandonhenry marked this pull request as ready for review March 29, 2024 00:52
@brandonhenry brandonhenry requested a review from a team as a code owner March 29, 2024 00:52
@melvin-bot melvin-bot bot removed the request for review from a team March 29, 2024 00:52
@melvin-bot
Copy link

melvin-bot bot commented Mar 29, 2024

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from allroundexperts March 29, 2024 00:52
@brandonhenry brandonhenry changed the title [37984] "No results found" text is not aligned to left edge Fix for "No results found" text is not aligned to left edge Mar 30, 2024
@brandonhenry
Copy link
Contributor Author

brandonhenry commented Mar 30, 2024

getting screenshots today

@brandonhenry
Copy link
Contributor Author

brandonhenry commented Mar 31, 2024

screenshots added

@allroundexperts
Copy link
Contributor

allroundexperts commented Apr 1, 2024

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native Screenshot 2024-04-01 at 4 21 59 PM
Android: mWeb Chrome Screenshot 2024-04-01 at 4 21 28 PM
iOS: Native Screenshot 2024-04-01 at 4 20 44 PM
iOS: mWeb Safari Screenshot 2024-04-01 at 4 20 30 PM
MacOS: Chrome / Safari Screenshot 2024-04-01 at 4 18 37 PM
MacOS: Desktop Screenshot 2024-04-01 at 4 19 55 PM

allroundexperts
allroundexperts approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@allroundexperts allroundexperts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@melvin-bot melvin-bot bot requested a review from grgia April 1, 2024 11:26
@brandonhenry
Copy link
Contributor Author

brandonhenry commented Apr 2, 2024

excellent, over to you @grgia !

@grgia grgia merged commit d7161ae into Expensify:main Apr 2, 2024
@OSBotify
Copy link
Contributor

OSBotify commented Apr 2, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@brandonhenry brandonhenry deleted the 37984-no-results-found-text-updates branch April 2, 2024 14:38
@github-actions github-actions bot mentioned this pull request Apr 4, 2024
Closed
44 tasks
@mountiny mountiny mentioned this pull request Apr 4, 2024
Closed
48 tasks
@brandonhenry brandonhenry mentioned this pull request Apr 5, 2024
Closed
6 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Apr 8, 2024

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grgia grgia grgia approved these changes

+1 more reviewer

@allroundexperts allroundexperts allroundexperts approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brandonhenry @allroundexperts @OSBotify @grgia