Truncation fix for Lack of maximum height for the description field#38890
Merged
puneetlath merged 104 commits intoExpensify:mainfrom Aug 26, 2024
Merged
Truncation fix for Lack of maximum height for the description field#38890puneetlath merged 104 commits intoExpensify:mainfrom
puneetlath merged 104 commits intoExpensify:mainfrom
Conversation
brandonhenry
changed the title
Contributor
Author
|
this is awaiting review over at |
6 tasks
melvin-bot
bot
requested review from
shubham1206agra
and removed request for
a team
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
|
@brandonhenry Can you create a temporary function here to test this flow? |
Contributor
Author
|
@shubham1206agra example added where the fix is meant to be applied. Used 300 as the limit |
Contributor
Author
|
@shubham1206agra any updates on this one 😄 |
Contributor
|
@brandonhenry Can you merge main here? |
Contributor
Author
|
@shubham1206agra just merged it in |
Contributor
Author
|
@shubham1206agra let me know if you find anything on this, hopefully we can get this merged before Tuesday 🤞🏿 |
Contributor
|
Not really. This approach has some weird bugs. I am going through https://github.com/huang47/nodejs-html-truncate/blob/master/lib/truncate.js to check whether this approach is viable. Your current approach doesn't truncate correctly, and there is some inconsistency to actual output. |
Contributor
Author
|
@shubham1206agra alrighty, did you have any examples of input that you saw weird output? I tested thoroughly and wasn't able to get anything weird, so just curious |
Contributor
@brandonhenry This is one specific example. The blockquote is changing the truncation of text. |
Contributor
Author
|
@shubham1206agra do you actually notice any markdown breaking though? I did some digging here and I noticed that i had implemented this not how we want this to be. I updated and things are working very consistent. The steps are:
check it out now and let me know thoughts I tested with these inputs: |
Co-authored-by: Shubham Agrawal <58412969+shubham1206agra@users.noreply.github.com>
Co-authored-by: Shubham Agrawal <58412969+shubham1206agra@users.noreply.github.com>
Co-authored-by: Shubham Agrawal <58412969+shubham1206agra@users.noreply.github.com>
Contributor
Author
|
@shubham1206agra this is ready to be merged |
shubham1206agra
approved these changes
Aug 23, 2024
Contributor
|
@puneetlath Ping for the merge |
puneetlath
requested changes
Aug 26, 2024
Contributor
puneetlath
left a comment
puneetlath
left a comment
There was a problem hiding this comment.
Two very small comments from me to improve the variable naming and comments.
Co-authored-by: Puneet Lath <puneet@expensify.com>
Co-authored-by: Puneet Lath <puneet@expensify.com>
Contributor
Author
|
@puneetlath yep! added those in, good catch |
puneetlath
requested changes
Aug 26, 2024
Contributor
puneetlath
left a comment
puneetlath
left a comment
There was a problem hiding this comment.
Typecheck is failing. I think because of the comment I left.
Contributor
Author
|
@puneetlath yee pulled it down and fixed the issues 👍🏿 |
puneetlath
approved these changes
Aug 26, 2024
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions
bot
added
the
DeployBlockerCash
Contributor
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
Contributor
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
Contributor
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.25-0 🚀
|
1 similar comment
Contributor
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.25-0 🚀
|
Closed
6 tasks
| } | ||
|
|
||
| if (shouldTruncateTitle) { | ||
| titleToWrap = Parser.truncateHTML(titleToWrap, characterLimit, {ellipsis: '...'}); |
Contributor
There was a problem hiding this comment.
We forgot to wrap the content in comment tag, which broke this truncation for plain text. The issue is here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #37357
PROPOSAL: #37357 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop