Replace OptionsSelector with SelectionList - part 1 by filip-solecki · Pull Request #38994 · Expensify/App

filip-solecki · 2024-03-26T11:25:51Z

Details

First part of migration OptionsSelector to SelectionList covers 4 pages. Remaining 3 will be covered in separate PR and OptionsSelector will be removed there as well.

Fixed Issues

$ #25125
PROPOSAL:

Tests

Verify that no errors appear in the JS console

BaseShareLogList:

Log in to the app
Go to Profile -> About -> Troubleshoot
Enable Client side logging if disabled
Click „View debug console”
Click „Share log”
Test all list’s functionalities

WorkspaceSwitcherPage

Log in to the app
Go to Home Page
Click Logo in the left top corner
Test all Workspace Switcher functionalities

TagPicker

Log in to the app
Click FAB icon
Select Money Request
Select an amount and go Next
Select a Workspace as a user where to Request money and click Next
Click on Show more
Select Tag
Search for a tag
Verify that Search is working
Select a Tag
Verify that page is working properly and you can request a money

EditReportFieldDropdownPage

Log in to the app
On a Paid workspace, in Old dot, set report field of Dropdown type.
Open ND and create an expense report on the above workspace.
Open the expense report and make sure that canUseReportFields beta is enabled.
Verify that created custom field show up.
Click on it and test if everything works fine
Make sure that the field gets saved successfully.
Verify that selecting an already selected dropdown option again deselects it.

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

WorkspaceSwitcher

Android: Native

WorkspaceSwitcher_ANDROID.mov

Android: mWeb Chrome

WorkspaceSwitcher_AND_CHROME.mov

iOS: Native

WorkspaceSwitcher_IOS.mp4

iOS: mWeb Safari

WorkspaceSwitcher_IOS_SAFARI.mp4

MacOS: Chrome / Safari

Workspace_Switcher_WEB.mov

MacOS: Desktop

WorkspaceSwithcer_DESKTOP.mov

ShareLog

Android: Native

ShareLog_ANDROID.mov

Android: mWeb Chrome

ShareLog_AND_CHROME.mov

iOS: Native

ShareLog_IOS.mp4

iOS: mWeb Safari

ShareLog_IOS_SAFARI.mp4

MacOS: Chrome / Safari

Share_log_WEB.mov

MacOS: Desktop

ShareLog_DESKTOP.mov

TagPicker

Android: Native

TagPicker_ANDROID.mov

Android: mWeb Chrome

TagPicker_AND_CHROME.mov

iOS: Native

TagPicker_IOS.mp4

iOS: mWeb Safari

TagPicker_IOS_SAFARI.mp4

MacOS: Chrome / Safari

TagPicker_WEB.mov

MacOS: Desktop

TagPicker_DESKTOP.mov

EditReportFieldDropdownPage

Android: Native

Dropdown_ANDROID.mov

Android: mWeb Chrome

Dropdown_AND_CHROME.mov

iOS: Native

Dropdown_IOS.mp4

iOS: mWeb Safari

Dropdown_IOS_SAFARI.mp4

MacOS: Chrome / Safari

EditReportFieldDropdownPage_WEB.mov

MacOS: Desktop

Dropdown_DESKTOP.mov

EDIT Added `isSelected` mark in `EditReportFieldDropdownPage`, as on the screenshot below:

blazejkustra

Code looks good! We have to test these components thoroughly. Thanks for the extensive QA steps 🙌

src/components/SelectionList/BaseListItem.tsx

src/libs/OptionsListUtils.ts

melvin-bot · 2024-03-27T11:13:39Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

filip-solecki · 2024-03-29T08:03:37Z

@Santhosh-Sellavel kind bump here :)

s77rt · 2024-03-29T17:25:21Z

Taking this as C+ from @Santhosh-Sellavel. I will review

s77rt

Partial review

src/components/SelectionList/BaseListItem.tsx

src/pages/WorkspaceSwitcherPage.tsx

src/components/SelectionList/BaseSelectionList.tsx

s77rt · 2024-03-30T01:05:21Z

On report dropdown the selected item should be highlighted

s77rt · 2024-03-30T01:06:23Z

On report dropdown after pressing the arrow button many items are highlighted

s77rt · 2024-03-31T01:45:01Z

On report dropdown searching for a selected option should appear as selected

Screen.Recording.2024-03-31.at.2.44.04.AM.mov

s77rt · 2024-03-31T19:33:34Z

Group tooltips not showing everyone's tooltip
PR:

Staging:

s77rt · 2024-03-31T19:43:49Z

If isLoadingNewOptions is true then we should not show the not found message (similar to OptionsSelector)

src/libs/OptionsListUtils.ts

src/pages/settings/AboutPage/ShareLogList/BaseShareLogList.tsx

s77rt · 2024-03-31T19:29:02Z

src/pages/WorkspaceSwitcherPage.tsx

-                        // @ts-expect-error TODO: remove this comment once OptionsSelector (https://github.com/Expensify/App/issues/25125) is migrated to TS
-                        placeholder={translate('workspace.switcher.placeholder')}
-                        ref={inputCallbackRef}
+                    <SelectionList


There is still a everythingSection that is using OptionRow. Can we move it to the passed sections in SelectionList

Hmm, it needs a huge refactor of the whole page, not sure if this is the right issue to do it. Btw. OptionRow is also used in some other components and I don't know of we want to remove it with OptionsSelector

src/pages/settings/AboutPage/ShareLogList/BaseShareLogList.tsx

src/components/SelectionList/types.ts

filip-solecki · 2024-04-02T11:14:39Z

On report dropdown the selected item should be highlighted

This behvior is consistent with staging, but I can change it if we want to

filip-solecki · 2024-04-02T12:53:02Z

On report dropdown after pressing the arrow button many items are highlighted

This is global SelectionList issue, not sure if it should be covered by this PR

filip-solecki · 2024-04-02T13:03:11Z

Group tooltips not showing everyone's tooltip PR:

Staging:

Is it supported somewhere in SelectionList? I can't find any place, so maybe it should be done as a follow-up to extend SelectionList possibilities

filip-solecki · 2024-04-04T07:34:17Z

@s77rt All done! Left one thought

filip-solecki · 2024-04-04T10:44:27Z

@s77rt Ready for re-review!

s77rt · 2024-04-04T19:30:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-04-04T19:31:26Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #25125 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

danieldoglas

Lots of changes going on on this PR. I would recommend we do 1 page per PR next time. Thanks @s77rt for the tests.

danieldoglas · 2024-04-05T11:59:30Z

I think this PR introduced this error. It happens both on Share logs and when you click on the workspace switcher.
#39696 (review)

danieldoglas · 2024-04-05T12:06:20Z

I'm reverting this PR so we can fix the error log that is happening before we merge it again. I recommend we do it step by step this time.

We've checked the [] Verify that no errors appear in the JS console item in the check list, but it was actually logging new errors.

s77rt · 2024-04-05T12:35:49Z

src/components/SelectionList/BaseListItem.tsx

                            </View>
                        </View>
                    )}
+                    {!item.isSelected && item.brickRoadIndicator && (


{!item.isSelected && !!item.brickRoadIndicator && (

s77rt · 2024-04-05T12:37:21Z

src/components/SelectionList/BaseSelectionList.tsx

+
+                        {/* If we are loading new options we will avoid showing any header message. This is mostly because one of the header messages says there are no options. */}
+                        {/* This is misleading because we might be in the process of loading fresh options from the server. */}
+                        {!isLoadingNewOptions && headerMessage && (


{!isLoadingNewOptions && !!headerMessage && (

Adding !isLoadingNewOptions here caused infinite loading when it should have been displaying the user is already a member of workspace message (#42219) we fixed this in #42569

s77rt · 2024-04-05T12:42:26Z

@danieldoglas Sorry I missed that. I added required change. cc @filip-solecki

s77rt · 2024-04-05T12:43:41Z

As for the duplicated variable I don't think we could have prevented that as it's a post-merge error

filip-solecki · 2024-04-05T13:04:30Z

I've prepared draft PR with fix, not sure if we should prepare these pages as separated PRs right now, we can do it with the rest of pages I think. I am checking new branch on all devices, I'll let you know @s77rt when it is ready for you!

OSBotify · 2024-04-08T11:08:35Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.4.61-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-08T13:05:13Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.4.61-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-10T17:22:50Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.61-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

filip-solecki added 3 commits March 26, 2024 12:24

Replace OptionsSelector with SelectionList

daeb721

Merge branch 'main' into filip-solecki/remove-options-selector-1

8c372c5

Fix lint

966d18e

blazejkustra approved these changes Mar 26, 2024

View reviewed changes

src/components/SelectionList/BaseListItem.tsx Outdated Show resolved Hide resolved

src/libs/OptionsListUtils.ts Outdated Show resolved Hide resolved

filip-solecki added 5 commits March 26, 2024 21:28

Fix failing tests

5849045

CR fixes

908363b

Merge branch 'main' into filip-solecki/remove-options-selector-1

46bcacc

Merge fix

df13200

Fix isSelected state in EditReportFieldDropdownPage

8c0297b

filip-solecki changed the title ~~Replace OptionsSelector with SelectionList~~ Replace OptionsSelector with SelectionList - part 1 Mar 27, 2024

filip-solecki marked this pull request as ready for review March 27, 2024 11:13

filip-solecki requested a review from a team as a code owner March 27, 2024 11:13

melvin-bot bot removed the request for review from a team March 27, 2024 11:13

melvin-bot bot requested a review from Santhosh-Sellavel March 27, 2024 11:13

s77rt suggested changes Mar 30, 2024

View reviewed changes

s77rt suggested changes Apr 1, 2024

View reviewed changes

filip-solecki added 2 commits April 2, 2024 12:43

review fixes

50bc061

Remove autofocus

b55a085

Fix isSelected state for dropdown

c8a23e4

filip-solecki added 2 commits April 4, 2024 09:12

Merge branch 'main' into filip-solecki/remove-options-selector-1

aaeaa22

Remove autoFocus on WorkspaceSwitcher

f044d83

revert unnecessary change

3c3e295

brunovjk mentioned this pull request Apr 4, 2024

[HOLD component refactoring] [$500] [LOW] Green circular loading does not appear when searching for a contact in request money flow #37144

Closed

6 tasks

s77rt approved these changes Apr 4, 2024

View reviewed changes

melvin-bot bot requested a review from danieldoglas April 4, 2024 19:47

danieldoglas approved these changes Apr 5, 2024

View reviewed changes

danieldoglas merged commit 707b8cd into Expensify:main Apr 5, 2024

This was referenced Apr 5, 2024

Investigate workflow job failing on main: lint / Run ESLint #39693

Closed

Investigate workflow job failing on main: test / test (job 3) #39694

Closed

danieldoglas mentioned this pull request Apr 5, 2024

Revert "Replace OptionsSelector with SelectionList - part 1" #39702

Merged

50 tasks

s77rt reviewed Apr 5, 2024

View reviewed changes

filip-solecki mentioned this pull request Apr 5, 2024

Replace OptionsSelector with SelectionList part 1 #39711

Merged

50 tasks

github-actions bot mentioned this pull request Apr 8, 2024

Deploy Checklist: New Expensify 2024-04-08 #39807

Closed

This was referenced Apr 12, 2024

Deploy Checklist: New Expensify 2024-04-08 #39807 Derevyaa/Expensify-App#1

Closed

Deploy Checklist: New Expensify 2024-04-09 #39808 Derevyaa/Expensify-App#2

Closed

Ollyws mentioned this pull request Jun 13, 2024

[HOLD for payment 2024-06-11] [$250] Workspace - User is already a member of the Workspace message is missing #42219

Closed

6 tasks

Conversation

filip-solecki commented Mar 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

blazejkustra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

melvin-bot bot commented Mar 27, 2024

Uh oh!

filip-solecki commented Mar 29, 2024

Uh oh!

s77rt commented Mar 29, 2024

Uh oh!

s77rt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

s77rt commented Mar 30, 2024

Uh oh!

s77rt commented Mar 30, 2024

Uh oh!

s77rt commented Mar 31, 2024

Uh oh!

s77rt commented Mar 31, 2024

Uh oh!

s77rt commented Mar 31, 2024

Uh oh!

Uh oh!

Uh oh!

s77rt Mar 31, 2024

Choose a reason for hiding this comment

Uh oh!

filip-solecki Apr 2, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

filip-solecki commented Apr 2, 2024

Uh oh!

filip-solecki commented Apr 2, 2024

Uh oh!

filip-solecki commented Apr 2, 2024

Uh oh!

filip-solecki commented Apr 4, 2024

Uh oh!

filip-solecki commented Apr 4, 2024

Uh oh!

s77rt commented Apr 4, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 4, 2024

Uh oh!

danieldoglas left a comment

Choose a reason for hiding this comment

Uh oh!

danieldoglas commented Apr 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danieldoglas commented Apr 5, 2024

Uh oh!

s77rt Apr 5, 2024

Choose a reason for hiding this comment

Uh oh!

s77rt Apr 5, 2024

filip-solecki commented Mar 26, 2024 •

edited

Loading

danieldoglas commented Apr 5, 2024 •

edited

Loading

Ollyws Jun 13, 2024 •

edited

Loading