Replaces usage of reimburserEmail with achAccount.reimburser by rlinoz · Pull Request #39017 · Expensify/App

rlinoz · 2024-03-26T20:52:16Z

~~HOLD on #38395~~
~~HOLD on https://github.com/Expensify/Auth/pull/10349~~

Details

cc: @luacmartins if you have the time to check this changes

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/374749
$ #39423
PROPOSAL:

Tests

Preconditions: Having a policy with VBA and some admins

Happy path:

Open Settings > Workspaces > > Workflows
See that you have an authorized payer
Click on the authorized payer and change it to a different one
Now, change it to one that has a display name set and check that the display name is shown under authorized payer

Error

Open Settings > Workspaces > > Workflows
See that you have an authorized payer
Go offline and change the authorized payer
In a different tab/browser demote the authorized payer from step 3 to a member
Go back to the offline tab and get back online, the authorized payer should get reverted to the previous one and there should be a red dot next to it indicating that it could not update

Verify that no errors appear in the JS console

Offline tests

Open Settings > Workspaces > > Workflows
See that you have an authorized payer
Go offline
Click on the authorized payer and change it to a different one
Go back online and see that it got updated

QA Steps

Preconditions: Having a policy with VBA and some admins

Happy path:

Open Settings > Workspaces > > Workflows
See that you have an authorized payer
Click on the authorized payer and change it to a different one
Now, change it to one that has a display name set and check that the display name is shown under authorized payer

Error

Open Settings > Workspaces > > Workflows
See that you have an authorized payer
Go offline and change the authorized payer
In a different tab/browser demote the authorized payer from step 3 to a member
Go back to the offline tab and get back online, the authorized payer should get reverted to the previous one and there should be a red dot next to it indicating that it could not update

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Error

Screen.Recording.2024-03-28.at.12.00.58.mov

Online

Screen.Recording.2024-03-28.at.11.59.40.mov

Offline

Screen.Recording.2024-03-28.at.11.59.54.mov

MacOS: Desktop

…moving reimburserAccountID

…m-achAcconut

…r-from-achAcconut

…eimburser-from-achAcconut

melvin-bot · 2024-03-28T15:06:57Z

@aldo-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/actions/Policy.ts

src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

luacmartins

LGTM

luacmartins · 2024-04-01T20:12:42Z

Are we already sending the new reimburser key to App? If not, can we put a hold on this PR?

rlinoz · 2024-04-01T20:17:10Z

We are, we started doing that here

luacmartins · 2024-04-02T16:16:02Z

Cool, seems like that Auth PR is merged so we should be good to merge this one too.

luacmartins · 2024-04-02T16:34:41Z

Created this external issue to get C+ assigned for review

src/libs/actions/Policy.ts

src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

src/pages/workspace/workflows/WorkspaceWorkflowsPayerPage.tsx

s77rt · 2024-04-02T22:53:13Z

Can you please merge main? I'm stuck at the update prompt

rlinoz · 2024-04-03T12:22:06Z

@s77rt merged main and applied the requested changes

s77rt · 2024-04-03T19:31:57Z

The other admin account appears as Hidden (don't have their email) thus I can't set them as the authorized payer

Screen.Recording.2024-04-03.at.8.30.54.PM.mov

rlinoz · 2024-04-03T19:54:42Z

This is weird, does the same happen if you open the members page?

s77rt · 2024-04-03T19:55:37Z

I had to send a message to other admin to get their info correctly

s77rt · 2024-04-03T19:56:12Z

This is weird, does the same happen if you open the members page?

I didn't. get a chance to test that as now I already got the info

s77rt · 2024-04-03T20:05:16Z

On demoting the other admin I got another behaviour but I think it's okay

Screen.Recording.2024-04-03.at.9.01.50.PM.mov

s77rt · 2024-04-03T20:16:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

web.2.mov

MacOS: Desktop

desktop.mov

rlinoz · 2024-04-03T20:17:11Z

Did you demote the admin that was making the changes? If so yeah, I think that is expected

s77rt

Approving assuming this is not a blocker #39017 (comment)

melvin-bot · 2024-04-03T20:19:16Z

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-04-03T20:19:19Z

🎯 @s77rt, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #39551.

OSBotify · 2024-04-03T22:32:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-08T10:55:38Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

alitoshmatov · 2026-02-13T03:01:08Z

src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

-        const displayNameFromReimburserEmail = PersonalDetailsUtils.getPersonalDetailByEmail(policy?.reimburserEmail ?? '')?.displayName ?? policy?.reimburserEmail;
-        return displayNameFromReimburserEmail ?? personalDetails?.[0]?.displayName;
-    }, [policy?.reimburserAccountID, policy?.reimburserEmail, session?.accountID]);
+    const displayNameForAuthorizedPayer = useMemo(


This was showing sms suffix when user registered with number, more: #78762

replaceing usage of reimburserEamil with achAccount.reimburser and re…

5ccc7fa

…moving reimburserAccountID

rlinoz self-assigned this Mar 26, 2024

rlinoz added 11 commits March 26, 2024 18:02

Merge remote-tracking branch 'origin' into rodrigo-use-reimburser-fro…

eab4a5d

…m-achAcconut

prettier

a6a4270

Merge remote-tracking branch 'origin/main' into rodrigo-use-reimburse…

282b53e

…r-from-achAcconut

Fixing typecheck

3d3089e

Merge remote-tracking branch 'origin/nat-workflow' into rodrigo-use-r…

eb33556

…eimburser-from-achAcconut

removing unused variable

a313428

removing unused sesseion.accountID from hooks

dace40b

fixing lint

654469c

fixing lint

2720c98

removing one last use of session

f7c2a55

merge main

17918f9

rlinoz marked this pull request as ready for review March 28, 2024 15:06

rlinoz requested a review from a team as a code owner March 28, 2024 15:06

melvin-bot bot removed the request for review from a team March 28, 2024 15:06

melvin-bot bot requested a review from aldo-expensify March 28, 2024 15:06

luacmartins self-requested a review March 28, 2024 21:55

luacmartins requested changes Apr 1, 2024

View reviewed changes

src/libs/actions/Policy.ts Outdated Show resolved Hide resolved

src/libs/actions/Policy.ts Outdated Show resolved Hide resolved

src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx Outdated Show resolved Hide resolved

Renaming collection keys contant from reimburserEmail to reimburser

312acc7

rlinoz requested a review from luacmartins April 1, 2024 19:42

luacmartins previously approved these changes Apr 1, 2024

View reviewed changes

luacmartins requested a review from s77rt April 2, 2024 16:34

s77rt suggested changes Apr 2, 2024

View reviewed changes

src/libs/actions/Policy.ts Outdated Show resolved Hide resolved

src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx Outdated Show resolved Hide resolved

src/pages/workspace/workflows/WorkspaceWorkflowsPayerPage.tsx Outdated Show resolved Hide resolved

better handling for reimburser failure

522a7e8

rlinoz requested review from luacmartins and s77rt April 3, 2024 12:22

luacmartins previously approved these changes Apr 3, 2024

View reviewed changes

merge main

951bcc6

rlinoz dismissed luacmartins’s stale review via 951bcc6 April 3, 2024 19:57

s77rt approved these changes Apr 3, 2024

View reviewed changes

melvin-bot bot requested a review from cristipaval April 3, 2024 20:19

melvin-bot bot mentioned this pull request Apr 3, 2024

Payment issue for E/App PR#39017 #39551

Closed

luacmartins approved these changes Apr 3, 2024

View reviewed changes

luacmartins merged commit 3385a1f into main Apr 3, 2024

luacmartins deleted the rodrigo-use-reimburser-from-achAcconut branch April 3, 2024 22:26

github-actions bot mentioned this pull request Apr 4, 2024

[INCORRECT] (used to be a checklist but was incorrectly triggered) #39573

Closed

44 tasks

mountiny mentioned this pull request Apr 4, 2024

Deploy Checklist: New Expensify 2024-04-04 #39588

Closed

48 tasks

melvin-bot bot mentioned this pull request Apr 8, 2024

[HOLD for payment 2024-04-15] Return the approverAccountID and reimburserAccountID to Onyx #39423

Closed

This was referenced Apr 10, 2024

[HOLD for payment 2024-06-06] [$500] [Workflows] Bank account and Authorized payer buttons displayed instead of Connect bank account #39947

Closed

Bank account and Authorized payer buttons displayed instead of Connect bank account #40182

Merged

alitoshmatov reviewed Feb 13, 2026

View reviewed changes

Conversation

rlinoz commented Mar 26, 2024 • edited by luacmartins Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 28, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Apr 1, 2024

Uh oh!

rlinoz commented Apr 1, 2024

Uh oh!

luacmartins commented Apr 2, 2024

Uh oh!

luacmartins commented Apr 2, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

s77rt commented Apr 2, 2024

Uh oh!

rlinoz commented Apr 3, 2024

Uh oh!

s77rt commented Apr 3, 2024

Uh oh!

rlinoz commented Apr 3, 2024

Uh oh!

s77rt commented Apr 3, 2024

Uh oh!

s77rt commented Apr 3, 2024

Uh oh!

s77rt commented Apr 3, 2024

Uh oh!

s77rt commented Apr 3, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

rlinoz commented Apr 3, 2024

Uh oh!

s77rt left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Apr 3, 2024

Uh oh!

melvin-bot bot commented Apr 3, 2024

Uh oh!

OSBotify commented Apr 3, 2024

Uh oh!

OSBotify commented Apr 8, 2024

Uh oh!

alitoshmatov Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rlinoz commented Mar 26, 2024 •

edited by luacmartins

Loading