-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Integrate adminAccountID of a report action #39042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marcochavezf
merged 12 commits into
Expensify:main
from
rezkiy37:fix/35263-owner-submission-message-2
Apr 11, 2024
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
46e87ba
integrate getReportActionActorAccountID
rezkiy37 a32fa4b
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…
rezkiy37 4f15599
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…
rezkiy37 9a13109
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…
rezkiy37 8c2ac0d
pass adminAccountID to ReportActionItem
rezkiy37 ade097f
fix group message splitting
rezkiy37 177ff35
set adminAccountID to optimistic submit
rezkiy37 d9de8eb
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…
rezkiy37 cc0e644
rename isReportActionSubmitted
rezkiy37 fe220cb
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…
rezkiy37 d28d19b
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…
rezkiy37 caeb346
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…
rezkiy37 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rezkiy37 Why do we not check if typeof currentActionAdminAccountID is number, just like we do below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, good question. Looks like this condition can be added here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!