Export main page - initial#39191
Merged
hayata-suenaga merged 45 commits intoExpensify:mainfrom Apr 22, 2024
narefyev91:qbo-export-pages
Merged
Export main page - initial#39191hayata-suenaga merged 45 commits intoExpensify:mainfrom narefyev91:qbo-export-pages
hayata-suenaga merged 45 commits intoExpensify:mainfrom
narefyev91:qbo-export-pages
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Export main pages for QBO
Fixed Issues
$ #37780
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-web.mov
iOS: Native
Screen.Recording.2024-04-19.at.20.30.26.mov
iOS: mWeb Safari
Screen.Recording.2024-04-17.at.16.59.37.mov
MacOS: Chrome / Safari
Screen.Recording.2024-04-17.at.16.49.03.mov
MacOS: Desktop
Screen.Recording.2024-04-17.at.17.07.43.mov