fix: move "Troubleshoot" out of About by tienifr · Pull Request #39230 · Expensify/App

tienifr · 2024-03-29T10:27:23Z

Details

Fixed Issues

$ #38594
PROPOSAL: #38594 (comment)

Tests

Open setting page
Verify that the "Troubleshoot" option is right above the Sign Out option at the bottom.
Click on "Troubleshoot" option
Verify that all features belonging to "Troubleshoot" work well.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open setting page
Verify that the "Troubleshoot" option is right above the Sign Out option at the bottom.
Click on "Troubleshoot" option
Verify that all features belonging to "Troubleshoot" work well.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-29.at.18.28.10.mov

Android: mWeb Chrome

Screen.Recording.2024-03-29.at.18.30.36.mov

iOS: Native

Screen.Recording.2024-04-01.at.14.40.37.mov

iOS: mWeb Safari

Screen.Recording.2024-03-29.at.18.32.18.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-29.at.18.15.02.mov

MacOS: Desktop

Screen.Recording.2024-03-29.at.18.22.17.mov

melvin-bot · 2024-04-01T04:46:12Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2024-04-01T04:52:05Z

@danieldoglas In main branch, the text is "Test Preferences". In new design, we use "Testing Preferences". What should we use?

danieldoglas · 2024-04-01T10:41:50Z

@tienifr please use the text from the new design

tienifr · 2024-04-02T04:38:48Z

I just asked for the translations in slack. Once all the translations are added, you can review PR @alitoshmatov

tienifr · 2024-04-03T00:12:05Z

@danieldoglas Can you help check this slack thread?

tienifr · 2024-04-03T08:14:53Z

@alitoshmatov I think you can review this PR while the internal team fulfills the translations

shawnborton · 2024-04-03T10:25:42Z

The hovered row here should be going full width of the card:

tienifr · 2024-04-03T10:32:04Z

@alitoshmatov All translations are added

tienifr · 2024-04-04T10:33:22Z

@shawnborton I fixed comment

alitoshmatov · 2024-04-04T10:45:52Z

@tienifr subtitle styles are not matching. Also, I think the alignment is a bit off, I think it should match subtitles in other pages, for example about page.

alitoshmatov · 2024-04-04T10:48:43Z

Also alignment of clear cache and restart menu item is off. Here also I think it should match styles in about page which also has similar menu items

PR:

Design:

shawnborton · 2024-04-04T12:28:11Z

Hmm I think the Design might actually be off in this case, just slightly.

As long as this matches other rows in cards in Account Settings like these:

Then we're good to go.

shawnborton · 2024-04-04T12:28:59Z

subtitle styles are not matching

Good catch on this, let's fix. Again, take a look at the other places in Settings like Security and About for inspiration on correct implementation.

tienifr · 2024-04-05T08:29:01Z

I fix two issues you mentioned:

subtitle styles are not matching

alignment of clear cache and restart menu item is off

Below is the result:

Design	PR

dannymcclain · 2024-04-05T13:23:13Z

This is looking pretty good. I think the illustration in the header needs to be a bit bigger and centered:

And I ran into some weirdness with the nav on smaller viewports. Maybe that's unrelated to this, I'm not sure, so I thought I'd call it out:

Random nav item is "active" even though nothing should be active
Screens sometime animate in/out from the wrong side

CleanShot.2024-04-05.at.08.19.35.mp4

tienifr · 2024-04-08T10:08:38Z

Not the lightbulb, but the animated lottie illustration in the card header area.

Oh sorry. I misunderstood @dannymcclain 's thought

Do we have any ability to increase the size of the inner lottie illustration or do we need to supply a new lottie file for that?

We can increase the size of the inner lottie by update these props, but I think it will be better if we supply a new lottie file

shawnborton · 2024-04-08T12:30:19Z

Cool, I think we might be fine if we just do my suggestion above here - can you please try that and report back? Thanks!

tienifr · 2024-04-09T11:16:36Z

@shawnborton I fixed the issue "the illustration in the header needs to be centered". Below is result:

tienifr · 2024-04-09T11:23:00Z

@shawnborton I just merged main, and there is a new option, named "Save the world". So what is the correct order when displaying these options? Currently this PR, is:

shawnborton · 2024-04-09T11:24:37Z

Currently this PR, is:

That order looks good to me.

shawnborton · 2024-04-09T11:25:09Z

I fixed the issue "the illustration in the header needs to be centered". Below is result:

This also looks good to me! I'd say we're ready for final review then. Thanks for the adjustments!

shawnborton · 2024-04-09T11:36:19Z

src/components/Section/index.tsx

-                        <Text style={[styles.textNormal, subtitleMuted && styles.colorMuted]}>{subtitle}</Text>
-                    </View>
-                )}
+                {renderSubtitle


What exactly does this do?

It will style the text "Use the tools ... submit a bug"

Got it. Did you test the submit a bug link? It doesn't work for me.

Yes. I tested and It works well:

Screen.Recording.2024-04-09.at.18.50.59.mov

Got it, thanks for confirming.

github-actions · 2024-04-09T11:46:24Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/39230/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/39230/NewExpensify.dmg	https://39230.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2024-04-09T11:48:37Z

Looks like the header height is incorrect:

It should be 220px

tienifr · 2024-04-09T12:15:31Z

@shawnborton I fixed this. Result:

shawnborton · 2024-04-09T15:34:17Z

Thanks!

shawnborton · 2024-04-09T15:34:32Z

@alitoshmatov can you please give this a review? Thanks!

tienifr · 2024-04-12T09:27:55Z

@alitoshmatov Please help review PR once you have a chance

alitoshmatov · 2024-04-12T10:11:43Z

Reviewing

alitoshmatov · 2024-04-12T17:42:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

troubleshooting-android.mov

Android: mWeb Chrome

troubleshooting-mweb.mov

iOS: Native

troubleshooting-ios.mp4

iOS: mWeb Safari

troubleshooting-safari.mp4

MacOS: Chrome / Safari

troubleshooting-web.mov

MacOS: Desktop

troubleshooting-desktop.mov

alitoshmatov

Changes looks good

danieldoglas

LGTM

OSBotify · 2024-04-15T10:34:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-18T04:55:38Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.4.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-22T14:56:37Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

tienifr added 2 commits March 29, 2024 17:19

fix create troubleshoot page

388afe1

fix margin right issue

465db73

tienifr marked this pull request as ready for review April 1, 2024 04:46

tienifr requested a review from a team as a code owner April 1, 2024 04:46

melvin-bot bot requested review from alitoshmatov and removed request for a team April 1, 2024 04:46

fix conflict

97df206

tienifr requested a review from a team as a code owner April 3, 2024 07:32

tienifr added 2 commits April 3, 2024 14:35

fix remove unused file

3fe9d34

fix use ClientSideLoggingToolMenu

0b8743b

fix add translations

d8880fe

fix hover issue

19463f8

fix margin issue

3c86265

shawnborton added the Ready To Build label Apr 5, 2024

This comment has been minimized.

Sign in to view

fix illustration header

1f7e66a

tienifr and others added 2 commits April 9, 2024 18:18

Merge branch 'main' into fix/38594

1bde009

fix format

e7dda23

shawnborton reviewed Apr 9, 2024

View reviewed changes

fix header illustration height

b6e81ea

alitoshmatov approved these changes Apr 12, 2024

View reviewed changes

melvin-bot bot requested a review from danieldoglas April 12, 2024 17:43

tienifr added 2 commits April 15, 2024 15:10

fix merge main

ca43ee2

fix resolve conflict

e637775

danieldoglas approved these changes Apr 15, 2024

View reviewed changes

danieldoglas merged commit 2815cf2 into Expensify:main Apr 15, 2024

github-actions bot mentioned this pull request Apr 18, 2024

Deploy Checklist: New Expensify 2024-04-18 #40392

Closed

bernhardoj mentioned this pull request Jun 27, 2024

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [CRITICAL] [UX Reliability] [Navigation] Going back from the about page seems to be pushing the settings #44478

Closed

6 tasks

Conversation

tienifr commented Mar 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 1, 2024

Uh oh!

tienifr commented Apr 1, 2024

Uh oh!

danieldoglas commented Apr 1, 2024

Uh oh!

tienifr commented Apr 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tienifr commented Apr 3, 2024

Uh oh!

tienifr commented Apr 3, 2024

Uh oh!

shawnborton commented Apr 3, 2024

Uh oh!

tienifr commented Apr 3, 2024

Uh oh!

tienifr commented Apr 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alitoshmatov commented Apr 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alitoshmatov commented Apr 4, 2024

Uh oh!

shawnborton commented Apr 4, 2024

Uh oh!

shawnborton commented Apr 4, 2024

Uh oh!

tienifr commented Apr 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

dannymcclain commented Apr 5, 2024

Uh oh!

tienifr commented Apr 8, 2024

Uh oh!

shawnborton commented Apr 8, 2024

Uh oh!

tienifr commented Apr 9, 2024

Uh oh!

tienifr commented Apr 9, 2024

Uh oh!

shawnborton commented Apr 9, 2024

Uh oh!

shawnborton commented Apr 9, 2024

Uh oh!

shawnborton Apr 9, 2024

Choose a reason for hiding this comment

Uh oh!

tienifr Apr 9, 2024

Choose a reason for hiding this comment

Uh oh!

shawnborton Apr 9, 2024

Choose a reason for hiding this comment

Uh oh!

tienifr Apr 9, 2024

Choose a reason for hiding this comment

Uh oh!

shawnborton Apr 9, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 9, 2024

Uh oh!

shawnborton commented Apr 9, 2024

Uh oh!

tienifr commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tienifr commented Mar 29, 2024 •

edited

Loading

tienifr commented Apr 2, 2024 •

edited

Loading

tienifr commented Apr 4, 2024 •

edited

Loading

alitoshmatov commented Apr 4, 2024 •

edited

Loading

tienifr commented Apr 5, 2024 •

edited

Loading

tienifr commented Apr 9, 2024 •

edited

Loading