FIx group chat confirmation list is displayed with delay by bernhardoj · Pull Request #39364 · Expensify/App

bernhardoj · 2024-04-01T15:37:17Z

Details

The delay is because we set the opacity to 0 on initial render.

Fixed Issues

$ #39245
PROPOSAL: #39245 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Press FAB and select Start chat
Add multiple people to group selection
Press Next
Verify the list is displayed without delay on the confirmation page

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-01.at.23.02.42.mov

Android: mWeb Chrome

Screen.Recording.2024-04-01.at.23.04.09.mov

iOS: Native

Screen.Recording.2024-04-01.at.23.03.13.mov

iOS: mWeb Safari

Screen.Recording.2024-04-01.at.23.08.44.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-01.at.23.00.30.mov

MacOS: Desktop

Screen.Recording.2024-04-01.at.23.02.19.mov

melvin-bot · 2024-04-01T15:37:22Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2024-04-01T15:42:40Z

@Ollyws As you pointed out in the comment here, I also can't reproduce the blink. At first, I thought the issue isInitialSectionListRender is trying to fix is the little blank space as shown in the image below.

But with/without isInitialSectionListRender and shouldUseDynamicMaxToRenderPerBatch, that blank issue still happen. (idk though why yesterday it works fine with isInitialSectionListRender 🤷)

bernhardoj · 2024-04-01T15:43:17Z

Out of scope, I think the bottom spacing is too big on iOS.

Ollyws · 2024-04-03T10:12:09Z

@bernhardoj it does seem like on this PR the delay when displaying the currency selection is now alot longer:

Current.mov

Main.mov

bernhardoj · 2024-04-03T11:18:11Z

That's really weird.

Btw, I can see the "blink" now in this PR very briefly, the delay you and I see is most likely because the list scrolls to the target location and it's blank because not all items are rendered on the list.

Screen.Recording.2024-04-03.at.18.51.40.mov

Weirdly though, the set state here somehow makes it faster.

App/src/components/SelectionList/BaseSelectionList.tsx

Line 355 in 488664d

setIsInitialSectionListRender(false);

I can put any set state and it makes it faster. Pretty sure that is an unintentional positive(?) effect.

I think the safest way is to have a new prop (maybe call it shouldHideListOnInitialRender defaults to true and set to false for group confirmation page) to conditionally apply isInitialSectionListRender to set the opacity instead of fully removing it, wdyt?

Ollyws · 2024-04-03T11:20:50Z

I think the safest way is to have a new prop (maybe call it shouldHideListOnInitialRender defaults to true and set to false for group confirmation page) to conditionally apply isInitialSectionListRender to set the opacity instead of fully removing it, wdyt?

Sounds good to me!

bernhardoj · 2024-04-03T12:06:49Z

@Ollyws updated

Ollyws · 2024-04-03T14:19:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

01_Android_Native.mp4

Android: mWeb Chrome

02_Android_Chrome.mp4

iOS: Native

03_iOS_Native.mp4

iOS: mWeb Safari

04_iOS_Safari.mp4

MacOS: Chrome / Safari

05_MacOS_Chrome.mp4

MacOS: Desktop

06_MacOS_Desktop.mp4

Ollyws

LGTM.

tgolen · 2024-04-03T14:45:29Z

src/components/SelectionList/types.ts

    /** Ref for textInput */
    textInputRef?: MutableRefObject<TextInput | null>;
+
+    /** Whether to hide the list on initial render */


Please update this comment to explain a little bit more why someone using the prop would choose true or false.

Updated. Please check.

tgolen · 2024-04-03T15:36:01Z

src/components/SelectionList/types.ts

    /** Ref for textInput */
    textInputRef?: MutableRefObject<TextInput | null>;
+
+    /** Whether to hide the list on the initial render. This would prevent the list from "blinking" when you have a long list and it auto scrolls to the bottom on mount but will delay the showing of the list */


This is better thanks! Here is a suggestion that could improve it a little more:

When true, the list won't be visible until all items are rendered. This prevents the list from "blinking" as it's scrolled to the bottom which is recommended for large lists. When false, the list will render immediately and scroll to the bottom which works great for small lists.

Great. Updated with a little modification.

-When true, the list won't be visible until all items are rendered. +When true, the list won't be visible until the list layout is measured

because the isInitialSectionListRender is set to false in onLayout of the list

Love it, thanks!

OSBotify · 2024-04-03T16:41:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-08T10:57:35Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix list is not visible initially

4a2da6a

bernhardoj requested a review from a team as a code owner April 1, 2024 15:37

melvin-bot bot requested review from Ollyws and removed request for a team April 1, 2024 15:37

bernhardoj added 3 commits April 3, 2024 19:50

Merge branch 'main' into fix/39245-delayed-group-chat-confirmation-list

1a52448

add hide list on initial render back

dc672dc

control hide list on initial render with a prop

4ea37b6

prettier

4a25938

Ollyws approved these changes Apr 3, 2024

View reviewed changes

melvin-bot bot requested a review from tgolen April 3, 2024 14:20

tgolen requested changes Apr 3, 2024

View reviewed changes

update comment

416355e

tgolen requested changes Apr 3, 2024

View reviewed changes

update comment

f43af2a

tgolen previously approved these changes Apr 3, 2024

View reviewed changes

prettier

4860deb

bernhardoj dismissed tgolen’s stale review via 4860deb April 3, 2024 16:15

tgolen approved these changes Apr 3, 2024

View reviewed changes

tgolen merged commit 2b592a2 into Expensify:main Apr 3, 2024

github-actions bot mentioned this pull request Apr 4, 2024

[INCORRECT] (used to be a checklist but was incorrectly triggered) #39573

Closed

44 tasks

mountiny mentioned this pull request Apr 4, 2024

Deploy Checklist: New Expensify 2024-04-04 #39588

Closed

48 tasks

melvin-bot bot mentioned this pull request Apr 8, 2024

[HOLD for payment 2024-04-15] [$500] Group Chat - Selected contacts appear on the confirmation page with a delay #39245

Closed

6 tasks

Ollyws mentioned this pull request Apr 15, 2024

fix: move hiding only to the SectionList #33833

Merged

56 tasks

Conversation

bernhardoj commented Apr 1, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 1, 2024

Uh oh!

bernhardoj commented Apr 1, 2024

Uh oh!

bernhardoj commented Apr 1, 2024

Uh oh!

Ollyws commented Apr 3, 2024

Uh oh!

bernhardoj commented Apr 3, 2024

Uh oh!

Ollyws commented Apr 3, 2024

Uh oh!

bernhardoj commented Apr 3, 2024

Uh oh!

Ollyws commented Apr 3, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

Ollyws left a comment

Choose a reason for hiding this comment

Uh oh!

tgolen Apr 3, 2024

Choose a reason for hiding this comment

Uh oh!

bernhardoj Apr 3, 2024

Choose a reason for hiding this comment

Uh oh!

tgolen Apr 3, 2024

Choose a reason for hiding this comment

Uh oh!

bernhardoj Apr 3, 2024

Choose a reason for hiding this comment

Uh oh!

tgolen Apr 3, 2024

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 3, 2024

Uh oh!

OSBotify commented Apr 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants