fix scan expense report and transaction are not hidden by tienifr · Pull Request #39389 · Expensify/App

tienifr · 2024-04-02T08:00:44Z

Details

Fixed Issues

$ #37296
PROPOSAL: #37296 (comment)

Tests

Go to staging.new.expensify.com.
Go to workspace chat.
Create a scan request with an invalid receipt that will fail the scanning.
Wait for the request to fail.
Workspace expense report and transaction report will be hidden in LHN when the scanning fails. (production behavior)

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to staging.new.expensify.com.
Go to workspace chat.
Create a scan request with an invalid receipt that will fail the scanning.
Wait for the request to fail.
Workspace expense report and transaction report will be hidden in LHN when the scanning fails. (production behavior)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-02.at.15.16.11.mov

Android: mWeb Chrome

Screen.Recording.2024-04-02.at.15.20.53.mov

iOS: Native

Screen.Recording.2024-04-02.at.15.13.08.mov

iOS: mWeb Safari

Screen.Recording.2024-04-02.at.15.09.45.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-02.at.15.03.18.mov

MacOS: Desktop

Screen.Recording.2024-04-02.at.15.06.24.mov

melvin-bot · 2024-04-02T08:19:07Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2024-04-03T02:23:58Z

@DylanDylann Please help review PR once you have a chance

src/libs/SidebarUtils.ts

DylanDylann · 2024-04-05T06:42:16Z

@tienifr BUG: After scanning failed, clicking on the report preview, a report display on LHN with the title "Receipt missing detail"

Screen.Recording.2024-04-04.at.20.37.10.mov

tienifr · 2024-04-10T04:04:10Z

I am checking this

tienifr · 2024-04-10T07:51:50Z

@DylanDylann I fixed issue. Here is the result:

Screen.Recording.2024-04-10.at.14.50.23.mov

DylanDylann · 2024-04-11T13:30:56Z

src/libs/SidebarUtils.ts

        const hasBrickError = hasErrors || doesReportHaveViolations ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : '';
-        const shouldOverrideHidden = hasBrickError || isFocused || report.isPinned;
+        const hasErrorsOtherThanFailedReceipt = doesReportHaveViolations || Object.values(allReportErrors).some((error) => error?.[0] !== 'report.genericSmartscanFailureMessage');
+        const shouldOverrideHidden = (hasBrickError && hasErrorsOtherThanFailedReceipt) || isFocused || report.isPinned;


@tienifr I think hasBrickError is redundant

@DylanDylann You are correct. I just removed hasBrickError

DylanDylann · 2024-04-12T08:09:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-12.at.15.08.24.mov

Android: mWeb Chrome

Screen.Recording.2024-04-12.at.14.59.30.mov

iOS: Native

Screen.Recording.2024-04-12.at.15.08.47.mov

iOS: mWeb Safari

Uploading Screen Recording 2024-04-12 at 14.54.51.mov…

MacOS: Chrome / Safari

Screen.Recording.2024-04-12.at.14.53.20.mov

MacOS: Desktop

Screen.Recording.2024-04-12.at.15.02.18.mp4

OSBotify · 2024-04-12T09:54:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-18T04:55:50Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.4.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-22T14:56:49Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix scan expense report and transaction are not hidden

e86e35e

tienifr marked this pull request as ready for review April 2, 2024 08:19

tienifr requested a review from a team as a code owner April 2, 2024 08:19

melvin-bot bot requested review from DylanDylann and removed request for a team April 2, 2024 08:19

DylanDylann reviewed Apr 3, 2024

View reviewed changes

src/libs/SidebarUtils.ts Outdated Show resolved Hide resolved

tienifr added 3 commits April 3, 2024 15:27

fix merge main

c8a42c7

fix update hasNonFailedReceiptError variable

cc63fee

fix remove redundant line break

20acf25

DylanDylann reviewed Apr 4, 2024

View reviewed changes

src/libs/SidebarUtils.ts Outdated Show resolved Hide resolved

tienifr added 2 commits April 4, 2024 14:11

fix rename variable

5784171

fix lint

890efed

tienifr added 2 commits April 8, 2024 14:53

fix merge main

1492725

fix merge main

852f950

tienifr added 2 commits April 10, 2024 13:26

fix merge main

54f5c1f

fix expense report is not hidden

1a13943

fix update hasErrorsOtherThanFailedReceipt

1c17d75

DylanDylann reviewed Apr 11, 2024

View reviewed changes

tienifr added 3 commits April 11, 2024 20:56

fix remove hasBrickError

7d02b90

fix lint

f987438

fix merge main

276fd22

DylanDylann approved these changes Apr 12, 2024

View reviewed changes

melvin-bot bot requested a review from danieldoglas April 12, 2024 08:20

danieldoglas approved these changes Apr 12, 2024

View reviewed changes

danieldoglas merged commit fb3e111 into Expensify:main Apr 12, 2024

github-actions bot mentioned this pull request Apr 18, 2024

Deploy Checklist: New Expensify 2024-04-18 #40392

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix scan expense report and transaction are not hidden#39389

fix scan expense report and transaction are not hidden#39389
danieldoglas merged 14 commits intoExpensify:mainfrom
tienifr:fix/37296

tienifr commented Apr 2, 2024 •

edited

Loading

Uh oh!

melvin-bot bot commented Apr 2, 2024

Uh oh!

tienifr commented Apr 3, 2024

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented Apr 5, 2024

Uh oh!

tienifr commented Apr 10, 2024 •

edited

Loading

Uh oh!

tienifr commented Apr 10, 2024

Uh oh!

DylanDylann Apr 11, 2024

Uh oh!

tienifr Apr 11, 2024

Uh oh!

DylanDylann commented Apr 12, 2024 •

edited

Loading

Uh oh!

OSBotify commented Apr 12, 2024

Uh oh!

OSBotify commented Apr 18, 2024

Uh oh!

OSBotify commented Apr 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

tienifr commented Apr 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 2, 2024

Uh oh!

tienifr commented Apr 3, 2024

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented Apr 5, 2024

Uh oh!

tienifr commented Apr 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tienifr commented Apr 10, 2024

Uh oh!

DylanDylann Apr 11, 2024

Choose a reason for hiding this comment

Uh oh!

tienifr Apr 11, 2024

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Apr 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Apr 12, 2024

Uh oh!

OSBotify commented Apr 18, 2024

Uh oh!

OSBotify commented Apr 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tienifr commented Apr 2, 2024 •

edited

Loading

tienifr commented Apr 10, 2024 •

edited

Loading

DylanDylann commented Apr 12, 2024 •

edited

Loading