fix: Fix playing Shutter Sound in Scan Receipt by mrousavy · Pull Request #39400 · Expensify/App

mrousavy · 2024-04-02T11:13:22Z

Details

Fixes playing shutter sound in scan receipt page when:

..sound is explicitly disabled in app settings (Android + iOS)
..phone is on silent/vibrate ringer mode (Android)

Fixed Issues

$ #39241
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Toggle sound mode in app preferences (try on/off) or toggle phone's vibrate/silent mode
Go to some report
Click on the "+" icon in the composer
Select "Request money"
In the "Scan" tab, take a photo
If sound is enabled (in both app and phone), make sure there is a sound. If not, make sure there isn't

Offline tests

None needed.

QA Steps

Verify that no errors appear in the JS console

Same as in Tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Screen_Recording_20240403_161420_New_Expensify_Dev.mp4

Screen_Recording_20240403_161452_New_Expensify_Dev.mp4

Android: mWeb Chrome

iOS: Native

RPReplay_Final1712153932.mov

RPReplay_Final1712153897.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Only provided screen captures for iOS and Android. Web not affected

…ilent

…tings

melvin-bot · 2024-04-02T11:13:27Z

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mrousavy · 2024-04-02T11:14:12Z

src/pages/iou/request/step/IOURequestStepScan/index.native.js

    const device = useCameraDevice('back', {
        physicalDevices: ['wide-angle-camera'],
    });
+    const [user] = useOnyx(ONYXKEYS.USER)


should I use a selector for only isMutedAllSounds here, or is this fine?

I dont think we can use useOnyx yet, please use selector

How would that look like then? Onyx.connect(...)?

@mountiny what is the reason we shouldn't use `useOnyx yet?

mountiny

@ntdiary Will you be able to review this one quickly?

mountiny · 2024-04-02T11:22:39Z

src/pages/iou/request/step/IOURequestStepScan/index.native.js

    const device = useCameraDevice('back', {
        physicalDevices: ['wide-angle-camera'],
    });
+    const [user] = useOnyx(ONYXKEYS.USER)


I dont think we can use useOnyx yet, please use selector

c3024 · 2024-04-02T14:03:44Z

src/pages/iou/request/step/IOURequestStepScan/index.native.js

 import * as IOU from '@userActions/IOU';
 import CONST from '@src/CONST';
 import ROUTES from '@src/ROUTES';
+import Onyx, {useOnyx} from 'react-native-onyx';


Suggested change

import Onyx, {useOnyx} from 'react-native-onyx';

import {withOnyx} from 'react-native-onyx';

c3024 · 2024-04-02T14:04:00Z

src/pages/iou/request/step/IOURequestStepScan/index.native.js

    const device = useCameraDevice('back', {
        physicalDevices: ['wide-angle-camera'],
    });
+    const [user] = useOnyx(ONYXKEYS.USER)


Suggested change

const [user] = useOnyx(ONYXKEYS.USER)

c3024

    transaction: {isFromGlobalCreate},
    user

at

App/src/pages/iou/request/step/IOURequestStepScan/index.native.js

Line 61 in d7a50d4

transaction: {isFromGlobalCreate},

export default compose(withWritableReportOrNotFound, withFullTransactionOrNotFound, withOnyx({
    user: {
        key: ONYXKEYS.USER,
    }
}))(IOURequestStepScan);

at

App/src/pages/iou/request/step/IOURequestStepScan/index.native.js

Line 389 in d7a50d4

    
           export default compose(withWritableReportOrNotFound, withFullTransactionOrNotFound)(IOURequestStepScan);

c3024 · 2024-04-02T14:27:49Z

    report: {},
    transaction: {},
    user: {}

App/src/pages/iou/request/step/IOURequestStepScan/index.native.js

Lines 52 to 53 in d7a50d4

    
           report: {}, 
        
           transaction: {},

c3024 · 2024-04-02T15:50:18Z

There is shutter sound even when enableShutterSound is false on android. 🤔 💭

mrousavy · 2024-04-02T15:51:31Z

@c3024 are you by any chance in Japan?

Maybe the MediaActionSound.mustPlayShutterSound() method returns true?

c3024 · 2024-04-02T16:48:49Z

No, I am in India. The phone is a Xiaomi. The camera app of the device has an option to disable shutter sound. Disabling it disables the shutter sound in the camera app. So, I think this might not be happening due to regional restrictions.

But shutter sound plays when sounds are muted in settings in New Expensify app.

mrousavy · 2024-04-02T17:14:30Z

Can you check your adb logcat logs?

Look for something like:

This phone must play a shutter sound due to regional restrictions, enabling shutter sound...

See mrousavy/react-native-vision-camera@86c0f86

c3024 · 2024-04-03T05:00:34Z

Yes, that was logged.

Looks like other apps are not obeying the regional restrictions. WhatsApp plays no shutter sound and the phone default camera app has a setting to disable shutter sound.

mrousavy · 2024-04-03T06:18:53Z

Well I guess then I'll just remove that check, seems to be ignored?
I'll push another update later today then.

chrispader · 2024-04-03T14:36:28Z

@ntdiary @c3024 could you please give this PR another review? :)

mrousavy · 2024-04-03T14:39:46Z

Not sure how to proceed with the mustPlayShutterSound() - per documentation it is a regional restriction (often a law, eg Japan) to play a shutter sound when this value is true.

I can of course take it out, it probably won't cause any trouble. Just need to know

chrispader · 2024-04-03T15:11:08Z

@c3024 as @mrousavy wrote, we'll remove the check for mustPlayShutterSound() so pls either wait until we updated the react-native-vision-camera version or ignore this until we changed it

c3024 · 2024-04-04T07:46:03Z

@mountiny I see many apps disregard this requirement. I think we can remove that check.

Could you confirm this?

mrousavy · 2024-04-04T09:37:09Z

Released 4.0.0-beta.13 that doesn't use mustPlayShutterSound() anymore 👍

@chrispader can you update the version in E/App?

chrispader · 2024-04-04T09:41:08Z

@c3024 @ntdiary updated react-native-vision-camera, so hopefully all problems should be resolved now. Lmk if there is anything else to address in this PR

src/pages/iou/request/step/IOURequestStepScan/index.native.js

c3024 · 2024-04-04T10:00:38Z

src/pages/iou/request/step/IOURequestStepScan/index.native.js


+    /** Information about the logged in user's account */
+    user: PropTypes.shape({
+        /** Whether or not the user is on a public domain email account or not */


Suggested change

/** Whether or not the user is on a public domain email account or not */

/** Whether user muted all sounds in application */

c3024 · 2024-04-04T10:05:13Z

@mountiny could you add Ready to Build label?

c3024 · 2024-04-04T10:05:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

shutterAndroid-compressed.mp4

Android: mWeb Chrome

iOS: Native

shutteriOS-compressed.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

mountiny · 2024-04-04T12:08:45Z

Running the build

github-actions · 2024-04-04T12:29:38Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/39400/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/39400/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/39400/NewExpensify.dmg	https://39400.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

c3024

LGTM

johnmlee101

Very nice!

mountiny

Thanks @chrispader @mrousavy @c3024

Going to go ahead and merge this now that John also approved

OSBotify · 2024-04-08T11:09:26Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.61-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-08T13:06:04Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.61-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-10T17:23:41Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.61-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mrousavy added 2 commits April 2, 2024 13:11

fix: Upgrade VisionCamera V4 to latest beta to fix shutter sound on s…

8948d41

…ilent

fix: Only play shutter sound when not explicitly disabled through set…

9f50769

…tings

mrousavy requested a review from a team as a code owner April 2, 2024 11:13

melvin-bot bot requested review from ntdiary and removed request for a team April 2, 2024 11:13

mrousavy mentioned this pull request Apr 2, 2024

Revert "Revert "feat: Upgrade VisionCamera to V4"" #39396

Merged

mrousavy commented Apr 2, 2024

View reviewed changes

chore: Install Pods/Gems

d7a50d4

mountiny reviewed Apr 2, 2024

View reviewed changes

mountiny assigned mrousavy Apr 2, 2024

c3024 suggested changes Apr 2, 2024

View reviewed changes

Christoph Pader added 2 commits April 3, 2024 13:21

use withOnyx HOC instead of useOnyx

d552ea0

Merge branch 'main' into fix/fix-shutter-sound-on-silent

9a5814b

mrousavy requested a review from chrispader April 3, 2024 14:29

Christoph Pader added 2 commits April 4, 2024 11:39

Merge branch 'main' into fix/fix-shutter-sound-on-silent

8cc9a9c

update react-native-vision-camera

6c7fadc

update package-lock.json

e126fbf

update Podfile.lock

042a637

c3024 suggested changes Apr 4, 2024

View reviewed changes

src/pages/iou/request/step/IOURequestStepScan/index.native.js Show resolved Hide resolved

c3024 suggested changes Apr 4, 2024

View reviewed changes

Christoph Pader added 2 commits April 4, 2024 12:27

fix: wrong defaultprops and description

1c8614c

fix: comment

c368e4e

mountiny added the Ready To Build label Apr 4, 2024

c3024 approved these changes Apr 4, 2024

View reviewed changes

melvin-bot bot requested a review from johnmlee101 April 4, 2024 15:20

johnmlee101 approved these changes Apr 4, 2024

View reviewed changes

mountiny approved these changes Apr 4, 2024

View reviewed changes

mountiny merged commit 015581f into Expensify:main Apr 4, 2024

github-actions bot mentioned this pull request Apr 8, 2024

Deploy Checklist: New Expensify 2024-04-08 #39807

Closed

This was referenced Apr 12, 2024

Deploy Checklist: New Expensify 2024-04-08 #39807 Derevyaa/Expensify-App#1

Closed

Deploy Checklist: New Expensify 2024-04-09 #39808 Derevyaa/Expensify-App#2

Closed

c3024 mentioned this pull request Apr 23, 2024

[$250] [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Android - Scan - Camera shutter sound still goes off despite device and app sound profile #39241

Closed

6 tasks

	import Onyx, {useOnyx} from 'react-native-onyx';
	import {withOnyx} from 'react-native-onyx';

	/** Whether or not the user is on a public domain email account or not */
	/** Whether user muted all sounds in application */

Conversation

mrousavy commented Apr 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 2, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

c3024 commented Apr 2, 2024

Uh oh!

c3024 commented Apr 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrousavy commented Apr 2, 2024

Uh oh!

c3024 commented Apr 2, 2024

Uh oh!

mrousavy commented Apr 2, 2024

Uh oh!

c3024 commented Apr 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrousavy commented Apr 3, 2024

Uh oh!

chrispader commented Apr 3, 2024

Uh oh!

mrousavy commented Apr 3, 2024

Uh oh!

chrispader commented Apr 3, 2024

Uh oh!

c3024 commented Apr 4, 2024

Uh oh!

mrousavy commented Apr 4, 2024

Uh oh!

chrispader commented Apr 4, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

c3024 commented Apr 4, 2024

Uh oh!

c3024 commented Apr 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny commented Apr 4, 2024

Uh oh!

github-actions bot commented Apr 4, 2024

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

johnmlee101 left a comment

Choose a reason for hiding this comment

mrousavy commented Apr 2, 2024 •

edited

Loading

c3024 commented Apr 2, 2024 •

edited

Loading

c3024 commented Apr 3, 2024 •

edited

Loading

c3024 commented Apr 4, 2024 •

edited

Loading