Fix an inconsistency between the mute status icon in full screen mode… by shahinyan11 · Pull Request #39479 · Expensify/App

shahinyan11 · 2024-04-03T08:45:31Z

Details

Fixed Issues

$ #38307
PROPOSAL: #38307 (comment)

Tests

Send a video as an attachment inside of a chat
Open the video in full screen mode
Mute the video
Go out of full screen mode and verify that the sound icon is muted

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as in the Tests section.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Untitled.mov

Android: mWeb Chrome

Untitled.mov

iOS: Native

Screen.Recording.2024-04-03.at.17.53.27.mov

iOS: mWeb Safari

Untitled.mov

MacOS: Chrome / Safari

Untitled.mov

MacOS: Desktop

Screen.Recording.2024-04-03.at.13.56.02.mov

… and mini player mode

melvin-bot · 2024-04-03T08:45:36Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/VideoPlayer/BaseVideoPlayer.js

shahinyan11 · 2024-04-03T14:45:56Z

@jayeshmangwani I noticed things that I want to warn you about

The volume icon always displayed as muted in full screen mode on IOS platforms ( native and mWeb). but when pressed it switches the sound, the icon just doesn’t update. And it's a package error
On android native, the native control does not contain volume icon in full screen mode

src/components/VideoPlayer/BaseVideoPlayer.js

jayeshmangwani · 2024-04-04T13:37:50Z

@shahinyan11 And we must fix the issue below in this PR;

Open a video to upload in mini player
Mute the Video
Play Video
Open In fullscreen
Unmute the video using the slider or press the volume icon
Press the Close fullscreen
On mini player video should be unmute

mute-unmute-mini-player.mov

shahinyan11 · 2024-04-04T14:47:17Z

@jayeshmangwani Video you shared on simulator or real device? I'm testing on the iOS simulator and the volume icon does not change at all when I click on it.

Screen.Recording.2024-04-04.at.18.46.09.mov

jayeshmangwani · 2024-04-04T14:58:48Z

@shahinyan11 Simulator iPhone SE - ios version 16.4

shahinyan11 · 2024-04-04T17:48:22Z

@shahinyan11 Simulator iPhone SE - ios version 16.4

Can you try on Simulator with IOS version 17.2 or 17.4

jayeshmangwani · 2024-04-04T18:13:13Z

16.4 is deprecated or unsupported?

shahinyan11 · 2024-04-04T18:53:16Z

@jayeshmangwani I tried it on 16.4 and it works like in your video . But it is a package bug. The updating volume in full screen mot does not call any event. I even tried to update package to latest version, but it did not help

jayeshmangwani · 2024-04-04T20:57:35Z

I tried it on 16.4 and it works like in your video . But it is a package bug. The updating volume in full screen mot does not call any event. I even tried to update package to latest version, but it did not help

I will test more cases tomorrow and update it here.

shahinyan11 · 2024-04-08T12:15:21Z

@jayeshmangwani Don't have any updates?

jayeshmangwani · 2024-04-08T12:17:58Z

@shahinyan11 Not yet, and I was not able to find any issue where it mentioned that 16.4 will not trigger the volume call

jayeshmangwani · 2024-04-08T12:21:37Z

@thienlnam I was able to reproduce this issue in the version iOS 16.4. Should we try to solve this issue here? As @shahinyan11 mentioned here, it's a package bug #39479 (comment). And also @shahinyan11 Can you link any issue or discussion that confirms this is package issue?

shahinyan11 · 2024-04-08T13:43:40Z

@jayeshmangwani It seems I was wrong, I'll do a few checks and come back with updates.

jayeshmangwani · 2024-04-08T13:45:34Z

Thanks for the update; I am testing this PR on desktop and mWeb Android right now.

shahinyan11 · 2024-04-08T14:10:40Z

@jayeshmangwani Could you test this bug and confirm that it is fixed ?

jayeshmangwani · 2024-04-09T13:08:20Z

@jayeshmangwani Could you test this bug and confirm that it is fixed ?

@shahinyan11 That issue is fixed, but I am facing a problem that is not looking good.

Open a video in mini player > audio is mute
Start the video and open it in a fullscreen player
Press unmute and close the fullscreen player
Now observe the mini-player play/pause button; it is flickering from play > pause > play

Please check the video below, especially 5-6 seconds timestamp

video.mov

shahinyan11 · 2024-04-10T09:17:32Z

@jayeshmangwani I updated my change to decrease re-rendering count of play/pause icon and it now looks better but the bug is not fixed completely. But If we still want to fix it completely, I think it should be done around different issue.

jayeshmangwani · 2024-04-11T11:37:38Z

@jayeshmangwani I updated my change to decrease re-rendering count of play/pause icon and it now looks better but the bug is not fixed completely. But If we still want to fix it completely, I think it should be done around different issue.

@shahinyan11 I will re-test this PR today, My iOS build was messed up from yesterday, fixed now.

src/components/VideoPlayer/BaseVideoPlayer.tsx

jayeshmangwani · 2024-04-11T21:09:53Z

@shahinyan11 I tested the latest code on desktop, web, iOS, and mWeb Safari, and the results seem good to me; I have suggested a few changes.

jayeshmangwani · 2024-04-15T13:21:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mWeb-chrome-compressed.mov

iOS: Native

iOS.mov

iOS: mWeb Safari

mWeb-safari.mov

MacOS: Chrome / Safari

web-compressed.mov

MacOS: Desktop

desktop-compressed.mov

jayeshmangwani

Changes LGTM 🚀

OSBotify · 2024-04-15T17:07:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-18T04:55:59Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-22T14:56:58Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix an inconsistency between the mute status icon in full screen mode…

d912e12

… and mini player mode

melvin-bot bot removed the request for review from a team April 3, 2024 08:45

melvin-bot bot requested a review from jayeshmangwani April 3, 2024 08:45

jayeshmangwani reviewed Apr 3, 2024

View reviewed changes

src/components/VideoPlayer/BaseVideoPlayer.js Outdated Show resolved Hide resolved

Shahe Shahinyan added 2 commits April 3, 2024 18:30

fix eslint error

82039cc

run prettier

71d5de8

jayeshmangwani reviewed Apr 4, 2024

View reviewed changes

src/components/VideoPlayer/BaseVideoPlayer.js Outdated Show resolved Hide resolved

Pull last main and resolve conflicts

59e16fd

Comment addressed

2b75d3d

Fix extra pause => play video

6487872

jayeshmangwani reviewed Apr 11, 2024

View reviewed changes

src/components/VideoPlayer/BaseVideoPlayer.tsx Show resolved Hide resolved

jayeshmangwani reviewed Apr 11, 2024

View reviewed changes

src/components/VideoPlayer/BaseVideoPlayer.tsx Show resolved Hide resolved

Add comment

461030b

jayeshmangwani approved these changes Apr 15, 2024

View reviewed changes

melvin-bot bot requested a review from thienlnam April 15, 2024 13:23

thienlnam approved these changes Apr 15, 2024

View reviewed changes

thienlnam merged commit fdae0bd into Expensify:main Apr 15, 2024

github-actions bot mentioned this pull request Apr 18, 2024

Deploy Checklist: New Expensify 2024-04-18 #40392

Closed

Conversation

shahinyan11 commented Apr 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 3, 2024

Uh oh!

Uh oh!

shahinyan11 commented Apr 3, 2024

Uh oh!

Uh oh!

jayeshmangwani commented Apr 4, 2024

Uh oh!

shahinyan11 commented Apr 4, 2024

Uh oh!

jayeshmangwani commented Apr 4, 2024

Uh oh!

shahinyan11 commented Apr 4, 2024

Uh oh!

jayeshmangwani commented Apr 4, 2024

Uh oh!

shahinyan11 commented Apr 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jayeshmangwani commented Apr 4, 2024

Uh oh!

shahinyan11 commented Apr 8, 2024

Uh oh!

jayeshmangwani commented Apr 8, 2024

Uh oh!

jayeshmangwani commented Apr 8, 2024

Uh oh!

shahinyan11 commented Apr 8, 2024

Uh oh!

jayeshmangwani commented Apr 8, 2024

Uh oh!

shahinyan11 commented Apr 8, 2024

Uh oh!

jayeshmangwani commented Apr 9, 2024

Uh oh!

shahinyan11 commented Apr 10, 2024

Uh oh!

jayeshmangwani commented Apr 11, 2024

Uh oh!

Uh oh!

Uh oh!

jayeshmangwani commented Apr 11, 2024

Uh oh!

jayeshmangwani commented Apr 15, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

jayeshmangwani left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 15, 2024

Uh oh!

OSBotify commented Apr 18, 2024

Uh oh!

OSBotify commented Apr 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

shahinyan11 commented Apr 3, 2024 •

edited

Loading

shahinyan11 commented Apr 4, 2024 •

edited

Loading