fix login page appear for a while by tienifr · Pull Request #39595 · Expensify/App

tienifr · 2024-04-04T11:50:12Z

Details

Fixed Issues

$ #38212
PROPOSAL: #38212 (comment)

Tests

Log out of ND if logged in
Navigate to a public room via deeplink, e.g. https://staging.new.expensify.com/r/1275927936266854
The user is navigated to a public room

Verify that no errors appear in the JS console

Offline tests

QA Steps

Log out of ND if logged in
Navigate to a public room via deeplink, e.g. https://staging.new.expensify.com/r/1275927936266854
The user is navigated to a public room

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-04.at.19.01.34.mov

Android: mWeb Chrome

Screen.Recording.2024-04-04.at.18.58.41.mov

iOS: Native

Screen.Recording.2024-04-04.at.19.04.25.mov

iOS: mWeb Safari

Screen.Recording.2024-04-04.at.19.05.38.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-04.at.18.52.25.mov

MacOS: Desktop

Screen.Recording.2024-04-04.at.18.55.18.mov

melvin-bot · 2024-04-05T02:55:27Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2024-04-08T04:45:29Z

@allroundexperts Please help review PR once you have a chance

allroundexperts · 2024-04-08T13:18:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-08.at.6.39.36.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-04-08.at.6.35.17.PM.mov

iOS: Native

Screen.Recording.2024-04-08.at.6.34.14.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-04-08.at.6.32.30.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-08.at.6.28.15.PM.mov

MacOS: Desktop

Screen.Recording.2024-04-08.at.6.30.26.PM.mov

allroundexperts

Looks good. Thanks!

src/CONST.ts

puneetlath · 2024-04-08T17:32:13Z

src/hooks/useNetwork.ts

    }, [isOffline]);

-    return {isOffline: isOffline ?? false};
+    return {isOffline: networkStatus === CONST.NETWORK.NETWORK_STATUS.OFFLINE};


What does this do? It's kind of weird that we have an isOffline variable, but we don't use it here and are instead looking at the status.

It looks in the other components, you're using the networkStatus variable to make decisions, so why does this need to change?

What does this do? It's kind of weird that we have an isOffline variable, but we don't use it here and are instead looking at the status.

It looks in the other components, you're using the networkStatus variable to make decisions, so why does this need to change?

This change is to fix the components that are using const {isOffline} = useNetwork(), such as this issue

Yes, I understand that. But the logic here seems unintuitive to me. That we have an isOffline variable. But then we return isOffline as something other than that variable.

Is there a way that we can make this more clear and easy to understand?

tienifr · 2024-04-15T02:42:13Z

@puneetlath Please help check the above comments once you have a chance. Thanks

tienifr · 2024-04-19T07:06:08Z

@puneetlath Any updates here?

shawnborton · 2024-04-24T13:30:51Z

Friendly bump here - can we try to get this one over the finish line soon?

puneetlath · 2024-04-24T16:18:04Z

src/hooks/useNetwork.ts

    }, [isOffline]);

-    return {isOffline: isOffline ?? false};
+    return {isOffline: networkStatus === CONST.NETWORK.NETWORK_STATUS.OFFLINE};


Yes, I understand that. But the logic here seems unintuitive to me. That we have an isOffline variable. But then we return isOffline as something other than that variable.

Is there a way that we can make this more clear and easy to understand?

tienifr · 2024-04-25T09:42:22Z

@puneetlath I resolved your comment here in this commit. Now, we just use the networkStatus to check if it is offline or not

puneetlath · 2024-04-25T19:51:16Z

This seems much more clear to me. @allroundexperts can you take a look and also re-test?

allroundexperts · 2024-04-28T21:28:19Z

On it today.

…public-room-sign-in-page

allroundexperts · 2024-04-29T07:35:35Z

Working good.

Screen.Recording.2024-04-29.at.12.32.17.PM.mov

OSBotify · 2024-04-29T15:53:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-29T23:33:36Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.67-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-04-30T01:13:33Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.68-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-04-30T02:34:21Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.67-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-05-01T02:37:43Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.68-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix login page appear for a while

fa0c505

tienifr mentioned this pull request Apr 4, 2024

[HOLD for payment 2024-05-08] [$500] Public room - Login page shows momentarily before showing public room #38212

Closed

6 tasks

tienifr marked this pull request as ready for review April 5, 2024 02:55

tienifr requested a review from a team as a code owner April 5, 2024 02:55

melvin-bot bot requested review from allroundexperts and removed request for a team April 5, 2024 02:55

tienifr mentioned this pull request Apr 8, 2024

iOS - Login - Offline indicator briefly appears on the login page #39715

Closed

6 tasks

fix useNetwork

9fb92f1

tienifr force-pushed the fix/38212-public-room-sign-in-page branch from 8991222 to 9fb92f1 Compare April 8, 2024 08:05

allroundexperts approved these changes Apr 8, 2024

View reviewed changes

melvin-bot bot requested a review from puneetlath April 8, 2024 14:01

puneetlath requested changes Apr 8, 2024

View reviewed changes

fix merge main

7bffc25

ZhenjaHorbach mentioned this pull request Apr 11, 2024

Offline indicator appears for quick moment on home page #40133

Closed

6 tasks

fix merge main

ad9a2e4

puneetlath requested changes Apr 24, 2024

View reviewed changes

fix use networkStatus instead of isOffline in useNetwork

a8a55b3

Merge branch 'main' of https://github.com/tienifr/App into fix/38212-…

81f9cf2

…public-room-sign-in-page

allroundexperts approved these changes Apr 29, 2024

View reviewed changes

melvin-bot bot requested a review from puneetlath April 29, 2024 07:41

puneetlath approved these changes Apr 29, 2024

View reviewed changes

puneetlath merged commit 67f7a3d into Expensify:main Apr 29, 2024

DylanDylann mentioned this pull request Apr 29, 2024

HIGH: [UX Reliability] [$250] The loading spinner is not shown when a public room is accessed anonymously for the first time #38718

Closed

6 tasks

github-actions bot mentioned this pull request Apr 29, 2024

Deploy Checklist: New Expensify 2024-04-29 #41266

Closed

74 tasks

Nodebrute mentioned this pull request Apr 30, 2024

Troubleshoot - App does not go offline when "Force offline" is toggled on #41276

Closed

6 tasks

Conversation

tienifr commented Apr 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 5, 2024

Uh oh!

tienifr commented Apr 8, 2024

Uh oh!

allroundexperts commented Apr 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

puneetlath Apr 8, 2024

Choose a reason for hiding this comment

Uh oh!

tienifr Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

puneetlath Apr 24, 2024

Choose a reason for hiding this comment

Uh oh!

tienifr commented Apr 15, 2024

Uh oh!

tienifr commented Apr 19, 2024

Uh oh!

shawnborton commented Apr 24, 2024

Uh oh!

puneetlath Apr 24, 2024

Choose a reason for hiding this comment

Uh oh!

tienifr commented Apr 25, 2024

Uh oh!

puneetlath commented Apr 25, 2024

Uh oh!

allroundexperts commented Apr 28, 2024

Uh oh!

allroundexperts commented Apr 29, 2024

Uh oh!

OSBotify commented Apr 29, 2024

Uh oh!

OSBotify commented Apr 29, 2024

Uh oh!

OSBotify commented Apr 30, 2024

Uh oh!

OSBotify commented Apr 30, 2024

Uh oh!

OSBotify commented May 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tienifr commented Apr 4, 2024 •

edited

Loading

allroundexperts commented Apr 8, 2024 •

edited

Loading

tienifr Apr 9, 2024 •

edited

Loading