Add default font size for emojis in live markdown input#39597
Conversation
|
@johnmlee101 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
tomekzaw
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this
|
@johnmlee101 bump |
|
There's been some conversation about the expectation of the emoji size depending on the current message here. If we could implement it in this PR as well that would be great |
|
@thienlnam @johnmlee101 I've added requested changes connected to changing emoji size depending on the current message |
|
@thienlnam was it necessary to merge? 😓 |
|
Ah sorry 😢 , got trigger happy - will avoid doing that next time |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.63-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀
|
@thienlnam
Details
This PR adds default emoji font size from Expensify variables to live markdown default styles hook.
web.mov
Fixed Issues
$ Expensify/react-native-live-markdown#233
PROPOSAL:
Tests
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Uploading web.mov…
MacOS: Desktop
desktop.mov