[CP Staging] fix: taxpicker selection for tax settings#39646
Merged
MonilBhavsar merged 4 commits intoExpensify:mainfrom Apr 5, 2024
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes taxPicker selection for tax settings. The tax picker was missing a
policyIDprop which is needed to get policy tax rates from onyx. Also, we needed to update logic for the selected tax Rate.Fixed Issues
$ #39602
PROPOSAL: issuecomment
Tests
Expectation: Make sure In Step 6 and 7, all other available taxes will show up in the list
Offline tests
Expectation: Make sure In Step 6 and 7, all other available taxes will show up in the list
QA Steps
Expectation: Make sure In Step 6 and 7, all other available taxes will show up in the list
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2024-04-04.at.20.44.59.mov
iOS: Native
Screen.Recording.2024-04-04.at.21.22.56.mov
Android: Native
Screen.Recording.2024-04-04.at.22.11.36.mov
Android: mWeb Chrome
iOS: mWeb Safari
MacOS: Desktop