Skip to content

[CP Staging] Revert "Defer local updates if there are missing updates and only call GetMissingOnyxMessages once"#39668

Merged
jasperhuangg merged 1 commit intomainfrom
revert-38997-@chrispader/prevent-simultaneous-calls-to-GetMissingOnyxMessages
Apr 5, 2024
Merged

[CP Staging] Revert "Defer local updates if there are missing updates and only call GetMissingOnyxMessages once"#39668
jasperhuangg merged 1 commit intomainfrom
revert-38997-@chrispader/prevent-simultaneous-calls-to-GetMissingOnyxMessages

Conversation

@luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Apr 4, 2024 •
edited
Loading

Reverts #38997

Coming from this thread. Staging is crashing on this line

@luacmartins luacmartins self-assigned this Apr 4, 2024
@luacmartins luacmartins changed the title Revert "Defer local updates if there are missing updates and only call GetMissingOnyxMessages once" [CP Staging] Revert "Defer local updates if there are missing updates and only call GetMissingOnyxMessages once" Apr 4, 2024
@luacmartins luacmartins marked this pull request as ready for review April 4, 2024 23:30
@luacmartins luacmartins requested a review from a team as a code owner April 4, 2024 23:30
@melvin-bot melvin-bot bot removed the request for review from a team April 4, 2024 23:31
@melvin-bot
Copy link

melvin-bot bot commented Apr 4, 2024

@lakchote Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from lakchote April 4, 2024 23:31
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/39668/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/39668/index.html
Android iOS
Desktop 💻 Web 🕸️
❌ FAILED ❌ https://39668.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed Web

👀 View the workflow run that generated this build 👀

@aldo-expensify aldo-expensify mentioned this pull request Apr 5, 2024
Closed
6 tasks
@aldo-expensify
Copy link
Contributor

aldo-expensify commented Apr 5, 2024

This revert is fixing #39650 for me, so approving!

@aldo-expensify
Copy link
Contributor

aldo-expensify commented Apr 5, 2024

@jasperhuangg should we merge and CP this? or give more time to the author of #38997 to fix it before reverting? I'm not sure if you are planning to deploy today or not

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Apr 5, 2024

@aldo-expensify planning on deploying today, so let's get the revert up

@jasperhuangg jasperhuangg merged commit 3864cdb into main Apr 5, 2024
@jasperhuangg jasperhuangg deleted the revert-38997-@chrispader/prevent-simultaneous-calls-to-GetMissingOnyxMessages branch April 5, 2024 01:36
@melvin-bot melvin-bot bot added the Emergency label Apr 5, 2024
@melvin-bot
Copy link

melvin-bot bot commented Apr 5, 2024

@jasperhuangg looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Apr 5, 2024

This was a straight revert that was tested already, no need for Emergency label

@OSBotify
Copy link
Contributor

OSBotify commented Apr 5, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@aldo-expensify
Copy link
Contributor

aldo-expensify commented Apr 5, 2024

@aldo-expensify planning on deploying today, so let's get the revert up

Nice, let me know if you want me to help you testing once CP'ed to staging

OSBotify pushed a commit that referenced this pull request Apr 5, 2024
@jasperhuangg @OSBotify
Merge pull request #39668 from Expensify/revert-38997-@chrispader/pre…
1812725 
…vent-simultaneous-calls-to-GetMissingOnyxMessages

[CP Staging] Revert "Defer local updates if there are missing updates and only call `GetMissingOnyxMessages` once"

(cherry picked from commit 3864cdb)
@github-actions github-actions bot mentioned this pull request Apr 5, 2024
Closed
48 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Apr 5, 2024

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 1.4.60-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Apr 5, 2024

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 1.4.60-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@aldo-expensify
Copy link
Contributor

aldo-expensify commented Apr 5, 2024

Tested, and confirmed that #39650 is fixed in staging

Screen.Recording.2024-04-04.at.7.55.13.PM.mov

chrispader pushed a commit to margelo/Expensify that referenced this pull request Apr 5, 2024
Revert "Merge pull request Expensify#39668 from Expensify/revert-3899…
068e624 
…7-@chrispader/prevent-simultaneous-calls-to-GetMissingOnyxMessages"

This reverts commit 3864cdb, reversing
changes made to 42ee04c.
@chrispader chrispader mentioned this pull request Apr 5, 2024
Merged
50 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Apr 8, 2024

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasperhuangg jasperhuangg jasperhuangg approved these changes

@aldo-expensify aldo-expensify aldo-expensify approved these changes

@lakchote lakchote Awaiting requested review from lakchote

Assignees

@luacmartins luacmartins

Labels

Ready To Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luacmartins @aldo-expensify @jasperhuangg @OSBotify