feature: implement qbo advanced configuration screens#39899
Merged
hayata-suenaga merged 152 commits intoExpensify:mainfrom Apr 22, 2024
Merged
Conversation
…9/implement-qbo-advanced-configuration-screens
…9/implement-qbo-advanced-configuration-screens
s77rt
suggested changes
Apr 22, 2024
src/pages/workspace/accounting/qbo/advanced/QuickbooksAdvancedPage.tsx
Outdated
Show resolved
Hide resolved
s77rt
reviewed
Apr 22, 2024
s77rt
suggested changes
Apr 22, 2024
src/pages/workspace/accounting/qbo/advanced/QuickbooksAdvancedPage.tsx
Outdated
Show resolved
Hide resolved
src/pages/workspace/accounting/qbo/advanced/QuickbooksAdvancedPage.tsx
Outdated
Show resolved
Hide resolved
…9/implement-qbo-advanced-configuration-screens
s77rt
reviewed
Apr 22, 2024
s77rt
reviewed
Apr 22, 2024
src/pages/workspace/accounting/qbo/advanced/QuickbooksAdvancedPage.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@s77rt, check again. |
Member
|
Thank you! |
s77rt
approved these changes
Apr 22, 2024
hayata-suenaga
approved these changes
Apr 22, 2024
Contributor
hayata-suenaga
left a comment
There was a problem hiding this comment.
wow we can finally merge 🎉 the code looks 🟢 to me! thank you everyone for your hard work on this PR 😄
74 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.65-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀
|
Comment on lines
+3
to
+5
| connectionName: string; | ||
| settingName: string; | ||
| settingValue?: string; |
Contributor
There was a problem hiding this comment.
Why did we change these types to string? @teneeto @hayata-suenaga
Contributor
There was a problem hiding this comment.
Oh, these re the parameters of the command, I see now. Ignore me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Implement a new pages called "QBO advanced configuration screens" for the QuickBooks Online (QBO) connection project.
Screen.Recording.2024-04-17.at.15.07.46.mov
Fixed Issues
$ 37799
PROPOSAL: issue Description
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2024-04-17.at.15.07.46.mov
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Desktop