[TS migration] Migrate IOURequestStartPage, IOURequestRedirectToStartPage, IOURequestStepDistance and IOURequestStepAmount pages to TypeScript by kosmydel · Pull Request #39910 · Expensify/App

kosmydel · 2024-04-09T10:06:54Z

Details

Fixed Issues

$ #38914
PROPOSAL:

Tests

Create a new money request:
1. Use FAB -> Request money
2. Create new requests using Manual and Distance tabs.
Create a new money request using composer.
1. Click "+" next to the composer.
2. Select "Request money".
3. Type some value -> Next -> Request.
4. Click on the freshly created request.
5. Click on the amount to edit it.

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console
Do the tests from the "Tests" section

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome & iOS: mWeb Safari

mweb.mov

iOS: Native

Uploading ios.mp4…

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

merge main into ts-migration/IOURequestStartPage

…/software-mansion-labs/expensify-app-fork into ts-migration/IOURequestStartPage

src/pages/iou/request/step/IOURequestStepAmount.tsx

src/libs/Navigation/types.ts

blazejkustra · 2024-04-09T10:31:17Z

src/libs/actions/IOU.ts

+    policy = {} as OnyxTypes.Policy,
+    policyTagList = {},
+    policyCategories = {},


Let's avoid empty object default values, is this necessary?

src/pages/iou/request/IOURequestStartPage.tsx

src/pages/iou/request/step/IOURequestStepAmount.tsx

blazejkustra

Looks good!

src/components/DistanceRequest/DistanceRequestRenderItem.tsx

src/pages/iou/request/IOURequestStartPage.tsx

src/pages/iou/request/step/IOURequestStepAmount.tsx

melvin-bot · 2024-04-09T17:35:16Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-04-11T20:42:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Record_2024-04-12-18-39-42.mp4

iOS: Native

Screen.Recording.2024-04-12.at.3.33.15.AM-1-1-1.mov

iOS: mWeb Safari

Screen.Recording.2024-04-12.at.6.33.12.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-12.at.3.25.08.AM-1.mov

MacOS: Desktop

Screen.Recording.2024-04-12.at.6.47.53.PM-1.mov

ishpaul777 · 2024-04-11T21:44:45Z

Bug: Dragging and droping waypoints seems broken

Screen.Recording.2024-04-12.at.3.09.35.AM.mov

kosmydel · 2024-04-12T08:21:58Z

Bug: Dragging and droping waypoints seems broken

I've fixed it. It is ready for review :)

However, when testing, I encountered a bug (it occurs also on main):

Log in to the account.
FAB -> Request Money -> Distance
Select a waypoint
Exit the RHP
Again point 2.
Press on the Start waypoint
Not found view.

Video (main branch):

request-money-bug.mov

ishpaul777

LGTM!

ishpaul777 · 2024-04-12T13:49:51Z

@kosmydel Can you report this bug in #expensify-bugs channel if we dont have a issue already

blazejkustra · 2024-04-12T14:03:57Z

~~@ishpaul777 Reviewer checklist is failing~~

OSBotify · 2024-04-12T14:12:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-18T04:57:14Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-22T14:58:13Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

brunovjk · 2024-08-30T12:02:20Z

This PR removed the selectedTab prop from OnyxTabNavigator, as it already pulls it from Onyx, comment. However, we still needed to retain a default value set to SCAN for cases where Onyx doesn't have a selectedTab value. The change inadvertently caused an issue where the default selected tab should be set to "Scan" for submitting expenses.

cdOut and others added 10 commits March 27, 2024 12:01

refactor all base pages to tsx

532dcac

add correct props for IOURequestStartPage

9f68f82

Merge branch 'main' into ts-migration/IOURequestStartPage

8a5864a

merge main into ts-migration/IOURequestStartPage

refactor IOURequest pages

6f86eee

fix prettier

8e333dc

Merge branch 'main' into ts-migration/IOURequestStartPage

476aceb

add prop comments

9e9ee8f

Merge branch 'ts-migration/IOURequestStartPage' of https://github.com…

a08252a

…/software-mansion-labs/expensify-app-fork into ts-migration/IOURequestStartPage

fix some types

59899dc

fix types

e5d00bf

kosmydel commented Apr 9, 2024

View reviewed changes

src/pages/iou/request/step/IOURequestStepAmount.tsx Show resolved Hide resolved

blazejkustra suggested changes Apr 9, 2024

View reviewed changes

kosmydel added 2 commits April 9, 2024 12:52

address review

1219412

adress review

7a599c2

blazejkustra approved these changes Apr 9, 2024

View reviewed changes

fix issues on distance page

0196372

kubabutkiewicz reviewed Apr 9, 2024

View reviewed changes

src/components/DistanceRequest/DistanceRequestRenderItem.tsx Show resolved Hide resolved

src/pages/iou/request/IOURequestStartPage.tsx Show resolved Hide resolved

src/pages/iou/request/step/IOURequestStepAmount.tsx Outdated Show resolved Hide resolved

address review

9902923

kubabutkiewicz approved these changes Apr 9, 2024

View reviewed changes

kosmydel marked this pull request as ready for review April 9, 2024 17:35

kosmydel requested a review from a team as a code owner April 9, 2024 17:35

melvin-bot bot requested review from Santhosh-Sellavel and removed request for a team April 9, 2024 17:35

kosmydel added 5 commits April 10, 2024 11:33

Merge branch 'main' into ts-migration/IOURequestStartPage

e79c50a

Merge branch 'main' into ts-migration/IOURequestStartPage

0dac258

cast boolean

d0f50ad

Merge branch 'main' into ts-migration/IOURequestStartPage

03def63

fix types

5fa6e38

luacmartins self-requested a review April 11, 2024 16:16

joekaufmanexpensify requested review from ishpaul777 and removed request for Santhosh-Sellavel April 11, 2024 19:42

kosmydel added 2 commits April 12, 2024 09:44

Merge branch 'main' into ts-migration/IOURequestStartPage

0ee283b

fix issue

24e637d

ishpaul777 approved these changes Apr 12, 2024

View reviewed changes

luacmartins approved these changes Apr 12, 2024

View reviewed changes

luacmartins merged commit d4bc1b0 into Expensify:main Apr 12, 2024

github-actions bot mentioned this pull request Apr 18, 2024

Deploy Checklist: New Expensify 2024-04-18 #40392

Closed

DylanDylann mentioned this pull request Apr 21, 2024

[HOLD for payment 2024-05-02] Distance - Map reloads with "Route pending" when clicking Save button without any changes #38864

Closed

6 tasks

DylanDylann mentioned this pull request Apr 22, 2024

[Fix] Map reloads with "Route pending" #40674

Merged

50 tasks

brunovjk mentioned this pull request Aug 30, 2024

[HOLD for payment 2024-08-29] [CVP] [$250] Default Selected Tab is Scan when submitting an expense #46916

Closed

6 tasks

Conversation

kosmydel commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

blazejkustra Apr 9, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blazejkustra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

melvin-bot bot commented Apr 9, 2024

Uh oh!

ishpaul777 commented Apr 11, 2024 • edited by luacmartins Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ishpaul777 commented Apr 11, 2024

Uh oh!

kosmydel commented Apr 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 left a comment

Choose a reason for hiding this comment

Uh oh!

ishpaul777 commented Apr 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blazejkustra commented Apr 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Apr 12, 2024

Uh oh!

OSBotify commented Apr 18, 2024

Uh oh!

OSBotify commented Apr 22, 2024

Uh oh!

brunovjk commented Aug 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

kosmydel commented Apr 9, 2024 •

edited

Loading

ishpaul777 commented Apr 11, 2024 •

edited by luacmartins

Loading

kosmydel commented Apr 12, 2024 •

edited

Loading

ishpaul777 commented Apr 12, 2024 •

edited

Loading

blazejkustra commented Apr 12, 2024 •

edited

Loading