Fix Android build failing due to dependencies being built for wrong ABIs by j-piasecki · Pull Request #40102 · Expensify/App

j-piasecki · 2024-04-11T11:14:08Z

Details

With the PR enabling the new architecture (#13767), we enabled building React Native from source on Android. When building from the command line, --active-arch-only flag is passed to gradle so not all ABIs are built which speeds things up. This caused problem in two libraries:

react-native-live-markdown - Filter built ABIs so the library compiles when building for select ABIs react-native-live-markdown#284
react-native-quick-sqlite - https://github.com/margelo/react-native-quick-sqlite/pull/41

In both cases, there was a problem with abiFilters field in gradle which was causing them to fail on the linking step. The libs were being build for all ABIs but the relevant .so files from React Native core were only being built for one (arm64-v8a).

Fixed Issues

I don't think one has been created, here's a thread on Slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1712746783190519

$
PROPOSAL:

Tests

Build the app using npm run android.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

WoLewicki

It builds from terminal for me now 🚀

melvin-bot · 2024-04-11T12:41:46Z

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thienlnam · 2024-04-11T16:07:50Z

Adhoc build should be ready soon - asked for a C+ to run through testing https://expensify.slack.com/archives/C02NK2DQWUX/p1712851640475759

rushatgabhane · 2024-04-11T16:39:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2024-04-11T16:46:15Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/40102/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/40102/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/40102/NewExpensify.dmg	https://40102.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

melvin-bot · 2024-04-11T16:47:10Z

🎯 @rushatgabhane, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #40131.

rushatgabhane · 2024-04-11T16:47:34Z

LGTM, builds locally and markdown tests well on all platforms

thienlnam

Thanks! All yours @deetergp

arosiclair · 2024-04-11T18:01:10Z

This is blocking a lot of people so I'm just gonna merge this now

OSBotify · 2024-04-11T18:09:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

roryabraham · 2024-04-11T18:43:22Z

thanks for pushing this through 🚀

OSBotify · 2024-04-18T04:59:23Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-22T15:00:22Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

### Summary In the native template `abiFilters` is missing from `externalNativeBuild` block. This means that the library would be built for every available ABI when building the application, even if the application itself is being built for a specific one. This is not that problematic (besides taking more time) when using React Native aar, but when building RN from source the core `.so` files will be built for that specific ABI. In case the library depends on a `.so` file, it would fail at the linking stage due to missing `.so` for the remaining ABIs. ### Test plan See - Expensify/App#40102 - Expensify/react-native-live-markdown#284 - https://github.com/margelo/react-native-quick-sqlite/pull/41 --------- Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>

j-piasecki added 2 commits April 11, 2024 13:00

Add patch for react-native-quick-sqlite

7bd8f01

Bump live markdown

112907d

tomekzaw mentioned this pull request Apr 11, 2024

Fix text in compose box blending with background on theme change #39872

Closed

50 tasks

WoLewicki approved these changes Apr 11, 2024

View reviewed changes

j-piasecki marked this pull request as ready for review April 11, 2024 12:41

j-piasecki requested a review from a team as a code owner April 11, 2024 12:41

melvin-bot bot removed the request for review from a team April 11, 2024 12:41

melvin-bot bot requested a review from deetergp April 11, 2024 12:41

Julesssss added the Ready To Build label Apr 11, 2024

j-piasecki mentioned this pull request Apr 11, 2024

Add abiFilters to the native template callstack/react-native-builder-bob#546

Merged

thienlnam requested a review from rushatgabhane April 11, 2024 16:08

thienlnam mentioned this pull request Apr 11, 2024

Fix inline image syntax in live markdown #39905

Closed

50 tasks

allgandalf mentioned this pull request Apr 11, 2024

[Fix]: Report fields are not auto focused on field selection #40130

Merged

50 tasks

rlinoz mentioned this pull request Apr 11, 2024

[HOLD for payment 2024-06-06] [$250] Android - Distance - Waypoint does not change position correctly by dragging #40105

Closed

6 tasks

thienlnam self-requested a review April 11, 2024 16:40

rushatgabhane approved these changes Apr 11, 2024

View reviewed changes

melvin-bot bot mentioned this pull request Apr 11, 2024

[Pay 4/29] Payment issue for E/App PR#40102 #40131

Closed

thienlnam approved these changes Apr 11, 2024

View reviewed changes

arosiclair approved these changes Apr 11, 2024

View reviewed changes

arosiclair merged commit ae11ccf into Expensify:main Apr 11, 2024

jakub-trzebiatowski mentioned this pull request Apr 12, 2024

[$250] Android - Taxes - Cursor is placed before the value when reopening saved value #39081

Closed

6 tasks

github-actions bot mentioned this pull request Apr 18, 2024

Deploy Checklist: New Expensify 2024-04-18 #40392

Closed

Conversation

j-piasecki commented Apr 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

WoLewicki left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Apr 11, 2024

Uh oh!

thienlnam commented Apr 11, 2024

Uh oh!

rushatgabhane commented Apr 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Apr 11, 2024

Uh oh!

melvin-bot bot commented Apr 11, 2024

Uh oh!

rushatgabhane commented Apr 11, 2024

Uh oh!

thienlnam left a comment

Choose a reason for hiding this comment

Uh oh!

arosiclair commented Apr 11, 2024

Uh oh!

OSBotify commented Apr 11, 2024

Uh oh!

roryabraham commented Apr 11, 2024

Uh oh!

OSBotify commented Apr 18, 2024

Uh oh!

OSBotify commented Apr 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

j-piasecki commented Apr 11, 2024 •

edited

Loading

rushatgabhane commented Apr 11, 2024 •

edited

Loading