fix: Web - Persistence of Tax Selection When Navigating to Other Pages and Returning by Krishna2323 · Pull Request #40136 · Expensify/App

Krishna2323 · 2024-04-11T19:00:07Z

Details

Fixed Issues

$ #39492
PROPOSAL: #39492 (comment)

Tests

Go to Settings > Profile > Select any collect workspace.
Enable all features (Distance rates, Categories, Tags, Taxes).
Go to members page and select all members using select all checkbox in thead.
Navigate to any other page. e.g. (Distance rates, Categories, Tags, Taxes) and comeback.
Verify all members are not selected.
For Distance rates, Categories, Tags and Taxes repeat step 3, 4 & 5

Verify that no errors appear in the JS console

Offline tests

Go to Settings > Profile > Select any collect workspace.
Enable all features (Distance rates, Categories, Tags, Taxes).
Go to members page and select all members using select all checkbox in thead.
Navigate to any other page. e.g. (Distance rates, Categories, Tags, Taxes) and comeback.
Verify all members are not selected.
For Distance rates, Categories, Tags and Taxes repeat step 3, 4 & 5

QA Steps

Go to Settings > Profile > Select any collect workspace.
Enable all features (Distance rates, Categories, Tags, Taxes).
Go to members page and select all members using select all checkbox in thead.
Navigate to any other page. e.g. (Distance rates, Categories, Tags, Taxes) and comeback.
Verify all members are not selected.
For Distance rates, Categories, Tags and Taxes repeat step 3, 4 & 5

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…s and Returning Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

melvin-bot · 2024-04-11T19:00:12Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2024-04-12T07:25:56Z

src/pages/workspace/tags/WorkspaceTagsPage.tsx

    useFocusEffect(
        useCallback(() => {
+            setSelectedTags({});
            fetchTags();
        }, [fetchTags]),
    );


We should clear the tags when losing focus (instead of when gaining focus) that way we can remove the rest of logic that's used to clear the tags e.g. when navigating to the settings page

(same applies for the rest of the pages)

Sorry I forgot about that, I was trying to follow this suggestion, but yes, we should clear the options when losing focus.

@s77rt, updated, can you pls check again🙏🏻

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

s77rt · 2024-04-13T09:33:02Z

Looks good to me. Working on the checklist... While we are fixing these bugs please merge main and fix the same for ReportParticipantsPage (it has same logic as WorkspaceMembersPage)

s77rt · 2024-04-13T09:51:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

s77rt · 2024-04-13T09:51:29Z

Let me know once this is resolved #40136 (comment)

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 · 2024-04-13T10:05:35Z

@s77rt, fix for ReportParticipantsPage added.

s77rt · 2024-04-13T10:32:52Z

Thank you!

hayata-suenaga · 2024-04-15T23:57:58Z

hellooo thank you for the PR. was there a specific reason you didn't use useFocusEffect? I think this hook from react-navigation is made for a situation like this, right?

Krishna2323 · 2024-04-16T03:18:32Z

@hayata-suenaga see comment

hayata-suenaga · 2024-04-16T15:58:58Z

@Krishna2323, thank you for the link to the comment. If you return a function from the useFocusEffect and if you clear the categories state in that function, it will be triggered when the screen looses the focus.

 useFocusEffect(
    useCallback(() => () => setCategories([]), [])
  );

Krishna2323 · 2024-04-16T16:01:35Z

@hayata-suenaga, thanks for the explanation, will check that soon and update.

s77rt · 2024-04-16T16:22:16Z

@hayata-suenaga The clean up function in useFocusEffect will get executed whenever the dependencies change (even if the page is focused). In our case this shouldn't case a problem but it's discouraged in the react-navigation doc.

hayata-suenaga · 2024-04-16T16:39:43Z

ah I see @s77rt ! thank you for the link!

hayata-suenaga

🟢

OSBotify · 2024-04-18T04:59:47Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-22T15:00:46Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: Web - Persistence of Tax Selection When Navigating to Other Page…

45526c9

…s and Returning Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 requested a review from a team as a code owner April 11, 2024 19:00

melvin-bot bot requested review from s77rt and removed request for a team April 11, 2024 19:00

s77rt suggested changes Apr 12, 2024

View reviewed changes

Krishna2323 added 2 commits April 12, 2024 13:39

policy pages: clear seleted options when focus is removed from page.

1826769

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/39492

3c114ac

Krishna2323 requested a review from s77rt April 13, 2024 03:23

Krishna2323 added 2 commits April 13, 2024 15:24

Merge branch 'Expensify:main' into krishna2323/issue/39492

02f784c

clear selected members data when navigating from ReportParticipantsPage.

5065abd

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

s77rt approved these changes Apr 13, 2024

View reviewed changes

melvin-bot bot requested a review from hayata-suenaga April 13, 2024 10:33

s77rt mentioned this pull request Apr 13, 2024

Selecting members on the participants page then removing a member leaves button selector in a weird state #40194

Closed

hayata-suenaga approved these changes Apr 16, 2024

View reviewed changes

hayata-suenaga merged commit dd9ca88 into Expensify:main Apr 16, 2024

github-actions bot mentioned this pull request Apr 18, 2024

Deploy Checklist: New Expensify 2024-04-18 #40392

Closed

cretadn22 mentioned this pull request Sep 17, 2024

[Due for payment 2025-02-19] [$250] when selecting categories, the selected categories get reset if we click outside the checkbox #49322

Closed

6 tasks

Conversation

Krishna2323 commented Apr 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 11, 2024

Uh oh!

s77rt Apr 12, 2024

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Apr 12, 2024

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Apr 12, 2024

Choose a reason for hiding this comment

Uh oh!

s77rt commented Apr 13, 2024

Uh oh!

s77rt commented Apr 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

s77rt commented Apr 13, 2024

Uh oh!

Krishna2323 commented Apr 13, 2024

Uh oh!

s77rt commented Apr 13, 2024

Uh oh!

hayata-suenaga commented Apr 15, 2024

Uh oh!

Krishna2323 commented Apr 16, 2024

Uh oh!

hayata-suenaga commented Apr 16, 2024

Uh oh!

Krishna2323 commented Apr 16, 2024

Uh oh!

s77rt commented Apr 16, 2024

Uh oh!

hayata-suenaga commented Apr 16, 2024

Uh oh!

hayata-suenaga left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 18, 2024

Uh oh!

OSBotify commented Apr 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Krishna2323 commented Apr 11, 2024 •

edited

Loading

s77rt commented Apr 13, 2024 •

edited

Loading