Enable creating a group chat with one other participant by abzokhattab · Pull Request #40165 · Expensify/App

abzokhattab · 2024-04-12T08:04:32Z

Details

Fixed Issues

$ #39317
PROPOSAL: #39317 (comment)

Tests

Verify that no errors appear in the JS console

Go to FAB > Start chat
Click Add to group with one user
Ensure that the Next confirmation button is shown and click on it to navigate to the next page
in the confirm page click on Start Group and make sure that the group is created without errors

Offline tests

Same as in tests

QA Steps

Verify that no errors appear in the JS console

Same as in tests

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-12.at.9.33.06.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-04-12.at.9.56.53.AM.mov

iOS: Native

Screen.Recording.2024-04-12.at.9.22.57.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-04-12.at.9.21.51.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-12.at.9.12.00.AM.mov

MacOS: Desktop

Screen.Recording.2024-04-12.at.9.28.42.AM.mov

melvin-bot · 2024-04-12T08:04:37Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/NewChatPage.tsx

s77rt · 2024-04-13T10:11:54Z

src/pages/NewChatPage.tsx

+                            confirmButtonText={translate('common.next')}
                            textInputAlert={isOffline ? [`${translate('common.youAppearToBeOffline')} ${translate('search.resultsAreLimited')}`, {isTranslated: true}] : ''}
-                            onConfirmSelection={selectedOptions.length > 1 ? navigateToConfirmPage : createChat}
+                            onConfirmSelection={selectedOptions.length > 0 ? navigateToConfirmPage : createChat}


Suggested change

onConfirmSelection={selectedOptions.length > 0 ? navigateToConfirmPage : createChat}

onConfirmSelection={selectedOptions.length > 0 ? navigateToConfirmPage : undefined}

The CreateChat is needed for the CTRL+Enter shortcut, if we remove it will introduce a regression.
FYI currently, when the user presses on CTRL+Enter, the onConfirmSelection is called.

Screen.Recording.2024-04-13.at.1.00.26.PM.mov

s77rt · 2024-04-13T10:24:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

marcaaron · 2024-04-16T00:21:26Z

Sorry, this has a conflict now.

marcaaron

Code LGTM

abzokhattab · 2024-04-16T00:28:35Z

in the conflict the selection list was introduced instead of the options selector however in the new implementation when the user selects multiple participants and then presses on CTRL+Enter it doesn't click on the Next button instead it selects the current focused option leading it to creating a direct dm. should this bug be fixed here or in a new issue? @marcaaron

Screen.Recording.2024-04-16.at.2.25.58.AM.mov

marcaaron · 2024-04-16T03:09:31Z

Technically whoever edited this to use the new selector broke it already so I don't really feel like that's on you to fix, but if you see an easy solution I'd appreciate it. It's unlikely that anyone has caught that yet as it's not on staging yet.

…-with-one-other-participant

abzokhattab · 2024-04-16T05:26:58Z

@marcaaron @s77rt okay the issue is now fixed in the recent commit, please have a look and let me know if you have any other comments.

marcaaron

One question. Changes LGTM otherwise, thanks for picking this one up! 🙇

marcaaron · 2024-04-16T19:00:04Z

src/pages/NewChatPage.tsx

+    const createGroup = useCallback(() => {
+        if (selectedOptions.length === 1) {
+            createChat();
+        }


Are we missing a return here?

ops, didnt notice this condition in the new code, actually it's not needed now, i have removed it since the user can create a group chat with only 1 selected members

marcaaron

LGTM thanks for the change

OSBotify · 2024-04-17T19:42:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-18T04:59:59Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.4.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-22T15:00:58Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Enable creating a group chat with one other participant

10bd5bb

abzokhattab requested a review from a team as a code owner April 12, 2024 08:04

melvin-bot bot requested review from s77rt and removed request for a team April 12, 2024 08:04

abzokhattab mentioned this pull request Apr 12, 2024

[$250] [MEDIUM] [Groups] - Group chat with one user is allowed in confirmation page, but not in contact list #39317

Closed

6 tasks

s77rt suggested changes Apr 13, 2024

View reviewed changes

cleaning startChat translation

cf7c89e

s77rt approved these changes Apr 13, 2024

View reviewed changes

melvin-bot bot requested a review from marcaaron April 13, 2024 11:30

marcaaron previously approved these changes Apr 16, 2024

View reviewed changes

marcaaron assigned abzokhattab Apr 16, 2024

abzokhattab added 2 commits April 16, 2024 07:14

Merge remote-tracking branch 'origin/main' into enable-creating-group…

87d207d

…-with-one-other-participant

fix ctrl enter shortcut action

1e3de7a

abzokhattab dismissed marcaaron’s stale review via 1e3de7a April 16, 2024 05:25

abzokhattab added 2 commits April 16, 2024 07:33

cleanup

b6f6864

minor edit

8f00f63

marcaaron requested changes Apr 16, 2024

View reviewed changes

refactoring the createGroup function.

2b18ce9

marcaaron approved these changes Apr 17, 2024

View reviewed changes

marcaaron merged commit 97632e6 into Expensify:main Apr 17, 2024

github-actions bot mentioned this pull request Apr 18, 2024

Deploy Checklist: New Expensify 2024-04-18 #40392

Closed

	onConfirmSelection={selectedOptions.length > 0 ? navigateToConfirmPage : createChat}
	onConfirmSelection={selectedOptions.length > 0 ? navigateToConfirmPage : undefined}

Conversation

abzokhattab commented Apr 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 12, 2024

Uh oh!

Uh oh!

s77rt Apr 13, 2024

Choose a reason for hiding this comment

Uh oh!

abzokhattab Apr 13, 2024

Choose a reason for hiding this comment

Uh oh!

s77rt commented Apr 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

marcaaron commented Apr 16, 2024

Uh oh!

marcaaron left a comment

Choose a reason for hiding this comment

Uh oh!

abzokhattab commented Apr 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcaaron commented Apr 16, 2024

Uh oh!

abzokhattab commented Apr 16, 2024

Uh oh!

marcaaron left a comment

Choose a reason for hiding this comment

Uh oh!

marcaaron Apr 16, 2024

Choose a reason for hiding this comment

Uh oh!

abzokhattab Apr 17, 2024

Choose a reason for hiding this comment

Uh oh!

marcaaron left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 17, 2024

Uh oh!

OSBotify commented Apr 18, 2024

Uh oh!

OSBotify commented Apr 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

abzokhattab commented Apr 12, 2024 •

edited

Loading

s77rt commented Apr 13, 2024 •

edited

Loading

abzokhattab commented Apr 16, 2024 •

edited

Loading