Update report option when personal detail is changed by nkdengineer · Pull Request #40167 · Expensify/App

nkdengineer · 2024-04-12T08:26:36Z

Details

Update report option when personal detail is changed

Fixed Issues

$ #39607
PROPOSAL: #39607 (comment)

Tests

Go to Profile.
Add or change the Display name.
Use FAB to assign a task.
Add a title and click "Next" to share somewhere.
Verify that the Display name of selfDM option is updated.

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Go to Profile.
Add or change the Display name.
Use FAB to assign a task.
Add a title and click "Next" to share somewhere.
Verify that the Display name of selfDM option is updated.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-16.at.15.52.13.mov

Android: mWeb Chrome

Screen.Recording.2024-04-16.at.15.51.43.mov

iOS: Native

Screen.Recording.2024-04-16.at.15.52.50.mov

iOS: mWeb Safari

Screen.Recording.2024-04-16.at.15.51.00.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-16.at.15.50.16.mov

MacOS: Desktop

Screen.Recording.2024-04-16.at.15.54.06.mov

melvin-bot · 2024-04-16T09:01:56Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2024-04-17T02:39:40Z

Precondition: Create a brand new account.
BUG: Crash on new account when saving user name:

Screen.Recording.2024-04-17.at.09.37.24.mov

nkdengineer · 2024-04-17T06:01:00Z

@hungvu193 Updated to fix this case.

hungvu193 · 2024-04-17T06:02:12Z

src/components/OptionListContextProvider.tsx

    });

    const personalDetails = usePersonalDetails();
+    const prevPersonalDetails = useRef(personalDetails);


can we replace this by our existing hook usePrevious?

@hungvu193 I tested and we can use usePrevious hook. Updated to use this hook.

Awesome, let's me test again!

hungvu193 · 2024-04-17T06:20:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mWebAndroid.mov

iOS: Native

IOS.mov

iOS: mWeb Safari

mSafari.mov

MacOS: Chrome / Safari

Chrome.mov

MacOS: Desktop

desktop.mov

hungvu193

LGTM!

bondydaa · 2024-04-17T21:17:37Z

src/components/OptionListContextProvider.tsx

            return newOptions;
        });
+
+        // eslint-disable-next-line react-hooks/exhaustive-deps


what other dependencies is this expecting that we're purposefully ignoring? it looks reports?

@nkdengineer can you help me understand why we added this?

@bondydaa In this case we only want to update the personal detail option and the related report of the changed personal detail. So we're ignoring other dependencies.

got it, can you add that as a comment here then as well so future us can know exactly why/which dependencies we are okay with ignoring?

little bump @nkdengineer on above comment

Updating now.

@bondydaa I added a comment, please help to check again.
cc @hungvu193

little bump @bondydaa for final review

nkdengineer · 2024-04-26T02:29:33Z

@bondydaa Any update here.

bondydaa

sorry went OOO last week, 👍

OSBotify · 2024-04-29T16:49:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-29T23:33:48Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.67-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-04-30T01:13:45Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.68-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-04-30T02:34:33Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.67-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

francoisl · 2024-04-30T19:04:09Z

src/components/OptionListContextProvider.tsx

+            newReportOption: OptionsListUtils.SearchOption<Report>;
+        }> = [];
+
+        Object.keys(personalDetails).forEach((accoutID) => {


Heads up, this caused the regression #41275

(Also, accountID 😄)

Thanks for handling it while I'm AFK, that's weird that I already tested logged out case but couldn't see the crash.
I should have tested it more careful next time!

OSBotify · 2024-05-01T02:37:55Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.68-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

parasharrajat · 2025-02-17T09:08:47Z

src/components/OptionListContextProvider.tsx

+        Object.keys(personalDetails).forEach((accoutID) => {
+            const prevPersonalDetail = prevPersonalDetails?.[accoutID];
+            const personalDetail = personalDetails?.[accoutID];
+
+            if (isEqualPersonalDetail(prevPersonalDetail, personalDetail)) {
+                return;
+            }
+
+            Object.values(reports ?? {})
+                .filter((report) => Boolean(report?.participantAccountIDs?.includes(Number(accoutID))) || (ReportUtils.isSelfDM(report) && report?.ownerAccountID === Number(accoutID)))
+                .forEach((report) => {
+                    if (!report) {
+                        return;
+                    }
+                    const newReportOption = OptionsListUtils.createOptionFromReport(report, personalDetails);
+                    const replaceIndex = options.reports.findIndex((option) => option.reportID === report.reportID);
+                    newReportOptions.push({
+                        newReportOption,
+                        replaceIndex,
+                    });
+                });
+        });


This is quite expensive and had a bad performance when we had to do it for all reports/ first render on a fresh login. #54050

Update report option when personal detail is changed

26810a9

nkdengineer mentioned this pull request Apr 12, 2024

[HOLD for payment 2024-05-08] [$250] Profile - Display name is not updating in "Share Somewhere" section #39607

Closed

6 tasks

nkdengineer added 4 commits April 12, 2024 16:39

remove unnecessary change

7f41cf8

fix selfDM case

8cef454

Merge branch 'main' into fix/39607

16603a0

fix lint

2cfca31

nkdengineer marked this pull request as ready for review April 16, 2024 09:01

nkdengineer requested a review from a team as a code owner April 16, 2024 09:01

melvin-bot bot requested review from hungvu193 and removed request for a team April 16, 2024 09:01

run prettier

f3abe81

nkdengineer added 2 commits April 17, 2024 12:47

Merge branch 'main' into fix/39607

65b9aa3

safely get personal detail

e351997

hungvu193 reviewed Apr 17, 2024

View reviewed changes

update to use usePrevious hook

1fecd97

hungvu193 approved these changes Apr 17, 2024

View reviewed changes

melvin-bot bot requested a review from bondydaa April 17, 2024 06:20

bondydaa reviewed Apr 17, 2024

View reviewed changes

nkdengineer added 2 commits April 22, 2024 14:49

Merge branch 'main' into fix/39607

9f166ff

add explaination comment

d726f3f

bondydaa approved these changes Apr 29, 2024

View reviewed changes

bondydaa merged commit 41ed79d into Expensify:main Apr 29, 2024

github-actions bot mentioned this pull request Apr 29, 2024

Deploy Checklist: New Expensify 2024-04-29 #41266

Closed

74 tasks

francoisl reviewed Apr 30, 2024

View reviewed changes

parasharrajat reviewed Feb 17, 2025

View reviewed changes

Conversation

nkdengineer commented Apr 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 16, 2024

Uh oh!

hungvu193 commented Apr 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nkdengineer commented Apr 17, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Apr 17, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nkdengineer commented Apr 26, 2024

Uh oh!

bondydaa left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 29, 2024

Uh oh!

OSBotify commented Apr 29, 2024

Uh oh!

OSBotify commented Apr 30, 2024

Uh oh!

OSBotify commented Apr 30, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hungvu193 May 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 1, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nkdengineer commented Apr 12, 2024 •

edited

Loading

hungvu193 commented Apr 17, 2024 •

edited

Loading

hungvu193 May 1, 2024 •

edited

Loading