feature: add props isSplit to button with dropdown by nkdengineer · Pull Request #40278 · Expensify/App

nkdengineer · 2024-04-16T10:03:57Z

Details

Fixed Issues

$ #39832
PROPOSAL: #39832 (comment)

Tests

Go to workspace setting
Enable all features: distance rates, categories, tags, taxes
Select rows of data using the checkboxes on the left side of the row
Verify that: A dropdown button with no split is displayed in top right
Click to this button
Verify that: A dropdown is working fine

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to workspace setting
Enable all features: distance rates, categories, tags, taxes
Select rows of data using the checkboxes on the left side of the row
Verify that: A dropdown button with no split is displayed in top right
Click to this button
Verify that: A dropdown is working fine

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-mweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…ix/39832

melvin-bot · 2024-04-17T09:38:47Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

nkdengineer · 2024-04-22T02:26:49Z

@abdulrahuman5196 Please help to review the PR when you have a chance.

abdulrahuman5196 · 2024-04-22T14:14:12Z

Hi, Got stuck. Will review within one day.

luacmartins · 2024-04-22T19:16:10Z

src/components/Button/index.tsx

    shouldShowRightIcon?: boolean;
+
+    /** The custom icon to display to the right of the text */
+    customRightIcon?: React.ReactNode;


I'm not sure that I'm following this. We already have an iconRight prop, can't we just reuse that and shouldShowRightIcon?

In this case we need pass a custom style right icon
because: in custom icon we have style

medium={isButtonSizeLarge} small={!isButtonSizeLarge}

but with default right icon we have style

large={isButtonSizeLarge} medium={!isButtonSizeLarge}

I'm still not sure that I follow. I don't think we should add another Icon prop just to use different styles. Can we just compare the sizes instead?

large={buttonSize === CONST.DROPDOWN_BUTTON_SIZE.LARGE} medium={buttonSize === CONST.DROPDOWN_BUTTON_SIZE.MEDIUM} small={buttonSize === CONST.DROPDOWN_BUTTON_SIZE.SMALL}

@luacmartins The current style of the button and the style of the icon are not consistent:

when the button has a size of large, the icon only has a size of medium

when the button has a size other than large, it has a small size

So we can't just compare the sizes.

So are you saying that when we have a split button, the logic should be:

large={isButtonSizeLarge} medium={!isButtonSizeLarge}

but for non-split buttons it's supposed to be:

large={isButtonSizeLarge} medium={!isButtonSizeLarge}

Is that right? If so, I think we can derive those from a combination of isSplitButton and the button size.

@luacmartins i just updated code, please check again 🙏

src/components/Button/index.tsx

src/components/ButtonWithDropdownMenu/index.tsx

src/components/ButtonWithDropdownMenu/types.ts

luacmartins

Left another comment about the additional Icon prop

luacmartins

We're close

luacmartins

LGTM. Could you also use the new split button in the new SearchFiltersNarrow page, please?

luacmartins · 2024-04-25T21:49:12Z

@nkdengineer lint is also failing

nkdengineer · 2024-04-26T08:26:34Z

result.mov

@luacmartins this is result when i use the new split button in the new SearchFiltersNarrow page
But it doesn't have left icon
What do you think?

luacmartins · 2024-04-26T12:49:07Z

Looks good, but we need the left icon too. Does this button not support that?

nkdengineer · 2024-04-26T15:21:23Z

@luacmartins Currently, the button only supports the right icon and does not have logic support for left icon

luacmartins · 2024-04-26T15:37:14Z

@nkdengineer ok, let's leave it as is then, sorry about the distraction

luacmartins · 2024-04-26T15:55:20Z

@abdulrahuman5196 all yours

abdulrahuman5196 · 2024-04-26T16:47:27Z

Sorry about the delay. Will work on review.

abdulrahuman5196 · 2024-04-29T13:51:39Z

Checking now

abdulrahuman5196 · 2024-04-29T15:40:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-29.at.8.28.24.PM.mp4

Android: mWeb Chrome

Screen.Recording.2024-04-29.at.8.29.59.PM.mp4

iOS: Native

Screen.Recording.2024-04-29.at.8.24.07.PM.mp4

iOS: mWeb Safari

Screen.Recording.2024-04-29.at.8.26.17.PM.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-04-29.at.8.10.37.PM.mp4

MacOS: Desktop

Screen.Recording.2024-04-29.at.8.15.45.PM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @luacmartins

🎀 👀 🎀
C+ Reviewed

OSBotify · 2024-04-29T16:11:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-29T23:33:54Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.67-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-04-30T01:13:51Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.68-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-04-30T02:34:39Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.67-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-05-01T02:38:01Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.68-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aimane-chnaif · 2024-08-12T05:48:16Z

src/components/ButtonWithDropdownMenu/index.tsx

+                        ref={(ref) => {
+                            caretButton.current = ref;
+                        }}


This caused style regression
More details (root cause & solution): #46127 (comment)

rushatgabhane · 2024-08-21T20:59:40Z

src/components/ButtonWithDropdownMenu/index.tsx

-                        ref={buttonRef}
-                        onPress={(event) => onPress(event, selectedItem.value)}
+                        ref={(ref) => {
+                            caretButton.current = ref;


This PR caused a bug - Tapping Pay button in an invoice crashes the app

Fixed here - #44919 (comment)

filip-solecki · 2024-08-27T18:41:15Z

src/components/Button/index.tsx

+                                <Icon
+                                    src={iconRight}
+                                    fill={iconFill ?? (success || danger ? theme.textLight : theme.icon)}
+                                    small={medium}


why was it set like that? is there any specific reason? Right now I need to add small icon handling and I'll adjust it in this way:

small={small}
medium={medium}
large={large}

may it broke something?
@nkdengineer

nkdengineer added 5 commits April 16, 2024 16:58

feature: add props isSplit to button with dropdown

65e1251

use useCallBack to get icon right

98fef23

Merge branch 'main' of https://github.com/nkdengineer/App into fix/39832

74ae64d

Merge branch 'fix/39832' of https://github.com/nkdengineer/App into f…

559d293

…ix/39832

fix add custom icon right button

a9d6b4b

nkdengineer marked this pull request as ready for review April 17, 2024 09:38

nkdengineer requested a review from a team as a code owner April 17, 2024 09:38

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team April 17, 2024 09:38

luacmartins self-requested a review April 22, 2024 19:03

luacmartins requested changes Apr 22, 2024

View reviewed changes

nkdengineer added 2 commits April 23, 2024 15:10

Merge branch 'main' into fix/39832

d80eeb7

Use more reasonable variable names

0997b0a

luacmartins requested review from luacmartins April 23, 2024 15:10

luacmartins requested changes Apr 23, 2024

View reviewed changes

nkdengineer added 2 commits April 25, 2024 15:01

Merge branch 'main' into fix/39832

7d9777f

fix: remmove custom right icon button

b47c929

luacmartins reviewed Apr 25, 2024

View reviewed changes

nkdengineer added 2 commits April 26, 2024 10:05

fix lint

3fc5ecf

Merge branch 'main' into fix/39832

7ce8eed

luacmartins approved these changes Apr 26, 2024

View reviewed changes

abdulrahuman5196 approved these changes Apr 29, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins April 29, 2024 15:43

luacmartins approved these changes Apr 29, 2024

View reviewed changes

luacmartins merged commit e5beed2 into Expensify:main Apr 29, 2024

github-actions bot mentioned this pull request Apr 29, 2024

Deploy Checklist: New Expensify 2024-04-29 #41266

Closed

74 tasks

izarutskaya mentioned this pull request Apr 30, 2024

Taxes - Taxes dropdown button has lesser width compared to tags/categories/distance rates #41311

Closed

6 tasks

melvin-bot bot mentioned this pull request May 1, 2024

[HOLD for payment 2024-05-08] [$250] Update "X selected" button above table views to be a dropdown button instead of a split button #39832

Closed

6 tasks

nyomanjyotisa mentioned this pull request Jul 25, 2024

fix Xero action modal positioning and display circle icon instead #46127

Merged

50 tasks

aimane-chnaif reviewed Aug 12, 2024

View reviewed changes

aimane-chnaif mentioned this pull request Aug 12, 2024

[HOLD for payment 2024-08-09] [$250] Xero - Xero action modal appears below the button and overlaps with the composer #45607

Closed

6 tasks

rushatgabhane reviewed Aug 21, 2024

View reviewed changes

rushatgabhane mentioned this pull request Aug 21, 2024

[HOLD for payment 2024-08-14] [$250] Tapping Pay button in an invoice crashes the app #44919

Closed

6 tasks

filip-solecki reviewed Aug 27, 2024

View reviewed changes

Conversation

nkdengineer commented Apr 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 17, 2024

Uh oh!

nkdengineer commented Apr 22, 2024

Uh oh!

abdulrahuman5196 commented Apr 22, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Apr 25, 2024

Uh oh!

nkdengineer commented Apr 26, 2024

Uh oh!

luacmartins commented Apr 26, 2024

Uh oh!

nkdengineer commented Apr 26, 2024

Uh oh!

luacmartins commented Apr 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luacmartins commented Apr 26, 2024

Uh oh!

abdulrahuman5196 commented Apr 26, 2024

Uh oh!

abdulrahuman5196 commented Apr 29, 2024

Uh oh!

abdulrahuman5196 commented Apr 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 29, 2024

Uh oh!

OSBotify commented Apr 29, 2024

Uh oh!

OSBotify commented Apr 30, 2024

Uh oh!

OSBotify commented Apr 30, 2024

Uh oh!

OSBotify commented May 1, 2024

Uh oh!

Choose a reason for hiding this comment

nkdengineer commented Apr 16, 2024 •

edited

Loading

luacmartins commented Apr 26, 2024 •

edited

Loading

abdulrahuman5196 commented Apr 29, 2024 •

edited

Loading

rushatgabhane Aug 21, 2024 •

edited

Loading