Update custom messages in the onboarding flow by tienifr · Pull Request #40328 · Expensify/App

tienifr · 2024-04-17T02:07:41Z

Details

This PR updates custom messages in the onboarding flow.

Fixed Issues

$ #40261
PROPOSAL: #40261 (comment)

Tests

Go to /onboarding (or Go to Settings > About > Troubleshoot >> Press Navigate next to Onboarding Flow section)
Complete personal details onboarding step
Select a purpose
Verify Concierge shows welcome message accordingly as specified in OP

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Go to /onboarding
Complete personal details onboarding step
Select a purpose
Verify Concierge shows welcome message accordingly as specified in OP

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-17.at.09.43.12-compressed.mov

Android: mWeb Chrome

Screen.Recording.2024-04-17.at.09.28.01-compressed.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-04-17.at.09.18.00-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-17.at.09.08.53-compressed.mov

MacOS: Desktop

melvin-bot · 2024-04-17T02:24:28Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2024-04-17T02:25:52Z

There's an existing issue on main on iOS:

Log in with a new account
Press Concierge chat
Verify that the chat does not open
Complete onboarding flow
Repeat step 2 and 3

jayeshmangwani · 2024-04-17T08:18:07Z

@tienifr For the first step in the Tests section, please add the below step as an alternate Navigate to onboarding flow through Settings > About > Troubleshoot and the temporary Onboarding flow button.

jayeshmangwani · 2024-04-17T08:50:30Z

src/libs/actions/Report.ts

+function completeEngagementModal(choice: ValueOf<typeof CONST.ONBOARDING_CHOICES>, text?: string) {
    const conciergeAccountID = PersonalDetailsUtils.getAccountIDsByLogins([CONST.EMAIL.CONCIERGE])[0];
+
+    if (!text) {


@tienifr Please add a comment here on why we added this logic

jayeshmangwani · 2024-04-17T08:57:52Z

src/CONST.ts

            '\n' +
            "To manage your team's expenses, create a workspace to keep everything in one place. Here's how:\n" +
            '1. From the home screen, click the green + button > New Workspace\n' +
            '2. Give your workspace a name (e.g. “Sales team expenses”).\n' +


@danielrvidal @MariaHCD There are some inconsistencies in the double quotation marks. Here, we are using the Left Double Quotation Mark and the Right Double Quotation Mark in “Sales team expenses”, IMO, it should just use the simple quotation mark like other CONSTs.

The same inconsistency is with Track my business expenses to file taxes copy.

In the description, we have below text for the second point:

Give your workspace a name (e.g. "My business expenses”).

But here for the "My business expenses”, we are using simple quotation marks for the opening and for closing, we are using different quotation marks

For: Track and budget personal spend

'2. Give your workspace a name (e.g. "My expenses”).\n' +

It should have used same quotation marks in "My expenses”

I agree, let's use the simple quotation marks in all the copy here 👍🏼

jayeshmangwani · 2024-04-17T09:11:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mWeb-chrome.mov

iOS: Native

iOS.mov

iOS: mWeb Safari

mWeb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

jayeshmangwani

Changes LGTM 🎉

Asked the contributor here to add a comment #40328 (comment)

Found some inconsistencies in the copy of the onboarding texts and added a comment here #40328 (comment)

cc: @MariaHCD

OSBotify · 2024-04-17T10:35:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-18T05:01:23Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.4.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-22T15:02:22Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

update custom onboarding messages

094c004

tienifr marked this pull request as ready for review April 17, 2024 02:24

tienifr requested a review from a team as a code owner April 17, 2024 02:24

melvin-bot bot requested review from jayeshmangwani and removed request for a team April 17, 2024 02:24

tienifr mentioned this pull request Apr 17, 2024

[Awaiting Payment April 30th] [$250] [Guided Setup] Update custom messages in the onboarding flow #40261

Closed

jayeshmangwani reviewed Apr 17, 2024

View reviewed changes

jayeshmangwani approved these changes Apr 17, 2024

View reviewed changes

melvin-bot bot requested a review from MariaHCD April 17, 2024 09:15

tienifr added 2 commits April 17, 2024 16:26

add comment

f972126

use simple quotation mark

e8ccd30

MariaHCD approved these changes Apr 17, 2024

View reviewed changes

MariaHCD merged commit cd7db88 into Expensify:main Apr 17, 2024

github-actions bot mentioned this pull request Apr 18, 2024

Deploy Checklist: New Expensify 2024-04-18 #40392

Closed

kbecciv mentioned this pull request Apr 18, 2024

[$250] Onboarding- After finishing "onboarding" and switching to DM, an error appears in the console #40458

Closed

6 tasks

Conversation

tienifr commented Apr 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 17, 2024

Uh oh!

tienifr commented Apr 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jayeshmangwani commented Apr 17, 2024

Uh oh!

jayeshmangwani Apr 17, 2024

Choose a reason for hiding this comment

Uh oh!

tienifr Apr 17, 2024

Choose a reason for hiding this comment

Uh oh!

jayeshmangwani Apr 17, 2024

Choose a reason for hiding this comment

Uh oh!

jayeshmangwani Apr 17, 2024

Choose a reason for hiding this comment

Uh oh!

jayeshmangwani Apr 17, 2024

Choose a reason for hiding this comment

Uh oh!

MariaHCD Apr 17, 2024

Choose a reason for hiding this comment

Uh oh!

tienifr Apr 17, 2024

Choose a reason for hiding this comment

Uh oh!

jayeshmangwani commented Apr 17, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

jayeshmangwani left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 17, 2024

Uh oh!

OSBotify commented Apr 18, 2024

Uh oh!

OSBotify commented Apr 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tienifr commented Apr 17, 2024 •

edited

Loading

tienifr commented Apr 17, 2024 •

edited

Loading