Fix/pdf not showing for money request by ishpaul777 · Pull Request #40385 · Expensify/App

ishpaul777 · 2024-04-17T22:35:06Z

Details

Fixed Issues

$ https://expensify.slack.com/archives/C01GTK53T8Q/p1713382047884229
$ #40476
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Open FAB -> click submit expense
Enter a random amount
click any of report then click next.
Add a pdf as receipt by clicking on three dot in top left.
Verify pdf is shown as expected on confirmation page.

Offline tests

QA Steps

Verify that no errors appear in the JS console

Open FAB -> click submit expense
Enter a random amount
click any of report then click next.
Add a pdf as receipt by clicking on three dot in top left.
Verify pdf is shown as expected on confirmation page.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-04-17.at.2.17.36.AM.mov

MacOS: Desktop

melvin-bot · 2024-04-17T22:51:50Z

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-04-17T22:52:11Z

@thienlnam Can you please help review this one from #38709

thienlnam · 2024-04-17T22:54:22Z

src/components/MoneyTemporaryForRefactorRequestConfirmationList.tsx

            isLocalFile && Str.isPDF(receiptFilename) ? (
                <PDFThumbnail
                    // eslint-disable-next-line @typescript-eslint/non-nullable-type-assertion-style
-                    previewSourceURL={resolvedThumbnail as string}


Why does this fix this? I would imagine that the thumbnail should be the source for <PDFThumbnail?

This was like this before, thats exactly what made me believe thumbnail goes here lol

Could we see why this is failing? or what is even in resolvedThumbnail?

Perhaps we just change it to this
resolvedThumbnail || resolvedReceiptImage || ''

Yep i'll give this fair look again tomorrow, currently got afk

Perhaps we just change it to this
resolvedThumbnail || resolvedReceiptImage || ''

No need IMO, local files don't have thumbnail:

App/src/libs/ReceiptUtils.ts

Lines 47 to 49 in 3cf796c

if ((isReceiptImage || isReceiptPDF) && typeof path === 'string' && (path.startsWith('blob:') || path.startsWith('file:'))) {

return {image: path, isLocalFile: true, filename};

}

aldo-expensify · 2024-04-18T22:02:45Z

This is fixing #40476

aldo-expensify · 2024-04-18T22:07:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

aldo-expensify · 2024-04-18T22:31:19Z

Chatted with @thienlnam , will proceed with this fix for now

OSBotify · 2024-04-18T22:38:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…ey-request Fix/pdf not showing for money request (cherry picked from commit 1db9087)

…g-40385-1 🍒 Cherry pick PR #40385 to staging 🍒

OSBotify · 2024-04-19T00:10:50Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.4.63-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-22T15:02:43Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ishpaul777 and others added 5 commits April 16, 2024 01:50

Merge branch 'Expensify:main' into main

177ccf4

Merge branch 'Expensify:main' into main

f62c64e

Merge branch 'Expensify:main' into main

be1b50f

Merge branch 'Expensify:main' into main

719c1ed

fixes the issue

1ca5520

ishpaul777 force-pushed the fix/pdf-not-showing-for-money-request branch from edde210 to 1ca5520 Compare April 17, 2024 22:41

ishpaul777 marked this pull request as ready for review April 17, 2024 22:51

ishpaul777 requested a review from a team as a code owner April 17, 2024 22:51

melvin-bot bot requested review from cristipaval and removed request for a team April 17, 2024 22:51

thienlnam reviewed Apr 17, 2024

View reviewed changes

eh2077 mentioned this pull request Apr 18, 2024

Remove MoneyRequestConfirmationList and replace to MoneyTemporaryForRefactorRequestConfirmationList #40176

Merged

50 tasks

ishpaul777 and others added 2 commits April 19, 2024 00:17

Merge branch 'Expensify:main' into main

06eb17d

Merge branch 'main' into fix/pdf-not-showing-for-money-request

2f05d22

allgandalf mentioned this pull request Apr 18, 2024

[TS migration] Migrate MoneyTemporaryForRefactorRequestConfirmationList.js component to TypeScript #37181

Merged

50 tasks

aldo-expensify approved these changes Apr 18, 2024

View reviewed changes

aldo-expensify mentioned this pull request Apr 18, 2024

Submit Expense - 'No PDF file specified' shown on confirmation page after adding PDF receipt #40476

Closed

6 tasks

aldo-expensify merged commit 1db9087 into Expensify:main Apr 18, 2024

OSBotify pushed a commit that referenced this pull request Apr 18, 2024

Merge pull request #40385 from ishpaul777/fix/pdf-not-showing-for-mon…

090c76d

…ey-request Fix/pdf not showing for money request (cherry picked from commit 1db9087)

os-botify bot mentioned this pull request Apr 18, 2024

🍒 Cherry pick PR #40385 to staging 🍒 #40516

Closed

OSBotify pushed a commit that referenced this pull request Apr 18, 2024

Merge pull request #40385 from ishpaul777/fix/pdf-not-showing-for-mon…

e0d530b

…ey-request Fix/pdf not showing for money request (cherry picked from commit 1db9087)

os-botify bot mentioned this pull request Apr 18, 2024

🍒 Cherry pick PR #40385 to staging 🍒 #40521

Merged

48 tasks

thienlnam added a commit that referenced this pull request Apr 18, 2024

Merge pull request #40521 from Expensify/thienlnam-cherry-pick-stagin…

b33678d

…g-40385-1 🍒 Cherry pick PR #40385 to staging 🍒

github-actions bot mentioned this pull request Apr 18, 2024

Deploy Checklist: New Expensify 2024-04-18 #40392

Closed

	if ((isReceiptImage \|\| isReceiptPDF) && typeof path === 'string' && (path.startsWith('blob:') \|\| path.startsWith('file:'))) {
	return {image: path, isLocalFile: true, filename};
	}

Conversation

ishpaul777 commented Apr 17, 2024 • edited by aldo-expensify Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 17, 2024

Uh oh!

ishpaul777 commented Apr 17, 2024

Uh oh!

thienlnam Apr 17, 2024

Choose a reason for hiding this comment

Uh oh!

ishpaul777 Apr 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thienlnam Apr 17, 2024

Choose a reason for hiding this comment

Uh oh!

ishpaul777 Apr 17, 2024

Choose a reason for hiding this comment

Uh oh!

aldo-expensify Apr 18, 2024

Choose a reason for hiding this comment

Uh oh!

aldo-expensify commented Apr 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aldo-expensify commented Apr 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

aldo-expensify commented Apr 18, 2024

Uh oh!

OSBotify commented Apr 18, 2024

Uh oh!

OSBotify commented Apr 19, 2024

Uh oh!

OSBotify commented Apr 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ishpaul777 commented Apr 17, 2024 •

edited by aldo-expensify

Loading

ishpaul777 Apr 17, 2024 •

edited

Loading

aldo-expensify commented Apr 18, 2024 •

edited

Loading

aldo-expensify commented Apr 18, 2024 •

edited

Loading