Skip to content

[CP Staging] Revert "Fixed getting two magic codes upon signing in once"#40690

Merged
mountiny merged 1 commit intomainfrom
revert-30849-getting_two_magic_codes_upon_signing_once_30181
Apr 22, 2024
Merged

[CP Staging] Revert "Fixed getting two magic codes upon signing in once"#40690
mountiny merged 1 commit intomainfrom
revert-30849-getting_two_magic_codes_upon_signing_once_30181

Conversation

@mountiny
Copy link
Copy Markdown
Contributor

@mountiny mountiny commented Apr 22, 2024 •
edited
Loading

Straight reverts #30849

To fix a deploy blocker #40498

@mountiny mountiny self-assigned this Apr 22, 2024
@mountiny mountiny requested a review from a team as a code owner April 22, 2024 12:49
@melvin-bot melvin-bot bot requested review from nkuoch and removed request for a team April 22, 2024 12:50
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Apr 22, 2024

@nkuoch Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny mountiny mentioned this pull request Apr 22, 2024
Closed
6 tasks
@mountiny
Copy link
Copy Markdown
Contributor Author

mountiny commented Apr 22, 2024

Straight revert, no conflicts occured, checklists not required

@mountiny mountiny merged commit c57f281 into main Apr 22, 2024
@mountiny mountiny deleted the revert-30849-getting_two_magic_codes_upon_signing_once_30181 branch April 22, 2024 12:58
@melvin-bot melvin-bot bot added the Emergency label Apr 22, 2024
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Apr 22, 2024

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny
Copy link
Copy Markdown
Contributor Author

mountiny commented Apr 22, 2024

This is a straight revert, tests were passing and only the checklists are missing as its straight revert

OSBotify pushed a commit that referenced this pull request Apr 22, 2024
@mountiny @OSBotify
Merge pull request #40690 from Expensify/revert-30849-getting_two_mag…
0c5929f 
…ic_codes_upon_signing_once_30181

[CP Staging] Revert "Fixed getting two magic codes upon signing in once"

(cherry picked from commit c57f281)
@github-actions github-actions bot mentioned this pull request Apr 22, 2024
Closed
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Apr 22, 2024

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.63-21 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Apr 22, 2024

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.63-21 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Apr 22, 2024

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nkuoch nkuoch nkuoch approved these changes

Assignees

@mountiny mountiny

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mountiny @OSBotify @nkuoch