Skip to content

Make all text selectable #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sketchydroide merged 3 commits into from
Sep 8, 2020
Merged

Make all text selectable #407

sketchydroide merged 3 commits into from
Sep 8, 2020

Conversation

@Julesssss
Copy link
Contributor

@Julesssss Julesssss commented Sep 4, 2020 •
edited
Loading

Fixes: #260

  • Make HTML comments selectable on all platforms to allow copy/paste.
  • Make regular text comments selectable on mobile

@Julesssss Julesssss self-assigned this Sep 4, 2020
@Julesssss Julesssss marked this pull request as ready for review September 4, 2020 16:31
@Julesssss Julesssss mentioned this pull request Sep 4, 2020
Closed
@Julesssss Julesssss requested a review from a team September 4, 2020 16:45
@botify botify requested review from sketchydroide and removed request for a team September 4, 2020 16:45
sketchydroide
sketchydroide approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@sketchydroide sketchydroide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Julesssss Julesssss marked this pull request as draft September 7, 2020 10:58
@sketchydroide
Copy link
Contributor

sketchydroide commented Sep 7, 2020

Hey @Julesssss this still seem to be in draft, do you wan to make it ready for review?

@Julesssss
Copy link
Contributor Author

Julesssss commented Sep 7, 2020

@sketchydroide need to make a final check, will give you a heads up once it's ready

@sketchydroide
Copy link
Contributor

sketchydroide commented Sep 8, 2020

Sorry mate, but can you add the [WIP] to the title, just makes it clear while looking at my K2

@Julesssss Julesssss changed the title Make HTML text selectable [WIP] Make HTML text selectable Sep 8, 2020
@Julesssss
Copy link
Contributor Author

Julesssss commented Sep 8, 2020

Sure, done

@Julesssss Julesssss marked this pull request as ready for review September 8, 2020 14:41
@Julesssss
Copy link
Contributor Author

Julesssss commented Sep 8, 2020

Not making any further changes, feel free to merge @sketchydroide 👍

@Julesssss Julesssss changed the title [WIP] Make HTML text selectable Make HTML text selectable Sep 8, 2020
@Julesssss Julesssss changed the title Make HTML text selectable Make all text selectable Sep 8, 2020
sketchydroide
sketchydroide approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@sketchydroide sketchydroide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM

@sketchydroide sketchydroide merged commit ff11e49 into master Sep 8, 2020
@sketchydroide sketchydroide deleted the jules-selectable-html-text branch September 8, 2020 15:21
@mallenexpensify
Copy link
Contributor

mallenexpensify commented Sep 8, 2020

This appears to be fixed to me, I've tested a few times on Desktop today

@atef1995 atef1995 mentioned this pull request Oct 23, 2023
Open
@chiragsalian chiragsalian mentioned this pull request Oct 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sketchydroide sketchydroide sketchydroide approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Julesssss Julesssss

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable copy/pasting all content on web

4 participants

@Julesssss @sketchydroide @mallenexpensify