fix error when clicking on attachment note by nkdengineer · Pull Request #40844 · Expensify/App

nkdengineer · 2024-04-24T00:28:40Z

Details

We will fix the issue "Hmm its not here page displayed when clicking on thumbnail" based on these two comments: [HOLD for payment 2024-06-11] [$500] Private notes - Hmm its not here page displayed when clicking on thumbnail #38835 (comment) and [HOLD for payment 2024-06-11] [$500] Private notes - Hmm its not here page displayed when clicking on thumbnail #38835 (comment)

Fixed Issues

Tests

Navigate to any report
Click on header > Private notes
Add markdown image to private notes:

Test image 1![img1](https://images.unsplash.com/photo-1709983723739-d72ea88434dd?q=80&w=2940&auto=format&fit=crop&ixlib=rb-4.0.3&ixid=M3wxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8fA%3D%3D)   Test image 2  ![img2](https://images.unsplash.com/photo-1578645635737-6a88e706e0f1?q=80&w=1964&auto=format&fit=crop&ixlib=rb-4.0.3&ixid=M3wxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8fA%3D%3D) Test image 3 ![img3](https://media.istockphoto.com/id/665037818/vi/anh/%C4%91%C6%B0%E1%BB%9Dng-b%E1%BA%AFt-%C4%91%E1%BA%A7u-tr%C3%AAn-%C4%91%C6%B0%E1%BB%9Dng-cao-t%E1%BB%91c.jpg?s=2048x2048&w=is&k=20&c=EF193CsvWSvPylYD3Ltm7ENGN3AGVpb4fJlSi4dpl5w=)

Click on 'Private notes'
Click on image
Verify image should be opened in the attachment carousel just like any image added to Expensify Chat

Verify that no errors appear in the JS console

Offline tests

QA Steps

Navigate to any report
Click on header > Private notes
Add markdown image to private notes:

Test image 1![img1](https://images.unsplash.com/photo-1709983723739-d72ea88434dd?q=80&w=2940&auto=format&fit=crop&ixlib=rb-4.0.3&ixid=M3wxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8fA%3D%3D)   Test image 2  ![img2](https://images.unsplash.com/photo-1578645635737-6a88e706e0f1?q=80&w=1964&auto=format&fit=crop&ixlib=rb-4.0.3&ixid=M3wxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8fA%3D%3D) Test image 3 ![img3](https://media.istockphoto.com/id/665037818/vi/anh/%C4%91%C6%B0%E1%BB%9Dng-b%E1%BA%AFt-%C4%91%E1%BA%A7u-tr%C3%AAn-%C4%91%C6%B0%E1%BB%9Dng-cao-t%E1%BB%91c.jpg?s=2048x2048&w=is&k=20&c=EF193CsvWSvPylYD3Ltm7ENGN3AGVpb4fJlSi4dpl5w=)

Click on 'Private notes'
Click on image
Verify image should be opened in the attachment carousel just like any image added to Expensify Chat

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-25.at.15.37.22.mov

Android: mWeb Chrome

Screen.Recording.2024-04-25.at.15.23.32.mov

iOS: Native

Screen.Recording.2024-04-25.at.15.38.26.mov

iOS: mWeb Safari

Screen.Recording.2024-04-25.at.15.26.21.mov

MacOS: Chrome / Safari

output.mp4

MacOS: Desktop

output.mp4

melvin-bot · 2024-04-25T08:04:13Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2024-04-26T15:47:26Z

@nkdengineer Please fix conflicts and can you summarize what you have done in this PR?

nkdengineer · 2024-04-30T10:27:42Z

This PR will create a new route:

  ATTACHMENTS: {
        route: 'attachment',
        getRoute: (reportID: string, type: ValueOf<typeof CONST.ATTACHMENT_TYPE>, url: string, accountID?: number) =>
            `attachment?source=${encodeURIComponent(url)}&type=${type}${reportID ? `&reportID=${reportID}` : ''}${accountID ? `&accountID=${accountID}` : ''}` as const,

that can be used in report attachments, note attachments and any type of attachments in the future

nkdengineer · 2024-05-03T10:48:14Z

@shubham1206agra Pls help review the PR when you have a chance. Thanks

shubham1206agra · 2024-05-04T15:37:18Z

@nkdengineer Please merge main here.

nkdengineer · 2024-05-07T07:29:06Z

@shubham1206agra I merged main

shubham1206agra · 2024-05-07T12:24:48Z

src/CONST.ts

    },
+    ATTACHMENT_TYPE: {
+        REPORT: 'r',
+        REPORT_ACTION: 'a',


Can you give me example of type a, and s?

Now, these types are not being used. I think we can remove these and add them in the future.

Why these types were added then?
Just confirming.

I added them based on the comment

@kidroca Can you help me understand why do we need this?

The comment is just an example, you can skip the keys that don't have application here

@nkdengineer Can you make the change here?

@shubham1206agra I removed it

kidroca

I've reviewed the code and left two comments regarding potential improvements. Please have a look and let me know if you have any questions.

src/components/Attachments/AttachmentCarousel/extractAttachmentsFromNote.ts

src/components/Attachments/AttachmentCarousel/index.native.tsx

shubham1206agra · 2024-05-13T13:51:19Z

@nkdengineer Bump on the comments.

nkdengineer · 2024-05-13T14:40:10Z

@shubham1206agra Sure. I am working on it

nkdengineer · 2024-05-13T22:00:16Z

@shubham1206agra I fixed comments #40844 (comment) and #40844 (comment)

shubham1206agra · 2024-05-19T12:08:31Z

@nkdengineer Can you merge main here please?

nkdengineer · 2024-05-20T18:37:54Z

@shubham1206agra please check again

shubham1206agra · 2024-05-22T14:23:30Z

Screen.Recording.2024-05-22.at.7.52.26.PM.mov

@nkdengineer Wrong attachment is getting opened.

nkdengineer · 2024-05-24T01:02:48Z

@shubham1206agra Can you give me a tip to reproduce this bug? Currently I cannot reproduce it

nkdengineer · 2024-05-27T08:44:09Z

@shubham1206agra Do you have any feedback about my comment above. Here is the video from my side:

Screen.Recording.2024-05-27.at.15.42.45.mov

shubham1206agra · 2024-05-27T12:05:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-05-27.at.5.08.49.PM.mov

iOS: Native

Screen.Recording.2024-05-27.at.5.23.28.PM.mp4

iOS: mWeb Safari

Screen.Recording.2024-05-27.at.5.06.13.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-22.at.7.44.06.PM.mov

MacOS: Desktop

Screen.Recording.2024-05-27.at.5.16.08.PM.mov

nkdengineer · 2024-05-30T07:39:38Z

@chiragsalian Can you help review this one?

chiragsalian

LGTM

OSBotify · 2024-05-30T17:47:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-30T21:53:32Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T22:30:02Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-06-04T13:56:04Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.78-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix error when clicking on attachment note

ba9cd58

nkdengineer mentioned this pull request Apr 24, 2024

[HOLD for payment 2024-06-11] [$500] Private notes - Hmm its not here page displayed when clicking on thumbnail #38835

Closed

6 tasks

nkdengineer added 7 commits April 25, 2024 12:35

fix navigation issue

68f9115

fix remove unused change

5d5fe29

fix remove unused change

07cb16f

fix merge main

da2dbb1

fix remove unused change

8d8867d

fix typecheck

7fbaabe

fix lint

c48b0aa

nkdengineer marked this pull request as ready for review April 25, 2024 08:04

nkdengineer requested a review from a team as a code owner April 25, 2024 08:04

melvin-bot bot requested review from shubham1206agra and removed request for a team April 25, 2024 08:04

fix native issue

aef5252

Merge branch 'main' into fix/38835-implement-attachment-screen

a27b27d

fix lint

e59e1ab

fix merge main

313b263

shubham1206agra reviewed May 7, 2024

View reviewed changes

kidroca reviewed May 9, 2024

View reviewed changes

src/components/Attachments/AttachmentCarousel/extractAttachmentsFromNote.ts Show resolved Hide resolved

src/components/Attachments/AttachmentCarousel/index.native.tsx Outdated Show resolved Hide resolved

nkdengineer added 2 commits May 14, 2024 04:18

fix merge main

d563e1f

fix create extractAttachments

14589f8

nkdengineer added 2 commits May 14, 2024 05:11

fix lint

ac97fb6

fix remove redundant attachment type

a4ab1d7

merge main

8a9b035

Merge branch 'main' into fix/38835-implement-attachment-screen

bc4418a

shubham1206agra approved these changes May 27, 2024

View reviewed changes

melvin-bot bot requested a review from chiragsalian May 27, 2024 12:10

Merge branch 'main' into fix/38835-implement-attachment-screen

d4b0743

fix lint

bbaf3bc

chiragsalian approved these changes May 30, 2024

View reviewed changes

chiragsalian merged commit 459173b into Expensify:main May 30, 2024

github-actions bot mentioned this pull request May 30, 2024

Deploy Checklist: New Expensify 2024-05-30 #42872

Closed

95 tasks

Conversation

nkdengineer commented Apr 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 25, 2024

Uh oh!

shubham1206agra commented Apr 26, 2024

Uh oh!

nkdengineer commented Apr 30, 2024

Uh oh!

nkdengineer commented May 3, 2024

Uh oh!

shubham1206agra commented May 4, 2024

Uh oh!

nkdengineer commented May 7, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kidroca left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shubham1206agra commented May 13, 2024

Uh oh!

nkdengineer commented May 13, 2024

Uh oh!

nkdengineer commented May 13, 2024

Uh oh!

shubham1206agra commented May 19, 2024

Uh oh!

nkdengineer commented May 20, 2024

Uh oh!

shubham1206agra commented May 22, 2024

Uh oh!

nkdengineer commented May 24, 2024

Uh oh!

nkdengineer commented May 27, 2024

Uh oh!

shubham1206agra commented May 27, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

nkdengineer commented May 30, 2024

Uh oh!

chiragsalian left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

OSBotify commented Jun 4, 2024

Uh oh!

Reviewers

Assignees

Labels

nkdengineer commented Apr 24, 2024 •

edited

Loading