fix android com.facebook.jni.CppException crash by tienifr · Pull Request #40872 · Expensify/App

tienifr · 2024-04-24T11:49:46Z

Details

Fixed Issues

$ #40699
PROPOSAL: #40699 (comment)

Tests

Open New dot app
Login with gmail account
Create Workspace
Go to workspace profile> Upload photo
Select any photo from device
Avatar should be successfully uploaded

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open New dot app
Login with gmail account
Create Workspace
Go to workspace profile> Upload photo
Select any photo from device
Avatar should be successfully uploaded

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

output.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

tienifr · 2024-04-24T11:56:37Z

@ShridharGoel will review this PR as C+ role based on comment #40699 (comment)

melvin-bot · 2024-04-24T11:56:47Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2024-04-24T11:59:11Z

@ShridharGoel Can you always reproduce this bug in Android?

mountiny · 2024-04-24T14:15:51Z

@ShridharGoel can you please complete the checklist?

ShridharGoel · 2024-04-24T15:51:42Z

Hello, I'm on vacation for 2 days and will test this on Friday.

ShridharGoel · 2024-04-24T15:53:28Z

@tienifr It's difficult to replicate since it's a race condition. Can you try changing the workspace avatar multiple times?

tienifr · 2024-04-25T09:46:23Z

Can you try changing the workspace avatar multiple times

I tried but still could not reproduce. Let me try again.

tienifr · 2024-04-26T07:47:48Z

@ShridharGoel Can you help review the PR once you have a chance? Thanks

ShridharGoel · 2024-04-26T09:05:35Z

Will be testing this today, I was OOO.

ShridharGoel · 2024-04-28T20:07:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-21.at.12.36.24.AM.mov

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

ShridharGoel · 2024-04-28T20:08:23Z

@tienifr Can you complete the author checklist and add the testing steps? We can also do some sanity testing at places where the library is used.

I've tested the workspace avatar uploading flow.

tienifr · 2024-05-02T11:09:51Z

@ShridharGoel I updated the test steps

tienifr · 2024-05-02T11:11:21Z

However, I faced an issue when running android on my device so I could not test.

tienifr · 2024-05-02T11:19:11Z

@mountiny Can you help create an ad-hoc build? Thanks

tienifr · 2024-05-03T04:41:57Z

Now I can run Android on my device and it works well

ShridharGoel · 2024-05-03T05:25:51Z

I'll test again in sometime and then approve.

…

On Fri, May 3, 2024, 10:12 AM Tienifr ***@***.***> wrote: Now I can run Android on my device and it works well — Reply to this email directly, view it on GitHub <#40872 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIPLJHFU4VOE576S777GC2LZAMISVAVCNFSM6AAAAABGWYHPPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSGEYTEMRYGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

tienifr · 2024-05-06T07:23:01Z

Please help review it once you have a chance @ShridharGoel

tienifr · 2024-05-07T07:48:55Z

@mountiny Can you help review this PR? Thanks

mountiny · 2024-05-08T16:19:42Z

@ShridharGoel Making the build for testing too. Now there is a merge freeze but I will review and merge after that is done

github-actions · 2024-05-08T16:53:26Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/40872/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/40872/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/40872/NewExpensify.dmg	https://40872.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mountiny · 2024-05-09T18:39:08Z

@ShridharGoel would you be able to add Android testing video please?

ShridharGoel · 2024-05-13T09:41:13Z

Build is failing locally and Adhoc build keeps asking for update. Can we merge main here and start new adhoc build?

mountiny · 2024-05-13T12:57:50Z

@tienifr Can you please merge main?

tienifr · 2024-05-15T01:10:10Z

@ShridharGoel @mountiny I merged main

ShridharGoel · 2024-05-18T16:31:55Z

@mountiny Can you add the label for adhoc build?

mountiny · 2024-05-20T15:46:13Z

New build is running https://github.com/Expensify/App/actions/runs/9161335268

github-actions · 2024-05-20T16:18:07Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/40872/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/40872/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/40872/NewExpensify.dmg	https://40872.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

ShridharGoel · 2024-05-20T19:08:12Z

Added video.

mountiny

thanks! Waiting for the merge freeze to get lifted!

OSBotify · 2024-05-27T14:24:38Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.4.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-29T09:17:16Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.76-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix android com.facebook.jni.CppException crash

6a7ae7a

tienifr marked this pull request as ready for review April 24, 2024 11:56

tienifr requested a review from a team as a code owner April 24, 2024 11:56

melvin-bot bot removed the request for review from a team April 24, 2024 11:56

melvin-bot bot requested a review from dukenv0307 April 24, 2024 11:56

mountiny removed the request for review from dukenv0307 April 24, 2024 14:15

mountiny assigned tienifr Apr 24, 2024

mountiny added the Ready To Build label Apr 24, 2024

This comment has been minimized.

Sign in to view

tienifr added 3 commits May 2, 2024 17:16

fix merge main

39c6688

fix resolve conflict

bab6f07

fix resolve conflict

721ed8e

ShridharGoel approved these changes May 6, 2024

View reviewed changes

ShridharGoel approved these changes May 7, 2024

View reviewed changes

mountiny self-requested a review May 8, 2024 16:19

fix merge main

439349d

mountiny approved these changes May 20, 2024

View reviewed changes

chiragsalian merged commit 1df2d39 into Expensify:main May 24, 2024

This was referenced May 24, 2024

Investigate workflow job failing on main: confirmPassingBuild #42609

Closed

Deploy Checklist: New Expensify 2024-05-27 #42636

Closed

melvin-bot bot mentioned this pull request May 29, 2024

[$250] [HOLD for payment 2024-06-05] Investigate android com.facebook.jni.CppException crash #40699

Closed

roryabraham mentioned this pull request Jun 5, 2024

[No QA] Commit Podfile.lock diff #43150

Merged

48 tasks

Conversation

tienifr commented Apr 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

tienifr commented Apr 24, 2024

Uh oh!

melvin-bot bot commented Apr 24, 2024

Uh oh!

tienifr commented Apr 24, 2024

Uh oh!

mountiny commented Apr 24, 2024

Uh oh!

ShridharGoel commented Apr 24, 2024

Uh oh!

ShridharGoel commented Apr 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

tienifr commented Apr 25, 2024

Uh oh!

tienifr commented Apr 26, 2024

Uh oh!

ShridharGoel commented Apr 26, 2024 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShridharGoel commented Apr 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ShridharGoel commented Apr 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tienifr commented May 2, 2024

Uh oh!

tienifr commented May 2, 2024

Uh oh!

tienifr commented May 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tienifr commented May 3, 2024

Uh oh!

ShridharGoel commented May 3, 2024 via email

Uh oh!

tienifr commented May 6, 2024

Uh oh!

tienifr commented May 7, 2024

Uh oh!

mountiny commented May 8, 2024

Uh oh!

github-actions bot commented May 8, 2024

Uh oh!

mountiny commented May 9, 2024

Uh oh!

ShridharGoel commented May 13, 2024

Uh oh!

mountiny commented May 13, 2024

Uh oh!

tienifr commented May 15, 2024

Uh oh!

ShridharGoel commented May 18, 2024

Uh oh!

mountiny commented May 20, 2024

Uh oh!

github-actions bot commented May 20, 2024

Uh oh!

ShridharGoel commented May 20, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 27, 2024

Uh oh!

tienifr commented Apr 24, 2024 •

edited

Loading

ShridharGoel commented Apr 24, 2024 •

edited

Loading

ShridharGoel commented Apr 26, 2024 via email •

edited

Loading

ShridharGoel commented Apr 28, 2024 •

edited

Loading

ShridharGoel commented Apr 28, 2024 •

edited

Loading

tienifr commented May 2, 2024 •

edited

Loading