Update copy to refer to new URL by tgolen · Pull Request #4091 · Expensify/App

tgolen · 2021-07-15T21:32:20Z

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/170729

Tests

Sign into the app
Go to settings
Go to reset password
Verify the copy mentions "new.expensify.com"
Check the title of the apps (will be different in each platform) and see that they contain "new.expensify.com" now

QA Steps

Same as tests

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

MonilBhavsar · 2021-07-16T06:01:45Z

There are usages of Expensify.cash in Expensify.cash/config/electron.config.js and Expensify.cash/src/libs/actions/IOU.js L163.
Not sure if we need to update it.

tgolen · 2021-07-16T15:40:24Z

Yeah, I wasn't sure about changing those or not, and I think I'd rather err on the side of not changing them. The IOU reference is in a link that goes to Venmo, and I'm not sure if changing that would break anything. The ones in the electron configuration I didn't know if they might break something in the build and deploy process or not, so I left those alone too.

…

On Fri, Jul 16, 2021 at 12:01 AM Monil Bhavsar ***@***.***> wrote: There are usages of Expensify.cash in Expensify.cash/config/electron.config.js and Expensify.cash/src/libs/actions/IOU.js L163. Not sure if we need to update it. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#4091 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJMAB3R4P5OS6CGQB2ESHTTX7DNJANCNFSM5AOLOETQ> .

tgolen · 2021-07-16T20:07:12Z

Hey @kevinksullivan here are the copy changes I had. There is some confusion and inconsistency about the Spanish translations (see this slack convo) which we need to try and resolve.

joelbettner · 2021-07-16T20:20:05Z

I also believe there was some conversation about the new Expensify rather than new Expensify. Not sure how that got resolved.

tgolen · 2021-07-19T14:31:45Z

src/languages/es.js

    },
    termsOfUse: {
-        phrase1: 'Al usar Expensify.cash, estás aceptando los',
+        phrase1: 'Al usar Nuevo Expensify, estás aceptando los',


The english version of this leaves out the name of the app. I think we should do the same here.

English:

By logging in, you agree to the

@iwiznia @marklouisdeshaun what is the proper translation into Spanish?

By logging in, you agree to the

Al iniciar sesión, estás accediendo a los

Does this read correctly, then?

Nope, seems it's missing a line? Is this the up to date copy?

termsOfUse: { phrase1: 'By logging in, you agree to the', phrase2: 'terms of service', phrase3: 'and', phrase4: 'privacy policy', phrase5: 'Money transmission is provided by Expensify Payments LLC (NMLS', phrase6: 'ID:2017010) pursuant to its', phrase7: 'licenses', },

If so:

termsOfUse: { phrase1: 'Al usar Expensify.cash, estás aceptando los', phrase2: 'términos de servicio', phrase3: 'y', phrase4: 'política de privacidad', phrase5: 'El envío de dinero es brindado por Expensify Payments LLC (NMLS', phrase6: 'ID:2017010) de conformidad con sus', phrase7: 'licencias', },

Oh, so sorry... I was looking at the welcome text 🤦

OK, I think I've got it right if you want to check the changes in this PR.

tgolen · 2021-07-19T14:32:39Z

I updated this again after a couple of Slack discussions. Adding a few of our Spanish experts to the review.

tgolen · 2021-07-27T16:54:12Z

bump for review please (there are a few of you assigned)

iwiznia

Just reviewing the spanish translations

src/languages/es.js

Co-authored-by: Ionatan Wiznia <ionatan@expensify.com>

tgolen · 2021-07-27T20:08:12Z

Good catches, @iwiznia. I've applied those.

MonilBhavsar · 2021-07-28T09:29:32Z

This looks good except travis failing. I also found another issue trying to do the same - #4213. @tgolen, can we include that in this PR or tell them we have renamed strings and some notifications in this PR.

kevinksullivan · 2021-07-28T18:12:38Z

src/languages/en.js

    phoneCountryCode: '1',
    welcomeText: {
-        phrase1: 'Welcome to the New Expensify! Enter your phone number or email to continue.',
+        phrase1: 'Welcome to New Expensify! Enter your phone number or email to continue.',


Based on David's Vatican reference, my understanding is the home page saying "the New Expensify" makes sense here.

Cool, updated!

kevinksullivan · 2021-07-28T18:16:04Z

src/languages/en.js

-        expensifyDotCash: 'Expensify.cash',
-        expensifyIsOpenSource: 'The New Expensify is open source',
+        expensifyDotCash: 'New Expensify',
+        expensifyIsOpenSource: 'New Expensify is open source',


Similar to my comment above, if we decide to use "the" at all, this seems like the other sensible place to do so.

I don't think we want to use "the" here because this ends up as the header of the page.

Oh, hold on, I was looking at the line above it for expensifyDotCash.

The phrase for expensifyIsOpenSource is not referenced anywhere, so I will just remove it. I've updated this branch.

kevinksullivan

Added two comments about the insertion of "the" based on my understanding of this conversation. Ultimately these are nitpicks, so feel free to carry on without making the tweaks.

tgolen · 2021-07-30T20:17:36Z

OK, fixed conflicts again, can someone please merge it? It's been approved several times now 😁

Changes were addressed

OSBotify · 2021-08-02T11:58:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2021-08-06T03:18:16Z

🚀 Deployed to staging in version: 1.0.82-8🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2021-08-11T22:18:42Z

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Update copy to refer to new URL

b04040b

tgolen requested a review from a team July 15, 2021 21:32

tgolen self-assigned this Jul 15, 2021

MelvinBot requested review from MonilBhavsar and removed request for a team July 15, 2021 21:32

tgolen added 2 commits July 16, 2021 13:29

Merge branch 'main' into tgolen-password-copy

51adf3c

Taking another stab at the translations

ead2983

tgolen requested a review from a team as a code owner July 16, 2021 20:01

MelvinBot requested review from joelbettner and removed request for a team July 16, 2021 20:01

tgolen requested a review from kevinksullivan July 16, 2021 20:05

A few more corrections after slack discussions

17d344d

tgolen commented Jul 19, 2021

View reviewed changes

tgolen requested review from iwiznia and marklouisdeshaun July 19, 2021 14:32

tgolen added 2 commits July 19, 2021 09:59

Correct the spanish welcome text

da1724c

Redo translation of terms, not welcome

829f1c4

iwiznia removed their request for review July 27, 2021 17:12

iwiznia reviewed Jul 27, 2021

View reviewed changes

src/languages/es.js Outdated Show resolved Hide resolved

src/languages/es.js Outdated Show resolved Hide resolved

tgolen and others added 2 commits July 27, 2021 14:07

Update src/languages/es.js

7afe7cd

Co-authored-by: Ionatan Wiznia <ionatan@expensify.com>

Update src/languages/es.js

b63c3ef

Co-authored-by: Ionatan Wiznia <ionatan@expensify.com>

tgolen mentioned this pull request Jul 28, 2021

[HOLD for payment + Bonus Aug 18] Change site and app titles to New Expensify #4213

Closed

5 tasks

tgolen added 2 commits July 28, 2021 11:11

Merge branch 'main' into tgolen-password-copy

d2b43b7

Revert app name

c78cad6

kevinksullivan reviewed Jul 28, 2021

View reviewed changes

Add "the" into the term

5a990e0

kevinksullivan reviewed Jul 28, 2021

View reviewed changes

kevinksullivan previously requested changes Jul 28, 2021

View reviewed changes

Remove unused language

a56a430

joelbettner approved these changes Jul 29, 2021

View reviewed changes

MonilBhavsar approved these changes Jul 29, 2021

View reviewed changes

Merge branch 'main' into tgolen-password-copy

66612e1

iwiznia merged commit a57f9eb into main Aug 2, 2021

iwiznia deleted the tgolen-password-copy branch August 2, 2021 11:57

This was referenced Aug 2, 2021

Deploy Checklist: Expensify.cash 2021-07-30 #4333

Closed

Deploy Checklist: Expensify.cash 2021-08-06 #4447

Closed

kavimuru mentioned this pull request Aug 6, 2021

Settings - Change password - "New Expensify accounts" displayed instead "new.expensify.com" under Change Password #4482

Closed

Conversation

tgolen commented Jul 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Uh oh!

MonilBhavsar commented Jul 16, 2021

Uh oh!

tgolen commented Jul 16, 2021 via email

Uh oh!

tgolen commented Jul 16, 2021

Uh oh!

joelbettner commented Jul 16, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tgolen commented Jul 19, 2021

Uh oh!

tgolen commented Jul 27, 2021

Uh oh!

iwiznia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tgolen commented Jul 27, 2021

Uh oh!

MonilBhavsar commented Jul 28, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kevinksullivan left a comment

Choose a reason for hiding this comment

Uh oh!

tgolen commented Jul 30, 2021

Uh oh!

OSBotify commented Aug 2, 2021

Uh oh!

OSBotify commented Aug 6, 2021

Uh oh!

OSBotify commented Aug 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tgolen commented Jul 15, 2021 •

edited

Loading