Missing bottom padding fix by lukemorawski · Pull Request #40912 · Expensify/App

lukemorawski · 2024-04-24T15:26:46Z

Details

This PR adds missing bottom padding when safe area bottom padding is absent on screens: ReportCardLostPage.tsx, ReportVirtualCardFraudPage.tsx, TransferBalancePage.tsx, NewTaskPage.tsx

Fixed Issues

$ #40827
PROPOSAL: no proposal

Tests

same as QA
Verify that no errors appear in the JS console

Offline tests

same as QA

QA Steps

Click on Profile photo in botton navigation bar
Click on Wallet
Under "Assigned cards", click on one of the cards
Click on "Report virtual card fraud" or "Report physical card loss / damage"
Or go to home > FAV > assign task > next
verify bottom padding
Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

iOS: mWeb Safari

![web ios](https://github.com/Expensify/App/assets/134388952/9bfc7ae6-d597-4677-b719-92e56c2bf34b)

MacOS: Chrome / Safari

melvin-bot · 2024-04-24T15:26:53Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mollfpr · 2024-04-29T14:18:11Z

I think we also need horizontal padding for the report card fraud page and the transfer balance page.

luacmartins · 2024-04-29T20:05:33Z

Seems like we have another case here - https://expensify.slack.com/archives/C049HHMV9SM/p1714419588771479

luacmartins

Just left a comment. Can we make sure that we address all cases where the padding is missing?

luacmartins

Still waiting on @lukemorawski to address comments

luacmartins · 2024-05-01T14:56:15Z

Bump @lukemorawski

luacmartins

Bump @lukemorawski

MrMuzyk · 2024-05-06T08:39:39Z

@luacmartins Hey, I've been asked to take this over from Luke and will try to update this today :)

…ssing_bottom_padding_fix

luacmartins · 2024-05-06T16:20:29Z

Thanks @MrMuzyk! Looking forward to it!

luacmartins

Waiting on @MrMuzyk to take over the PR and address the comments.

MrMuzyk · 2024-05-07T09:08:13Z

I've updated the console screen and some other screens that were pointed out as well

luacmartins · 2024-05-07T15:45:44Z

Nice! Let me know once the PR is ready for review!

MrMuzyk · 2024-05-08T06:42:53Z

It's ready for review :)

luacmartins

LGTM

luacmartins · 2024-05-08T14:30:17Z

all yours @mollfpr

mollfpr · 2024-05-08T14:31:09Z

Reviewing it now!

mollfpr

The other pages look good to me! Just the report virtual card fraud page seems a bit off.

mollfpr · 2024-05-08T19:09:39Z

src/pages/settings/Wallet/ReportVirtualCardFraudPage.tsx

                onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET_DOMAINCARD.getRoute(cardID))}
            />
-            <View style={[styles.flex1, styles.justifyContentBetween]}>
+            <View style={[styles.flex1, styles.justifyContentBetween, !paddingBottom ? styles.pb5 : null]}>


I feel like the gap in the bottom feels too much. It didn't happen before, so might be because this PR merged last week.

Yes, sorry, I've missed this one 😓

Pushing a fix for this

…ssing_bottom_padding_fix

MrMuzyk · 2024-05-09T08:11:42Z

@mollfpr

I've updated the ReportVirtualCardFraudPage. Should be fine now

Screen.Recording.2024-05-09.at.10.03.06.mov

mollfpr · 2024-05-09T20:31:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2024-05-13T08:42:06Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.73-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-15T09:50:16Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.73-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

added missing padding

34a857a

lukemorawski requested a review from a team as a code owner April 24, 2024 15:26

melvin-bot bot requested review from mollfpr and removed request for a team April 24, 2024 15:26

luacmartins self-requested a review April 29, 2024 20:05

luacmartins reviewed Apr 29, 2024

View reviewed changes

luacmartins self-requested a review April 30, 2024 14:22

luacmartins reviewed Apr 30, 2024

View reviewed changes

luacmartins self-requested a review May 2, 2024 14:51

luacmartins requested changes May 2, 2024

View reviewed changes

Merge branch 'main' of https://github.com/Expensify/App into 40827-mi…

493a1a9

…ssing_bottom_padding_fix

luacmartins self-requested a review May 6, 2024 16:20

luacmartins requested changes May 6, 2024

View reviewed changes

fix: more padding fixes

04a41dc

MrMuzyk mentioned this pull request May 7, 2024

[HOLD for payment 2024-05-22] Bottom button on missing padding #40827

Closed

6 tasks

luacmartins self-requested a review May 7, 2024 15:45

luacmartins previously approved these changes May 8, 2024

View reviewed changes

mollfpr reviewed May 8, 2024

View reviewed changes

Merge branch 'main' of https://github.com/Expensify/App into 40827-mi…

e940f48

…ssing_bottom_padding_fix

fix: report virtual card fraud page fix

ddb7755

MrMuzyk dismissed luacmartins’s stale review via ddb7755 May 9, 2024 08:06

luacmartins self-requested a review May 9, 2024 17:02

luacmartins approved these changes May 9, 2024

View reviewed changes

mollfpr approved these changes May 9, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins May 9, 2024 20:36

luacmartins changed the title ~~Missing bottom padding fix~~ [HOLD merge freeze] Missing bottom padding fix May 9, 2024

luacmartins approved these changes May 9, 2024

View reviewed changes

abdulrahuman5196 mentioned this pull request May 10, 2024

[$250] Bank account - Extra bottom margin below green button in Personal info page #40770

Closed

6 tasks

luacmartins changed the title ~~[HOLD merge freeze] Missing bottom padding fix~~ Missing bottom padding fix May 10, 2024

luacmartins merged commit f894f89 into Expensify:main May 10, 2024

johncschuster mentioned this pull request May 10, 2024

[HOLD for payment 2024-04-29] IOS - Search - Extra padding below Referral banner in Search list #36038

Closed

6 tasks

github-actions bot mentioned this pull request May 13, 2024

Deploy Checklist: New Expensify 2024-05-13 #42040

Closed

74 tasks

Conversation

lukemorawski commented Apr 24, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 24, 2024

Uh oh!

mollfpr commented Apr 29, 2024

Uh oh!

luacmartins commented Apr 29, 2024

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented May 1, 2024

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

MrMuzyk commented May 6, 2024

Uh oh!

luacmartins commented May 6, 2024

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

MrMuzyk commented May 7, 2024

Uh oh!

luacmartins commented May 7, 2024

Uh oh!

MrMuzyk commented May 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented May 8, 2024

Uh oh!

mollfpr commented May 8, 2024

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

mollfpr May 8, 2024

Choose a reason for hiding this comment

Uh oh!

MrMuzyk May 9, 2024

Choose a reason for hiding this comment

Uh oh!

MrMuzyk commented May 9, 2024

Uh oh!

mollfpr commented May 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented May 13, 2024

Uh oh!

OSBotify commented May 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MrMuzyk commented May 8, 2024 •

edited

Loading

mollfpr commented May 9, 2024 •

edited

Loading