Add translations for QBO Sync job by aldo-expensify · Pull Request #41060 · Expensify/App

aldo-expensify · 2024-04-26T06:29:29Z

Needs the following PRs:

Details

Add missing translations coming from the Sync QBO job

The stages names come from here:
https://github.com/Expensify/Integration-Server/blob/7ef13d7fc79a24863e4310e71e5ea348457508c3/src/expensify/progress/ProgressStepMessage.java#L49-L54

These are the same translations from Web-Expensify:

https://github.com/Expensify/Web-Expensify/blob/dd2b65fb6dd4fd0941fa5c462710aa6fc3d9cef6/site/app/global/pushNotificationsTemplates.js#L70-L77

Fixed Issues

$ #41015
$ #41129 (crash)
PROPOSAL:

Tests

Create user
Create Workspace
Go to "More Settings" in the workspace's Settings
Enable "Accounting"
Go to Accounting
Connection QBO
After the connection is done, click the 3 vertical dots in the QBO menu item
Click "Sync now"
Verify that:
- A spinner appears while the sync is happening
- The translation of the stages are not missing
- The spinner goes away after the sync finishes

It should look like this:

Screen.Recording.2024-04-25.at.11.42.14.PM.mov

Verify that no errors appear in the JS console

Offline tests

QA Steps

N/A

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

aldo-expensify · 2024-04-26T22:30:12Z

src/pages/workspace/WorkspaceMoreFeaturesPage.tsx

            subtitleTranslationKey: 'workspace.moreFeatures.taxes.subtitle',
            isActive: (policy?.tax?.trackingEnabled ?? false) || isSyncTaxEnabled,
-            disabled: isSyncTaxEnabled || policy?.connections?.quickbooksOnline.data.country === CONST.COUNTRY.US,
+            disabled: isSyncTaxEnabled || policy?.connections?.quickbooksOnline?.data?.country === CONST.COUNTRY.US,


This was crashing because data was undefined.

ah yep because we're not yet fetching the connections data when the More Features page is opened 👍

I think this is the same crash seen here: #41129

Ahh, OpenPolicyMoreFeaturesPage is already returning the connections data:
https://github.com/Expensify/Auth/blob/e25307a1e009e36672f08f88d5b911694261dc62/auth/lib/Policy.cpp#L3544-L3546

hayata-suenaga · 2024-04-27T19:03:57Z

src/languages/en.ts

                            return 'Importing your QuickBooks Online data';
                        case 'startingImport':
                            return 'Importing your QuickBooks Online data';
+                        case 'quickbooksOnlineSyncTitle':


you're planning to use the constant defined in CONST.ts here?

I wasn't planing to refactor, for some reason we haven't been using CONST 🤷 , so I'm just keeping it consistent

melvin-bot · 2024-04-27T19:52:21Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

c3024 · 2024-04-28T03:37:25Z

This looks like it just adds translations. Does this need a C+ review?

aldo-expensify · 2024-04-29T17:23:47Z

This looks like it just adds translations. Does this need a C+ review?

@c3024 It doesn't and I made this ready for review by mistake :P, sorry about that

luacmartins

LGTM

luacmartins · 2024-04-29T20:12:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

luacmartins · 2024-04-29T20:13:47Z

I said this in Slack, but I think we should get rid of the switch statement, create individual keys and use translateIfPhraseKey instead. Not gonna block this PR since the switch statement is already there.

aldo-expensify · 2024-04-29T20:17:09Z

I said this in Slack, but I think we should get rid of the switch statement, create individual keys and use translateIfPhraseKey instead. Not gonna block this PR since the switch statement is already there.

Follow up issue here: #41248

OSBotify · 2024-04-29T20:22:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-29T23:35:33Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.67-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-04-30T01:15:30Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.68-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-04-30T02:36:18Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.67-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-05-01T02:39:40Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.68-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Add translations for sync job

117e550

aldo-expensify self-assigned this Apr 26, 2024

This was referenced Apr 26, 2024

[Wave Collect][QBO] Chart of Accounts (Categories) not importing on initial connection #41018

Closed

[HOLD for payment 2024-05-08] [HOLD for payment 2024-05-06] [QBO] "Sync Now" button doesn't resync the connection #41015

Closed

Fix country crash

b7197a6

aldo-expensify commented Apr 26, 2024

View reviewed changes

hayata-suenaga reviewed Apr 27, 2024

View reviewed changes

aldo-expensify marked this pull request as ready for review April 27, 2024 19:52

aldo-expensify requested a review from a team as a code owner April 27, 2024 19:52

melvin-bot bot requested review from c3024 and removed request for a team April 27, 2024 19:52

aldo-expensify removed the request for review from c3024 April 29, 2024 17:23

mountiny mentioned this pull request Apr 29, 2024

[HOLD for payment 2024-05-08] Accounting - App crashes when opening More features page after disconnecting QBO #41129

Closed

6 tasks

aldo-expensify requested a review from hayata-suenaga April 29, 2024 20:04

luacmartins approved these changes Apr 29, 2024

View reviewed changes

luacmartins merged commit f421923 into main Apr 29, 2024

luacmartins deleted the aldo_fix-autosync branch April 29, 2024 20:14

github-actions bot mentioned this pull request Apr 29, 2024

Deploy Checklist: New Expensify 2024-04-29 #41266

Closed

74 tasks

Conversation

aldo-expensify commented Apr 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

aldo-expensify Apr 26, 2024

Choose a reason for hiding this comment

Uh oh!

hayata-suenaga Apr 27, 2024

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

aldo-expensify Apr 29, 2024

Choose a reason for hiding this comment

Uh oh!

aldo-expensify Apr 29, 2024

Choose a reason for hiding this comment

Uh oh!

hayata-suenaga Apr 27, 2024

Choose a reason for hiding this comment

Uh oh!

aldo-expensify Apr 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Apr 27, 2024

Uh oh!

c3024 commented Apr 28, 2024

Uh oh!

aldo-expensify commented Apr 29, 2024

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Apr 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

luacmartins commented Apr 29, 2024

Uh oh!

aldo-expensify commented Apr 29, 2024

Uh oh!

OSBotify commented Apr 29, 2024

Uh oh!

OSBotify commented Apr 29, 2024

Uh oh!

OSBotify commented Apr 30, 2024

Uh oh!

OSBotify commented Apr 30, 2024

Uh oh!

OSBotify commented May 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aldo-expensify commented Apr 26, 2024 •

edited

Loading

aldo-expensify Apr 29, 2024 •

edited

Loading

luacmartins commented Apr 29, 2024 •

edited

Loading