Skip to content

[CP Staging] Remove duplicate form fields#4117

Merged
roryabraham merged 1 commit intomainfrom
tgolen-fix-fields
Jul 16, 2021
Merged

[CP Staging] Remove duplicate form fields#4117
roryabraham merged 1 commit intomainfrom
tgolen-fix-fields

Conversation

@tgolen
Copy link
Contributor

@tgolen tgolen commented Jul 16, 2021 •
edited
Loading

This is to fix a bad merge where staging wasn't updated with a fix

Fixed Issues

$ #4060

Tests

  1. Try to invite someone to a workspace
  2. Verify that there are no duplicated form fields

QA Steps

Same as above

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

Desktop

image

iOS

image

Android

image

@tgolen tgolen requested a review from roryabraham July 16, 2021 17:26
@tgolen tgolen requested a review from a team as a code owner July 16, 2021 17:26
@tgolen tgolen self-assigned this Jul 16, 2021
@MelvinBot MelvinBot requested review from mountiny and removed request for a team July 16, 2021 17:26
mountiny
mountiny approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified! Works well!

@tgolen tgolen changed the title Remove duplicate form fields [CP Staging] Remove duplicate form fields Jul 16, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Jul 16, 2021

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@roryabraham roryabraham merged commit 92fd456 into main Jul 16, 2021
@roryabraham roryabraham deleted the tgolen-fix-fields branch July 16, 2021 19:35
github-actions bot pushed a commit that referenced this pull request Jul 16, 2021
@roryabraham
Merge pull request #4117 from Expensify/tgolen-fix-fields
8301c52 
[CP Staging] Remove duplicate form fields

(cherry picked from commit 92fd456)
This was referenced Jul 16, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Jul 16, 2021

🚀 Deployed to staging in version: 1.0.79-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Jul 23, 2021
Closed
60 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jul 23, 2021

🚀 Deployed to production in version: 1.0.79-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jul 23, 2021

🚀 Deployed to staging in version: 1.0.79-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jul 28, 2021

🚀 Deployed to production in version: 1.0.80-2🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

This was referenced Jul 28, 2021
Closed
Closed
This was referenced Aug 6, 2021
Closed
Closed
@OSBotify OSBotify mentioned this pull request Aug 17, 2021
Closed
This was referenced Aug 25, 2021
Closed
Closed
This was referenced Sep 2, 2021
Closed
Closed
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mountiny mountiny mountiny approved these changes

@roryabraham roryabraham roryabraham approved these changes

Assignees

@tgolen tgolen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tgolen @OSBotify @mountiny @roryabraham