Skip to content

Patch for search lhn no results found padding #41221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shawnborton merged 10 commits into from
May 15, 2024
Merged

Patch for search lhn no results found padding #41221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cfd7a8b
added new styling for headermessage
brandonhenry Mar 27, 2024
cdb8f23
Merge remote-tracking branch 'upstream/main' into 37984-fix-search-lh…
brandonhenry Mar 28, 2024
34d1497
Merge remote-tracking branch 'upstream/main' into 37984-fix-search-lh…
brandonhenry Mar 29, 2024
6697acd
Merge remote-tracking branch 'upstream/main' into patch-for-search-lh…
brandonhenry Apr 29, 2024
e35a605
quick fix
brandonhenry Apr 29, 2024
1df02e4
change padding of text input
brandonhenry Apr 29, 2024
f8199f3
fix for list title padding up to 20px
brandonhenry Apr 29, 2024
dd7c679
revert original fix
brandonhenry Apr 30, 2024
e5613f9
Merge remote-tracking branch 'upstream/main' into patch-for-search-lh…
brandonhenry Apr 30, 2024
7e87ea6
fix linter issues
brandonhenry May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/SelectionList/BaseSelectionList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ function BaseSelectionList<TItem extends ListItem>(
// we need to know the heights of all list items up-front in order to synchronously compute the layout of any given list item.
// So be aware that if you adjust the content of the section header (for example, change the font size), you may need to adjust this explicit height as well.
<View style={[styles.optionsListSectionHeader, styles.justifyContentCenter, sectionTitleStyles]}>
<Text style={[styles.ph4, styles.textLabelSupporting]}>{section.title}</Text>
<Text style={[styles.ph5, styles.textLabelSupporting]}>{section.title}</Text>
</View>
);
};
Expand Down Expand Up @@ -516,7 +516,7 @@ function BaseSelectionList<TItem extends ListItem>(
{({safeAreaPaddingBottomStyle}) => (
<View style={[styles.flex1, !isKeyboardShown && safeAreaPaddingBottomStyle, containerStyle]}>
{shouldShowTextInput && (
<View style={[styles.ph4, styles.pb3]}>
<View style={[styles.ph5, styles.pb3]}>
<TextInput
ref={(element) => {
innerTextInputRef.current = element as RNTextInput;
Expand Down
3 changes: 0 additions & 3 deletions src/pages/ChatFinderPage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import useDebouncedState from '@hooks/useDebouncedState';
import useDismissedReferralBanners from '@hooks/useDismissedReferralBanners';
import useLocalize from '@hooks/useLocalize';
import useNetwork from '@hooks/useNetwork';
import useThemeStyles from '@hooks/useThemeStyles';
import type {MaybePhraseKey} from '@libs/Localize';
import Navigation from '@libs/Navigation/Navigation';
import type {RootStackParamList} from '@libs/Navigation/types';
Expand Down Expand Up @@ -53,7 +52,6 @@ const ChatFinderPageFooterInstance = <ChatFinderPageFooter />;

function ChatFinderPage({betas, isSearchingForReports, navigation}: ChatFinderPageProps) {
const [isScreenTransitionEnd, setIsScreenTransitionEnd] = useState(false);
const themeStyles = useThemeStyles();
const {translate} = useLocalize();
const {isOffline} = useNetwork();
const {options, areOptionsInitialized} = useOptionsList({
Expand Down Expand Up @@ -179,7 +177,6 @@ function ChatFinderPage({betas, isSearchingForReports, navigation}: ChatFinderPa
textInputHint={offlineMessage}
onChangeText={setSearchValue}
headerMessage={headerMessage}
headerMessageStyle={headerMessage === translate('common.noResultsFound') ? [themeStyles.ph4, themeStyles.pb5] : undefined}
onLayout={setPerformanceTimersEnd}
onSelectRow={selectReport}
showLoadingPlaceholder={!areOptionsInitialized || !isScreenTransitionEnd}
Expand Down