Add missing multi tag view#41337
Closed
narefyev91 wants to merge 1 commit intoExpensify:mainfrom
narefyev91:add-multi-tag-view
Closed
Add missing multi tag view#41337narefyev91 wants to merge 1 commit intoExpensify:mainfrom narefyev91:add-multi-tag-view
narefyev91 wants to merge 1 commit intoExpensify:mainfrom
narefyev91:add-multi-tag-view
Conversation
Contributor
Author
|
@trjExpensify first path for adding multi tag flow. Currently screens are communicated correctly, just needs to make changes for bulk actions. I think Eto can keep this up Screen.Recording.2024-04-30.at.16.07.17.mov |
Member
Member
Contributor
Contributor
Yep, exactly. Only when more than one level is imported. This example you shared only has one level of tag in view though, but I take it that's just dev antics? 😅 |
Member
|
Will continue on this here #41351 |
Contributor
|
Closing this per #41279 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Details
[QBO] Implement support for importing more than one of Classes, Customers/Projects or Locations on the tags page
Fixed Issues
$ #41279
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop