Skip to content

[Access control]: Hide options visibility and room name for invoices #41380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristipaval merged 1 commit into from
May 1, 2024
Merged

[Access control]: Hide options visibility and room name for invoices #41380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/pages/settings/Report/ReportSettingsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ function ReportSettingsPage({report, policies}: ReportSettingsPageProps) {
const isMoneyRequestReport = ReportUtils.isMoneyRequestReport(report);

const shouldDisableSettings = isEmptyObject(report) || ReportUtils.isArchivedRoom(report) || ReportUtils.isSelfDM(report);
const shouldShowRoomName = !ReportUtils.isPolicyExpenseChat(report) && !ReportUtils.isChatThread(report);
const shouldShowRoomName = !ReportUtils.isPolicyExpenseChat(report) && !ReportUtils.isChatThread(report) && !ReportUtils.isInvoiceRoom(report);
const notificationPreference =
report?.notificationPreference && report.notificationPreference !== CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN
? translate(`notificationPreferencesPage.notificationPreferences.${report.notificationPreference}`)
Expand Down Expand Up @@ -149,6 +149,7 @@ function ReportSettingsPage({report, policies}: ReportSettingsPageProps) {
)}
</View>
{!!report?.visibility &&
report.chatType !== CONST.REPORT.CHAT_TYPE.INVOICE &&
(shouldAllowChangeVisibility ? (
<MenuItemWithTopDescription
shouldShowRightIcon
Expand Down