Show invalid waypoint error message for an invalid distance request route by bernhardoj · Pull Request #41481 · Expensify/App

bernhardoj · 2024-05-02T05:54:43Z

Details

Currently, we show the generic message when an invalid waypoint is submitted. This PR fix it by showing the invalid waypoint error from the BE.

Fixed Issues

$ #38213
PROPOSAL: #38213 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open a workspace chat
Have at least 1 request
Go offline
Create a new distance request with invalid waypoints
Go online
Open the expense report
Verify there is an invalid waypoint error message below the money request preview
Open the transaction thread
Verify there is an invalid waypoint error message below the distance map image

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-02.at.13.51.19.mov

Android: mWeb Chrome

Screen.Recording.2024-05-02.at.14.03.20.mov

iOS: Native

Screen.Recording.2024-05-02.at.13.38.08.mov

iOS: mWeb Safari

Screen.Recording.2024-05-02.at.13.37.21.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-02.at.13.20.32.mov

MacOS: Desktop

Screen.Recording.2024-05-02.at.13.22.45.mov

melvin-bot · 2024-05-02T05:54:48Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

abdulrahuman5196 · 2024-05-07T15:42:31Z

Checking now

abdulrahuman5196 · 2024-05-10T14:22:00Z

The changes looks good and works well on web.

@bernhardoj Could you kindly fix the merge conflicts so that I can continue with platform specific testing.

bernhardoj · 2024-05-11T03:11:03Z

@abdulrahuman5196 conflicts solved.

didn't mean to commit with "p" message

abdulrahuman5196 · 2024-05-13T10:41:41Z

src/pages/home/report/ReportActionItem.tsx

    transaction: OnyxEntry<OnyxTypes.Transaction>;
+
+    /** The transaction (linked with the report action) route error */
+    linkedTransactionRouteError: OnyxEntry<Errors>;


@bernhardoj Sorry I missed this. Why are taking the error object OnyxEntry<Errors> alone? Can't we have the linkedTransaction itself as a prop and take the error inside the class? Similar to how transaction object is present.

We just care about the error object, so @tgolen suggested to use selector to optimize it.

abdulrahuman5196 · 2024-05-15T15:12:06Z

Thank you. Checking again.

abdulrahuman5196 · 2024-05-15T19:11:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-16.at.12.26.22.AM.mp4

Android: mWeb Chrome

Screen.Recording.2024-05-16.at.12.39.16.AM.mp4

iOS: Native

Screen.Recording.2024-05-16.at.12.00.22.AM.mp4

iOS: mWeb Safari

Screen.Recording.2024-05-16.at.12.03.58.AM.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-05-15.at.11.40.10.PM.mp4

MacOS: Desktop

Screen.Recording.2024-05-15.at.11.47.03.PM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @tgolen / @lakchote

🎀 👀 🎀
C+ Reviewed

tgolen

Looks good to me. Thanks!

OSBotify · 2024-05-23T00:39:18Z

🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-27T14:02:26Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.75-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

show the correct route error message

9667716

bernhardoj requested a review from a team as a code owner May 2, 2024 05:54

melvin-bot bot removed the request for review from a team May 2, 2024 05:54

melvin-bot bot requested a review from abdulrahuman5196 May 2, 2024 05:54

fix type

153aa52

p

805b3d5

abdulrahuman5196 reviewed May 13, 2024

View reviewed changes

abdulrahuman5196 approved these changes May 15, 2024

View reviewed changes

melvin-bot bot requested a review from lakchote May 15, 2024 19:18

tgolen approved these changes May 16, 2024

View reviewed changes

lakchote approved these changes May 16, 2024

View reviewed changes

lakchote merged commit bf23770 into Expensify:main May 16, 2024

github-actions bot mentioned this pull request May 22, 2024

Deploy Checklist: New Expensify 2024-05-22 #42496

Closed

45 tasks

lanitochka17 mentioned this pull request May 23, 2024

[$250] Distance - "Error loading messages" appears after dismissing invalid distance error #42518

Closed

6 tasks

melvin-bot bot mentioned this pull request May 27, 2024

[HOLD for payment 2024-06-03] [$500] IOU - Creating IOU Distance offline with incomplete addresses results in incorrect error message #38213

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show invalid waypoint error message for an invalid distance request route#41481

Show invalid waypoint error message for an invalid distance request route#41481
lakchote merged 3 commits intoExpensify:mainfrom
bernhardoj:fix/38213-shows-correct-transaction-error-message

bernhardoj commented May 2, 2024 •

edited

Loading

Uh oh!

melvin-bot bot commented May 2, 2024

Uh oh!

abdulrahuman5196 commented May 7, 2024

Uh oh!

abdulrahuman5196 commented May 10, 2024

Uh oh!

bernhardoj commented May 11, 2024

Uh oh!

abdulrahuman5196 May 13, 2024

Uh oh!

bernhardoj May 13, 2024

Uh oh!

abdulrahuman5196 commented May 15, 2024

Uh oh!

abdulrahuman5196 commented May 15, 2024 •

edited

Loading

Uh oh!

abdulrahuman5196 left a comment •

edited

Loading

Uh oh!

tgolen left a comment

Uh oh!

OSBotify commented May 23, 2024

Uh oh!

OSBotify commented May 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

bernhardoj commented May 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 2, 2024

Uh oh!

abdulrahuman5196 commented May 7, 2024

Uh oh!

abdulrahuman5196 commented May 10, 2024

Uh oh!

bernhardoj commented May 11, 2024

Uh oh!

abdulrahuman5196 May 13, 2024

Choose a reason for hiding this comment

Uh oh!

bernhardoj May 13, 2024

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 commented May 15, 2024

Uh oh!

abdulrahuman5196 commented May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

abdulrahuman5196 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tgolen left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 23, 2024

Uh oh!

OSBotify commented May 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bernhardoj commented May 2, 2024 •

edited

Loading

abdulrahuman5196 commented May 15, 2024 •

edited

Loading

abdulrahuman5196 left a comment •

edited

Loading